hkl indices converted to int also for .incomm files #19

New Issue

2020-11-11T15:35:22+01:00

usov_i commented

2020-11-11 15:35:22 +01:00

(Migrated from gitlab.psi.ch)

Created by: ivan-usov

In a situation, where hkl indices are real numbers the export file extension is .incomm. However, in the export function they are converted to integers:
b5b77d165a/pyzebra/ccl_io.py (L241-L243)

This doesn't look correct.

*Created by: ivan-usov* In a situation, where `hkl` indices are real numbers the export file extension is `.incomm`. However, in the export function they are converted to integers: https://github.com/paulscherrerinstitute/pyzebra/blob/b5b77d165abb866c9d60656bc428eb61062b1fe2/pyzebra/ccl_io.py#L241-L243 This doesn't look correct.

usov_i commented

2020-11-22 22:09:44 +01:00

(Migrated from gitlab.psi.ch)

Created by: zaharko

I think this is working correct now, but I ask for a possibility to extend format up to 4 digits after comma.
A default format - 2 digits, but exceptionally user should be able to request till 4 digits.

*Created by: zaharko* I think this is working correct now, but I ask for a possibility to extend format up to 4 digits after comma. A default format - 2 digits, but exceptionally user should be able to request till 4 digits.

usov_i commented

2020-11-22 22:12:09 +01:00

(Migrated from gitlab.psi.ch)

Created by: zaharko

ccl_intergation:
In the table on the left all hkl indices are integers, which is not correct.

*Created by: zaharko* ccl_intergation: In the table on the left all hkl indices are integers, which is not correct.

usov_i commented

2020-11-23 09:47:38 +01:00

(Migrated from gitlab.psi.ch)

Created by: ivan-usov

I think the best would be to auto-detect if there is a need for more digits after comma (with a minimum of 2 and a maximum of 4). The output will be formatted accordingly.

*Created by: ivan-usov* I think the best would be to auto-detect if there is a need for more digits after comma (with a minimum of 2 and a maximum of 4). The output will be formatted accordingly.

usov_i commented

2020-11-23 16:44:53 +01:00

(Migrated from gitlab.psi.ch)

Created by: ivan-usov

Would it be also ok to export numbers with trailing 0s truncated? In other words:
1.23456 -> 1.2345 (max 4 digits)
1.2340 -> 1.234
1.000 -> 1 (here, i'm not sure if you'd like to have 1.00)

*Created by: ivan-usov* Would it be also ok to export numbers with trailing 0s truncated? In other words: 1.23456 -> 1.2345 (max 4 digits) 1.2340 -> 1.234 1.000 -> 1 (here, i'm not sure if you'd like to have 1.00)

usov_i commented

2020-11-23 16:59:11 +01:00

(Migrated from gitlab.psi.ch)

Created by: ivan-usov

The issue with hkl indices in the table is fixed in 0d8a30b995

*Created by: ivan-usov* The issue with hkl indices in the table is fixed in 0d8a30b995c407a87b0beee952e66b3ea184f384

usov_i commented

2020-11-23 18:13:36 +01:00

(Migrated from gitlab.psi.ch)

Created by: zaharko

Okay to:

1.23456 -> 1.2345 (max 4 digits)
1.2340 -> 1.234

This should be truncated to the same amount of digits as other indices, i.e. if request is 4 digits, then for all h, k and l

1.000 -> 1 (here, i'm not sure if you'd like to have 1.00)

*Created by: zaharko* Okay to: > 1.23456 -> 1.2345 (max 4 digits) > 1.2340 -> 1.234 This should be truncated to the same amount of digits as other indices, i.e. if request is 4 digits, then for all h, k and l > 1.000 -> 1 (here, i'm not sure if you'd like to have 1.00) >

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: zebra/pyzebra#19