Lorentz correction not applied to area sigma #18

New Issue

2020-11-10T16:27:50+01:00

usov_i commented

2020-11-10 16:27:50 +01:00

(Migrated from gitlab.psi.ch)

Created by: ivan-usov

After some refactoring I noticed that the lorentz correction is applied only to area, but not to it's sigma:
4343d6e2b6/pyzebra/ccl_io.py (L252-L262)

I wonder, if it should also influence the resulting area sigma, @JakHolzer ? Feel free to close the issue, if the lorentz correction should affect only the area value.

*Created by: ivan-usov* After some refactoring I noticed that the lorentz correction is applied only to area, but not to it's sigma: https://github.com/paulscherrerinstitute/pyzebra/blob/4343d6e2b6c51c9c2041781de7d7fb7d0604c7b3/pyzebra/ccl_io.py#L252-L262 I wonder, if it should also influence the resulting area sigma, @JakHolzer ? Feel free to close the issue, if the lorentz correction should affect only the area value.

usov_i commented

2020-11-10 16:32:15 +01:00

(Migrated from gitlab.psi.ch)

Created by: JakHolzer

Thats a very good point, however I'm not sure. I suggest to raise the
question on thursday and deal with it after Oksana decides.

út 10. 11. 2020 v 16:28 odesílatel Ivan Usov notifications@github.com
napsal:

After some refactoring I noticed that the lorentz correction is applied
only to area, but not to it's sigma:

4343d6e2b6/pyzebra/ccl_io.py (L252-L262)

I wonder, if it should also influence the resulting area sigma, @JakHolzer
https://github.com/JakHolzer ? Feel free to close the issue, if the
lorentz correction should affect only the area value.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/paulscherrerinstitute/pyzebra/issues/18, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AM2BBRXUSCX2ANQFSP4IAETSPFLYRANCNFSM4TQZUN5A
.

*Created by: JakHolzer* Thats a very good point, however I'm not sure. I suggest to raise the question on thursday and deal with it after Oksana decides. út 10. 11. 2020 v 16:28 odesílatel Ivan Usov <notifications@github.com> napsal: > After some refactoring I noticed that the lorentz correction is applied > only to area, but not to it's sigma: > > https://github.com/paulscherrerinstitute/pyzebra/blob/4343d6e2b6c51c9c2041781de7d7fb7d0604c7b3/pyzebra/ccl_io.py#L252-L262 > > I wonder, if it should also influence the resulting area sigma, @JakHolzer > <https://github.com/JakHolzer> ? Feel free to close the issue, if the > lorentz correction should affect only the area value. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/paulscherrerinstitute/pyzebra/issues/18>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AM2BBRXUSCX2ANQFSP4IAETSPFLYRANCNFSM4TQZUN5A> > . >

usov_i commented

2020-11-10 16:53:35 +01:00

(Migrated from gitlab.psi.ch)

Created by: ivan-usov

@zaharko , @rsibille-psi do you have any comments on that?

*Created by: ivan-usov* @zaharko , @rsibille-psi do you have any comments on that?

usov_i commented

2020-11-10 17:10:49 +01:00

(Migrated from gitlab.psi.ch)

Created by: rsibille-psi

Yes, I would say that the Lorentz correction should also affect the area sigma.
This is multiplying a measurement value with an exact number, thus we should multiply the uncertainty also with that exact number.

*Created by: rsibille-psi* Yes, I would say that the Lorentz correction should also affect the area sigma. This is multiplying a measurement value with an exact number, thus we should multiply the uncertainty also with that exact number.

usov_i commented

2020-11-23 16:59:44 +01:00

(Migrated from gitlab.psi.ch)

Created by: ivan-usov

Fixed in 008761e661

*Created by: ivan-usov* Fixed in 008761e661a62b302a13d54afe267f81e70e98d6

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: zebra/pyzebra#18