zebra/pyzebra
3
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

Issue with fitting when y_err is 0 #17

New Issue
Closed
opened 2020-11-02 11:16:47 +01:00 by usov_i · 0 comments
usov_i commented 2020-11-02 11:16:47 +01:00 (Migrated from gitlab.psi.ch)
Copy Link
Copy Source

Created by: ivan-usov

The fitting routine doesn't seem to handle the situation with y_err being 0 for any point of data. In the following code:
https://github.com/paulscherrerinstitute/pyzebra/blob/cfe9832c1e09feb0c6474a0d54894bd41301cdbc/pyzebra/fit2.py#L134-L136
it will encounter division by 0 in weights calculation, which apparently breaks mod.fit function.

*Created by: ivan-usov* The fitting routine doesn't seem to handle the situation with y_err being 0 for any point of data. In the following code: https://github.com/paulscherrerinstitute/pyzebra/blob/cfe9832c1e09feb0c6474a0d54894bd41301cdbc/pyzebra/fit2.py#L134-L136 it will encounter division by 0 in `weights` calculation, which apparently breaks `mod.fit` function.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
sibille_r (sibille_r) usov_i (usov_i) zaharko (zaharko)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: zebra/pyzebra#17
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?