hkl order in comm_export #14

New Issue

2020-10-22T15:12:55+02:00

usov_i commented

2020-10-22 15:12:55 +02:00

(Migrated from gitlab.psi.ch)

Created by: ivan-usov

The order of hkl indices in exported files is somewhat unusual:
32d75988b7/pyzebra/comm_export.py (L69-L71)

@JakHolzer , @zaharko Is it correct that comm/incomm files require that order? Feel free to close it, if that's the case.

*Created by: ivan-usov* The order of hkl indices in exported files is somewhat unusual: https://github.com/paulscherrerinstitute/pyzebra/blob/32d75988b77ce4f8330f78f2fc94cc92fb84b759/pyzebra/comm_export.py#L69-L71 @JakHolzer , @zaharko Is it correct that comm/incomm files require that order? Feel free to close it, if that's the case.

usov_i commented

2020-10-22 15:15:54 +02:00

(Migrated from gitlab.psi.ch)

Created by: JakHolzer

Hello Ivan,
thank you for pointing that out. It wrong, the order needs to be hkl, not
hlk. I shall fix it immediately.
Thans!
Jakub

čt 22. 10. 2020 v 15:13 odesílatel Ivan Usov notifications@github.com
napsal:

The order of hkl indices in exported files is somewhat unusual:

32d75988b7/pyzebra/comm_export.py (L69-L71)

@JakHolzer https://github.com/JakHolzer , @zaharko
https://github.com/zaharko Is it correct that comm/incomm files require
that order? Feel free to close it, if that's the case.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/paulscherrerinstitute/pyzebra/issues/14, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AM2BBRV3SHSOC72JFLWSBYDSMAVWXANCNFSM4S3FYOVQ
.

*Created by: JakHolzer* Hello Ivan, thank you for pointing that out. It wrong, the order needs to be hkl, not hlk. I shall fix it immediately. Thans! Jakub čt 22. 10. 2020 v 15:13 odesílatel Ivan Usov <notifications@github.com> napsal: > The order of hkl indices in exported files is somewhat unusual: > > https://github.com/paulscherrerinstitute/pyzebra/blob/32d75988b77ce4f8330f78f2fc94cc92fb84b759/pyzebra/comm_export.py#L69-L71 > > @JakHolzer <https://github.com/JakHolzer> , @zaharko > <https://github.com/zaharko> Is it correct that comm/incomm files require > that order? Feel free to close it, if that's the case. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/paulscherrerinstitute/pyzebra/issues/14>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AM2BBRV3SHSOC72JFLWSBYDSMAVWXANCNFSM4S3FYOVQ> > . >

usov_i commented

2020-10-22 15:30:01 +02:00

(Migrated from gitlab.psi.ch)

Created by: ivan-usov

@rsibille-psi FYI, in case you already exported some files

*Created by: ivan-usov* @rsibille-psi FYI, in case you already exported some files

usov_i commented

2020-10-23 17:10:01 +02:00

(Migrated from gitlab.psi.ch)

Created by: ivan-usov

Fixed in 0347566aeb

@JakHolzer , also could you write "Fix #.." in the commit title/message, so that when pushed to master it will automatically close the corresponding issue? Thanks!

*Created by: ivan-usov* Fixed in 0347566aeb16fc7c84d10d01dc9b289c69c110b1 @JakHolzer , also could you write "Fix #.." in the commit title/message, so that when pushed to master it will automatically close the corresponding issue? Thanks!

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: zebra/pyzebra#14