Issue with fitting data #12

New Issue

Closed

opened 2020-10-20 10:37:34 +02:00 by usov_i · 1 comment

usov_i commented 2020-10-20 10:37:34 +02:00 (Migrated from gitlab.psi.ch)

Copy Link

Created by: ivan-usov

Trying to fit test data in zebra2020n000039.ccl, measurement 19, yields the following error:

....
  File "/das/home/usov_i/pyzebra/pyzebra/fit2.py", line 135, in fitccl
    fit_area = u.ufloat(result.params["g_amp"].value, result.params["g_amp"].stderr)
  File "/das/work/p15/p15876/miniconda3/envs/pyz/lib/python3.6/site-packages/uncertainties/core.py", line 3274, in ufloat
    final_ufloat = ufloat_obsolete(nominal_value, tag_arg)
  File "/das/work/p15/p15876/miniconda3/envs/pyz/lib/python3.6/site-packages/uncertainties/core.py", line 3217, in ufloat_obsolete
    return ufloat_fromstr(representation, tag)
  File "/das/work/p15/p15876/miniconda3/envs/pyz/lib/python3.6/site-packages/uncertainties/core.py", line 3201, in ufloat_fromstr
    representation.strip())
AttributeError: 'numpy.float64' object has no attribute 'strip'

Checking the values in result shows that result.params["g_amp"].stderr is None, which causes an exception in u.ufloat.

Probably, the order of code needs an adjustment, because right after there is the check for result.params["g_amp"].stderr being None:
18ba623fd8/pyzebra/fit2.py (L138)

*Created by: ivan-usov* Trying to fit test data in `zebra2020n000039.ccl`, measurement 19, yields the following error: ``` .... File "/das/home/usov_i/pyzebra/pyzebra/fit2.py", line 135, in fitccl fit_area = u.ufloat(result.params["g_amp"].value, result.params["g_amp"].stderr) File "/das/work/p15/p15876/miniconda3/envs/pyz/lib/python3.6/site-packages/uncertainties/core.py", line 3274, in ufloat final_ufloat = ufloat_obsolete(nominal_value, tag_arg) File "/das/work/p15/p15876/miniconda3/envs/pyz/lib/python3.6/site-packages/uncertainties/core.py", line 3217, in ufloat_obsolete return ufloat_fromstr(representation, tag) File "/das/work/p15/p15876/miniconda3/envs/pyz/lib/python3.6/site-packages/uncertainties/core.py", line 3201, in ufloat_fromstr representation.strip()) AttributeError: 'numpy.float64' object has no attribute 'strip' ``` Checking the values in `result` shows that `result.params["g_amp"].stderr` is `None`, which causes an exception in `u.ufloat`. Probably, the order of code needs an adjustment, because right after there is the check for `result.params["g_amp"].stderr` being `None`: https://github.com/paulscherrerinstitute/pyzebra/blob/18ba623fd84d8f9707886e8d7b6a5868e14337b5/pyzebra/fit2.py#L138

usov_i commented 2020-10-22 12:08:44 +02:00 (Migrated from gitlab.psi.ch)

Copy Link

Created by: ivan-usov

Fixed in 6722ee601e

*Created by: ivan-usov* Fixed in 6722ee601e925575c8f1e5308a235305ed71f5f1

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

0.7.11

0.7.10

0.7.9

0.7.8

0.7.7

0.7.6

0.7.5

0.7.4

0.7.3

0.7.2

0.7.1

0.7.0

0.6.5

0.6.4

0.6.3

0.6.2

0.6.1

0.6.0

0.5.2

0.5.1

0.5.0

0.4.0

0.3.2

0.3.1

0.3.0

0.2.2

0.2.1

0.2.0

0.1.3

0.1.2

0.1.1

0.1.0

Labels

Clear labels

bug

documentation

duplicate

enhancement

good first issue

help wanted

invalid

question

wontfix

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

sibille_r usov_i zaharko

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: zebra/pyzebra#12