zebra/pyzebra
3
0
Fork 0
Code Issues 4 Pull Requests Actions Packages Projects Releases Wiki Activity

An h5 dataset path typo in read_detector_data #1

New Issue
Closed
opened 2020-03-31 10:39:46 +02:00 by usov_i · 1 comment
usov_i commented 2020-03-31 10:39:46 +02:00 (Migrated from gitlab.psi.ch)
Copy Link
Copy Source

Created by: ivan-usov

https://github.com/paulscherrerinstitute/pyzebra/blob/0e495b60cd035e86d09df90c30532b69fe044805/pyzebra/h5.py#L53

@zaharko probably, the path should read "/entry1/sample/phi" instead.

Also note the absence of 'ZEBRA' in path. This should also be the case for all these variables:
https://github.com/paulscherrerinstitute/pyzebra/blob/0e495b60cd035e86d09df90c30532b69fe044805/pyzebra/h5.py#L52-L54

*Created by: ivan-usov* https://github.com/paulscherrerinstitute/pyzebra/blob/0e495b60cd035e86d09df90c30532b69fe044805/pyzebra/h5.py#L53 @zaharko probably, the path should read "/entry1/sample/phi" instead. Also note the absence of 'ZEBRA' in path. This should also be the case for all these variables: https://github.com/paulscherrerinstitute/pyzebra/blob/0e495b60cd035e86d09df90c30532b69fe044805/pyzebra/h5.py#L52-L54
usov_i commented 2020-03-31 10:56:04 +02:00 (Migrated from gitlab.psi.ch)
Copy Link
Copy Source

Created by: zaharko

Sure, this was a typo

*Created by: zaharko* Sure, this was a typo
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
sibille_r (sibille_r) usov_i (usov_i) zaharko (zaharko)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: zebra/pyzebra#1
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?