usov_i-org/bec
1
0
Fork 0
mirror of https://github.com/ivan-usov-org/bec.git synced 2025-04-22 02:20:02 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

refactor: avoid logger <-> messages circular import

Browse Source 
This is a preventive measure. The logger module needs LogMessage, and
messages module needs bec_logger, so as one possible fix, delay
LogMessage access in logger.
This commit is contained in:
usov_i 2023-11-10 16:46:49 +01:00 committed by usov_i
parent 298faaf140
commit ddc12ba9bc
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
bec_lib/bec_lib/logger.py
View File

@ -7,7 +7,9 @@ from typing import TYPE_CHECKING
from loguru import logger as loguru_logger from loguru import logger as loguru_logger
from bec_lib import messages # TODO: Importing bec_lib, instead of `from bec_lib.messages import LogMessage`, avoids potential
# logger <-> messages circular import. But there could be a better solution.
import bec_lib
from bec_lib.endpoints import MessageEndpoints from bec_lib.endpoints import MessageEndpoints
if TYPE_CHECKING: if TYPE_CHECKING:
@ -64,7 +66,9 @@ class BECLogger:
msg["service_name"] = self.service_name msg["service_name"] = self.service_name
self.producer.send( self.producer.send(
topic=MessageEndpoints.log(), topic=MessageEndpoints.log(),
msg=messages.LogMessage(log_type=msg["record"]["level"]["name"], content=msg).dumps(), msg=bec_lib.messages.LogMessage(
log_type=msg["record"]["level"]["name"], content=msg
).dumps(),
) )
@property @property