From 8dfe1ef9ae028b050b8ee97ad9448525b70eb433 Mon Sep 17 00:00:00 2001
From: tligui_y <yasmine.tligui@psi.ch>
Date: Mon, 28 Jul 2025 20:39:27 +0200
Subject: [PATCH] Update tests/test_utils_metaclasses.py

---
 tests/test_utils_metaclasses.py | 55 +++++++++++++++++++++------------
 1 file changed, 36 insertions(+), 19 deletions(-)

diff --git a/tests/test_utils_metaclasses.py b/tests/test_utils_metaclasses.py
index 9adcb8c7f..a325288cf 100644
--- a/tests/test_utils_metaclasses.py
+++ b/tests/test_utils_metaclasses.py
@@ -1,10 +1,10 @@
 import pytest
-import sys
-import os
-sys.path.insert(0, os.path.abspath(os.path.join(os.path.dirname(__file__), '..')))
-from slic.utils.metaclasses import *
+from abc import abstractmethod
+from slic.utils.metaclasses import combine_classes, RegistryABC
+from slic.core.registry import instances
 
-# Base classes
+
+# Test combine two simple classes with unique methods
 class A:
     def method_a(self):
         return "A"
@@ -13,20 +13,37 @@ class B:
     def method_b(self):
         return "B"
 
-# Combine A and B into a single metaclass
-CombinedMeta = combine_classes(A, B)
+def test_combine_classes_combines_methods():
+    # Dynamically combine A and B using combine_classes
+    Combined = combine_classes(A, B)
+    obj = Combined()
 
-# Use it as metaclass for a new class
-class MyCombinedClass(metaclass=CombinedMeta):
-    pass
-
-def test_combine_classes_as_metaclass():
-
-    obj = MyCombinedClass()
-
-    # Verify that methods from both base classes are available
-    assert isinstance(obj, MyCombinedClass)
-    assert isinstance(obj, A)  # via metaclass
-    assert isinstance(obj, B)  # via metaclass
+    # Check that both methods are available
     assert obj.method_a() == "A"
     assert obj.method_b() == "B"
+
+
+# Test validate that RegistryABC correctly inherits from ABCMeta and RegistryMeta
+def test_registryabc_combines_registrymeta_and_abcmeta():
+    # Define an abstract class using RegistryABC
+    class AbstractThing(RegistryABC):
+        @abstractmethod
+        def doit(self):
+            pass
+
+    # Cannot instantiate abstract class without implementing abstract methods
+    with pytest.raises(TypeError):
+        AbstractThing()
+
+    # Define a concrete subclass that implements the abstract method
+    class ConcreteThing(AbstractThing):
+        def doit(self):
+            return "yes"
+
+    obj = ConcreteThing()
+
+    # ABCMeta behavior: abstract method works
+    assert obj.doit() == "yes"
+
+    # RegistryMeta behavior: instance is automatically registered
+    assert obj in instances(AbstractThing)