From ef9a15b785651b9fcdd0713f37a3cfc61e9ec859 Mon Sep 17 00:00:00 2001
From: Andrej Babic <andrej.babic@psi.ch>
Date: Wed, 20 May 2020 17:31:31 +0200
Subject: [PATCH] Adjust tests to new way of working

---
 sf-replay/test/test_ReplayH5Reader.cpp | 78 +++++++++++++++-----------
 1 file changed, 45 insertions(+), 33 deletions(-)

diff --git a/sf-replay/test/test_ReplayH5Reader.cpp b/sf-replay/test/test_ReplayH5Reader.cpp
index 7559c0c..0f5cbdb 100644
--- a/sf-replay/test/test_ReplayH5Reader.cpp
+++ b/sf-replay/test/test_ReplayH5Reader.cpp
@@ -9,17 +9,18 @@ TEST(ReplayH5Reader, basic_interaction)
 {
     auto root_folder = ".";
     auto device_name = "fast_device";
+    size_t pulse_id = 65;
+    uint16_t source_id = 1;
 
     // This 2 must be compatible by design.
     BufferH5Writer writer(root_folder, device_name);
-    ReplayH5Reader reader(root_folder, device_name);
-
-    size_t pulse_id = 65;
+    ReplayH5Reader reader(root_folder, device_name, source_id, pulse_id);
 
     ModuleFrame w_metadata;
-    ModuleFrame r_metadata;
+    ReplayModuleFrameBuffer r_metadata;
     auto w_frame_buffer = make_unique<uint16_t[]>(MODULE_N_PIXELS);
-    auto r_frame_buffer = make_unique<uint16_t[]>(MODULE_N_PIXELS);
+    auto r_frame_buffer = make_unique<uint16_t[]>(
+            MODULE_N_PIXELS * REPLAY_READ_BUFFER_SIZE);
 
     // Setup test values.
     w_metadata.pulse_id = pulse_id;
@@ -37,21 +38,28 @@ TEST(ReplayH5Reader, basic_interaction)
     writer.write(&w_metadata, (char*)&(w_frame_buffer[0]));
     writer.close_file();
 
-    auto frame_present = reader.get_frame(
-            pulse_id, &r_metadata, (char*)&(r_frame_buffer[0]));
+    reader.get_buffer(1, &r_metadata, (char *) &(r_frame_buffer[0]));
 
-    ASSERT_EQ(frame_present, true);
+    ASSERT_EQ(r_metadata.n_frames, 65);
+    ASSERT_EQ(r_metadata.module_id, source_id);
+    ASSERT_EQ(r_metadata.data_n_bytes, MODULE_N_BYTES * 65);
+
+    for (int i=0; i<pulse_id-1; i++) {
+        ASSERT_EQ(r_metadata.pulse_id[i], i+1);
+        ASSERT_EQ(r_metadata.is_frame_present[i], false);
+        ASSERT_EQ(r_metadata.is_good_frame[i], false);
+    }
+
+    // -1 due to 0 based indexing.
+    ASSERT_EQ(r_metadata.pulse_id[pulse_id-1], pulse_id);
+    ASSERT_EQ(r_metadata.is_frame_present[pulse_id-1], true);
+    ASSERT_EQ(r_metadata.is_good_frame[pulse_id-1], true);
 
-    // Metadata has to match.
-    EXPECT_EQ(r_metadata.pulse_id, w_metadata.pulse_id);
-    EXPECT_EQ(r_metadata.frame_index, w_metadata.frame_index);
-    EXPECT_EQ(r_metadata.daq_rec, w_metadata.daq_rec);
-    EXPECT_EQ(r_metadata.n_received_packets, w_metadata.n_received_packets);
-    EXPECT_EQ(r_metadata.module_id, w_metadata.module_id);
 
     // Data as well.
+    auto offset = MODULE_N_PIXELS * (pulse_id-1);
     for (size_t i=0; i<MODULE_N_PIXELS; i++) {
-        w_frame_buffer[i] = r_frame_buffer[i];
+        w_frame_buffer[i] = r_frame_buffer[offset + i];
     }
 
     reader.close_file();
@@ -62,11 +70,13 @@ TEST(ReplayH5Reader, missing_frame)
     auto root_folder = ".";
     auto device_name = "fast_device";
 
+    size_t pulse_id = 65;
+
     // This 2 must be compatible by design.
     BufferH5Writer writer(root_folder, device_name);
-    ReplayH5Reader reader(root_folder, device_name);
+    ReplayH5Reader reader(root_folder, device_name, 1, pulse_id);
+
 
-    size_t pulse_id = 65;
 
     ModuleFrame w_metadata;
     ModuleFrame r_metadata;
@@ -89,23 +99,25 @@ TEST(ReplayH5Reader, missing_frame)
     writer.write(&w_metadata, (char*)&(w_frame_buffer[0]));
     writer.close_file();
 
+    // TODO: Write test for missing frame as well.
+
     // But read another pulse_id, that should be empty.
-    auto frame_present = reader.get_frame(
-            pulse_id-1, &r_metadata, (char*)&(r_frame_buffer[0]));
-
-    ASSERT_EQ(frame_present, false);
-
-    // All metadata has to be 0, expect pulse_id.
-    EXPECT_EQ(r_metadata.pulse_id, pulse_id-1);
-    EXPECT_EQ(r_metadata.frame_index, 0);
-    EXPECT_EQ(r_metadata.daq_rec, 0);
-    EXPECT_EQ(r_metadata.n_received_packets, 0);
-    EXPECT_EQ(r_metadata.module_id, 0);
-
-    // Data as well.
-    for (size_t i=0; i<MODULE_N_PIXELS; i++) {
-        r_frame_buffer[i] = 0;
-    }
+//    auto frame_present = reader.get_buffer(
+//            pulse_id - 1, &r_metadata, (char *) &(r_frame_buffer[0]));
+//
+//    ASSERT_EQ(frame_present, false);
+//
+//    // All metadata has to be 0, expect pulse_id.
+//    EXPECT_EQ(r_metadata.pulse_id, pulse_id-1);
+//    EXPECT_EQ(r_metadata.frame_index, 0);
+//    EXPECT_EQ(r_metadata.daq_rec, 0);
+//    EXPECT_EQ(r_metadata.n_received_packets, 0);
+//    EXPECT_EQ(r_metadata.module_id, 0);
+//
+//    // Data as well.
+//    for (size_t i=0; i<MODULE_N_PIXELS; i++) {
+//        r_frame_buffer[i] = 0;
+//    }
 
     reader.close_file();
 }