From 95bf06f56ae1c23109cb12201debf862f53c6c15 Mon Sep 17 00:00:00 2001
From: Andrej Babic <andrej.babic@psi.ch>
Date: Wed, 30 Jan 2019 14:07:16 +0100
Subject: [PATCH] Move Dummy implementation to header

---
 lib/src/H5Writer.cpp | 20 +-------------------
 lib/src/H5Writer.hpp | 22 +++++++++++++++-------
 2 files changed, 16 insertions(+), 26 deletions(-)

diff --git a/lib/src/H5Writer.cpp b/lib/src/H5Writer.cpp
index e1d95e0..a0083be 100644
--- a/lib/src/H5Writer.cpp
+++ b/lib/src/H5Writer.cpp
@@ -322,26 +322,8 @@ H5::H5File& H5Writer::get_h5_file()
     return file;
 }
 
-DummyH5Writer::DummyH5Writer() : H5Writer("/dev/null", 0, 0, 0){}
-
-void DummyH5Writer::create_file(hsize_t frame_chunk){}
-
-void DummyH5Writer::close_file(){}
-
-void DummyH5Writer::write_data(const string& dataset_name, const size_t data_index, const char* data, const std::vector<size_t>& data_shape, 
-    const size_t data_bytes_size, const string& data_type, const string& endianness){};
-
-bool DummyH5Writer::is_file_open() const
+H5::H5File& DummyH5Writer::get_h5_file()
 {
-    return false;
-}
-
-bool DummyH5Writer::is_data_for_current_file(const size_t data_index)
-{
-    return true;
-}
-
-H5::H5File& DummyH5Writer::get_h5_file(){
     stringstream error_message;
     using namespace date;
     error_message << "[" << std::chrono::system_clock::now() << "]";
diff --git a/lib/src/H5Writer.hpp b/lib/src/H5Writer.hpp
index d4b13fc..f88b415 100644
--- a/lib/src/H5Writer.hpp
+++ b/lib/src/H5Writer.hpp
@@ -49,17 +49,25 @@ class H5Writer
 class DummyH5Writer : public H5Writer
 {
     public:
-        DummyH5Writer();
-        bool is_file_open() const override;
-        void create_file(const hsize_t frame_chunk=1) override;
-        void close_file() override;
+        DummyH5Writer() : H5Writer("/dev/null", 0, 0, 0) {}
+
+        bool is_file_open() const override
+            { return false; }
+
+        void create_file(const hsize_t frame_chunk=1) override {}
+
+        void close_file() override {}
+
         void write_data(const std::string& dataset_name, const size_t data_index, const char* data, const std::vector<size_t>& data_shape, 
-            const size_t data_bytes_size, const std::string& data_type, const std::string& endianness) override;
+            const size_t data_bytes_size, const std::string& data_type, const std::string& endianness) override {}
+
         H5::H5File& get_h5_file() override;
-        bool is_data_for_current_file(const size_t data_index) override;
+
+        bool is_data_for_current_file(const size_t data_index) override
+            { return true; }
 };
 
 std::unique_ptr<H5Writer> get_h5_writer(const std::string& filename, hsize_t frames_per_file=0, 
     hsize_t initial_dataset_size=1000, hsize_t dataset_increase_step=1000);
 
-#endif
\ No newline at end of file
+#endif