From 481fc9878a1ea6dbd0bca7c3316dab196589eca1 Mon Sep 17 00:00:00 2001
From: Andrej Babic <andrej.babic@psi.ch>
Date: Tue, 20 Nov 2018 14:28:59 +0100
Subject: [PATCH] Add tests for MetadataBuffer

---
 lib/test/test_MetadataBuffer.cpp | 53 +++++++++++++++++++++++---------
 1 file changed, 38 insertions(+), 15 deletions(-)

diff --git a/lib/test/test_MetadataBuffer.cpp b/lib/test/test_MetadataBuffer.cpp
index 054f395..c7f252e 100644
--- a/lib/test/test_MetadataBuffer.cpp
+++ b/lib/test/test_MetadataBuffer.cpp
@@ -1,10 +1,9 @@
-
 #include "../src/MetadataBuffer.hpp"
+
 using namespace std;
 
 TEST(MetadataBuffer, basic_operations)
 {
-
     int n_frames = 10;
     int n_modules = 3;
 
@@ -13,31 +12,55 @@ TEST(MetadataBuffer, basic_operations)
         {"module_number", HeaderDataType("uint64", n_modules)}
     });
 
-    MetadataBuffer metadata_buffer(10, header_values);
+    MetadataBuffer metadata_buffer(n_frames, header_values);
 
     uint64_t base_frame_data = 12345678;
     uint64_t base_module_number = 0;
 
     for (int i = 0; i<n_frames; i++) {
-	uint64_t frame_index = base_frame_data + i;
-	metadata_buffer.add_metadata_to_buffer("frame", i, (char*)&frame_index);
+        uint64_t frame_index = base_frame_data + i;
+        metadata_buffer.add_metadata_to_buffer("frame", i, (char*)&frame_index);
 
-	uint64_t module_number = base_module_number + i;
-	uint64_t module_number_data[n_modules];
+        uint64_t module_number = base_module_number + i;
+        uint64_t module_number_data[n_modules];
 
-	for (int module_index=0; module_index<n_modules; module_index++) {
-	    module_number_data[module_index] = module_number;
-	}
-	
-	metadata_buffer.add_metadata_to_buffer("module_number", i, (char*)&module_number_data);
+        for (int module_index=0; module_index<n_modules; module_index++) {
+            module_number_data[module_index] = module_number;
+        }
+        
+        metadata_buffer.add_metadata_to_buffer("module_number", i, (char*)&module_number_data);
     }
 
     uint64_t* frame_data = (uint64_t*) metadata_buffer.get_metadata_values("frame").get();
-    uint64_t* modulo_number_data = (uint64_t*) metadata_buffer.get_metadata_values("modulo_number").get();
+    uint64_t* module_number_data = (uint64_t*) metadata_buffer.get_metadata_values("module_number").get();
 
     for (int i = 0; i<n_frames; i++) {
-	EXPECT_EQ(frame_data[i], base_frame_data+i);
-    }
+	    EXPECT_EQ(frame_data[i], base_frame_data+i);
 
+        for (int module_index=0; module_index<n_modules; module_index++) {
+            EXPECT_EQ(module_number_data[n_modules*i + module_index], base_module_number + i);
+        }
+    }
 }
 
+TEST(MetadataBuffer, missing_keys)
+{
+    int n_frames = 10;
+    int n_modules = 3;
+
+    auto header_values = shared_ptr<unordered_map<string, HeaderDataType>>(new unordered_map<string, HeaderDataType> {
+        {"frame", HeaderDataType("uint64")},
+        {"module_number", HeaderDataType("uint64", n_modules)}
+    });
+
+    MetadataBuffer metadata_buffer(n_frames, header_values);
+
+    uint64_t data = 0;
+
+    metadata_buffer.add_metadata_to_buffer("frame", 0, (char*)&data);
+    metadata_buffer.get_metadata_values("frame");
+
+    EXPECT_THROW(metadata_buffer.get_metadata_values("non_existant"), runtime_error);
+    EXPECT_THROW(metadata_buffer.add_metadata_to_buffer("non_existant", 0, nullptr), runtime_error);
+    EXPECT_THROW(metadata_buffer.add_metadata_to_buffer("frame", n_frames, nullptr), runtime_error);
+}
\ No newline at end of file