From 1aba1c4e86416922ef9cdaebe1e6a1007823827b Mon Sep 17 00:00:00 2001 From: Andrej Babic Date: Wed, 30 Jan 2019 09:59:33 +0100 Subject: [PATCH] Refactor buffered writer --- lib/src/BufferedWriter.cpp | 8 +++----- lib/src/BufferedWriter.hpp | 7 ++++--- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/lib/src/BufferedWriter.cpp b/lib/src/BufferedWriter.cpp index 9656b44..e5e3b50 100644 --- a/lib/src/BufferedWriter.cpp +++ b/lib/src/BufferedWriter.cpp @@ -52,13 +52,11 @@ void BufferedWriter::write_metadata_to_file() } } -void BufferedWriter::close_file() -{ - H5Writer::close_file(); -} - DummyBufferedWriter::DummyBufferedWriter() : BufferedWriter("/dev/null", 0, 0, 0, 0){} +void DummyBufferedWriter::cache_metadata(string name, uint64_t frame_index, const char* data){} +void DummyBufferedWriter::write_metadata_to_file() {} + std::unique_ptr get_buffered_writer(const string& filename, size_t total_frames, std::unique_ptr metadata_buffer, hsize_t frames_per_file, hsize_t dataset_increase_step) { diff --git a/lib/src/BufferedWriter.hpp b/lib/src/BufferedWriter.hpp index d86211d..bfc6d3c 100644 --- a/lib/src/BufferedWriter.hpp +++ b/lib/src/BufferedWriter.hpp @@ -12,15 +12,16 @@ class BufferedWriter : public H5Writer public: BufferedWriter(const std::string& filename, size_t total_frames, std::unique_ptr&& metadata_buffer, hsize_t frames_per_file=0, hsize_t initial_dataset_size=1000, hsize_t dataset_increase_step=1000); - void cache_metadata(std::string name, uint64_t frame_index, const char* data); - void write_metadata_to_file(); - virtual void close_file() override; + virtual void cache_metadata(std::string name, uint64_t frame_index, const char* data); + virtual void write_metadata_to_file(); }; class DummyBufferedWriter : public BufferedWriter { public: DummyBufferedWriter(); + void cache_metadata(std::string name, uint64_t frame_index, const char* data) override; + void write_metadata_to_file() override; }; std::unique_ptr get_buffered_writer(const std::string& filename, size_t total_frames,