diff --git a/dap/algos/streakfind.py b/dap/algos/streakfind.py index 0e95b59..fd1c373 100644 --- a/dap/algos/streakfind.py +++ b/dap/algos/streakfind.py @@ -26,7 +26,7 @@ def calc_streakfinder_analysis(results, data, pixel_mask): return data negative_val_handler = results.get("cbd_negative_handler", "") - _handle_negative_values(data, pixel_mask, negative_val_handler) + _handle_negative_values(data, pixel_mask, negative_val_handler) # changes data and pixel_mask in place try: snr = _calc_snr(results, data, pixel_mask) @@ -35,11 +35,11 @@ def calc_streakfinder_analysis(results, data, pixel_mask): return data if do_snr: - # Changes data in-place + # Changes data in-place #TODO: actually, looks like this is not an in-place change data = snr try: - _calc_streakfinder_analysis(results, snr, pixel_mask) + _calc_streakfinder_analysis(results, snr, pixel_mask) # changes pixel_mask in place if cbd_mask_rois given except Exception as error: # Broad exception - we don't want to break anything here results["cbd_error"] = f"StreakFind - Error processing CBD data:\n{error}" @@ -154,6 +154,7 @@ def _calc_streakfinder_analysis(results, snr, mask): y_center = results.get("beam_center_y", None) mask_rois = results.get("cbd_mask_rois", []) # list of [x_min, x_max, y_min, y_max] + #TODO: copy mask if mask_rois is truthy for mask_roi in mask_rois: mask[mask_roi[2]: mask_roi[3], mask_roi[0]: mask_roi[1]] = False