From 464bbf46e803dbac9d59b7756e2ef6199560f9a0 Mon Sep 17 00:00:00 2001 From: salman Date: Thu, 24 Sep 2026 14:37:35 +0200 Subject: [PATCH] Exclude build-id links from rpm to avoid electron conflicts Two Electron applications built from the identical electron binary set package the same ELF build-id links under /usr/lib/.build-id, so installing musrflow next to trimsp failed the transaction test. Pass _build_id_links none to rpmbuild via fpm so the rpm no longer claims those paths. --- CHANGELOG.md | 3 +++ package.json | 6 +++++- tests/release-packaging.test.js | 1 + 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 95163ec..171c098 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,6 +15,9 @@ release path documented in [`TODO.md`](TODO.md). - The RPM artifact is now named all-lower-case (`musrflow--.rpm`) instead of the mixed-case product name, since RPM package names must be lower case. +- The RPM no longer ships ELF build-id links under `/usr/lib/.build-id`, which + previously conflicted when another Electron application built from the same + binary set (e.g. `trimsp`) was installed. ## 1.0.0-rc.4 (2026-09-23) diff --git a/package.json b/package.json index 0e462fc..455fbe1 100644 --- a/package.json +++ b/package.json @@ -85,7 +85,11 @@ }, "rpm": { "packageCategory": "Applications/Science", - "artifactName": "${name}-${version}-${arch}.${ext}" + "artifactName": "${name}-${version}-${arch}.${ext}", + "fpm": [ + "--rpm-rpmbuild-define=_build_id_links none", + "--rpm-rpmbuild-define=_missing_build_ids_terminate_build 0" + ] } } } diff --git a/tests/release-packaging.test.js b/tests/release-packaging.test.js index 32356ae..a4ce3b9 100644 --- a/tests/release-packaging.test.js +++ b/tests/release-packaging.test.js @@ -18,6 +18,7 @@ assert(pkg.build.linux.target.includes('rpm')); assert(pkg.build.linux.target.includes('AppImage')); assert.strictEqual(pkg.build.rpm.artifactName, '${name}-${version}-${arch}.${ext}'); assert(!pkg.build.rpm.artifactName.includes('${productName}'), 'RPM artifact name must be lower case'); +assert(pkg.build.rpm.fpm.some(function(arg) { return arg === '--rpm-rpmbuild-define=_build_id_links none'; }), 'RPM must not package build-id links'); assert(pkg.scripts['dist:rpm'].includes('electron-builder@26.15.3')); assert(pkg.scripts['dist:appimage'].includes('electron-builder@26.15.3')); assert(pkg.scripts['checksums:md5'].includes('md5sum'));