From 7dd7121ce73a774361a5c17c52ee9333431b22ea Mon Sep 17 00:00:00 2001 From: Achim Gsell Date: Fri, 27 Mar 2026 10:58:11 +0100 Subject: [PATCH] fix: selecting variant if variant to build is 'first_match' --- Pmodules/modbuild.in | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Pmodules/modbuild.in b/Pmodules/modbuild.in index 614237b..cf522af 100644 --- a/Pmodules/modbuild.in +++ b/Pmodules/modbuild.in @@ -1060,6 +1060,7 @@ build_modules_yaml_v1(){ local -- compiler local -- mpi + local -i n=0 for compiler in "${with_compiler[@]}"; do for mpi in "${with_mpi[@]}"; do # build if opt_with_modules is empty or compiler is in this array @@ -1075,9 +1076,11 @@ build_modules_yaml_v1(){ "$3" \ "${compiler}" \ "${mpi}" \ - "${@:4}" + "${@:4}" || std::die 42 "Fatal error building the module!" + (( n++ )) done done + (( n > 0 )) } build_modules_hdf5(){ @@ -1508,7 +1511,7 @@ build_modules_yaml_v1(){ variant_config || continue build_modules_variant \ "${name}" "${version}" \ - variant_config + variant_config || continue if [[ "${mod_config['build_variants']}" == 'first_match' ]]; then break fi