From 1b43ccbe21228548dd7e5e486c2445a69f074209 Mon Sep 17 00:00:00 2001
From: Achim Gsell <achim.gsell@psi.ch>
Date: Wed, 28 Apr 2021 10:56:00 +0200
Subject: [PATCH] modulecmd.bash.in: bugfix in initialization of overlays

the variables required for overlays were not initialized in a proper
way if we switch from a Pmodules version without overlay support
---
 Pmodules/modulecmd.bash.in | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/Pmodules/modulecmd.bash.in b/Pmodules/modulecmd.bash.in
index 420cd30..c2ac3ee 100644
--- a/Pmodules/modulecmd.bash.in
+++ b/Pmodules/modulecmd.bash.in
@@ -2639,7 +2639,9 @@ if [[ -z "${Subcommands[${subcommand}]}" ]]; then
 	std::die 1 "${CMD}: unknown sub-command -- ${subcommand}"
 fi
 
-_init_overlay_map() {
+_init_overlay_vars() {
+	declare -ag OverlayList=( "${PMODULES_ROOT}" )
+	declare -Ag OverlayDict=([${PMODULES_ROOT}]="0")
 	local overlay
 	for overlay in "${!OverlayDict[@]}"; do
 		local group
@@ -2650,6 +2652,7 @@ _init_overlay_map() {
 			fi
 		done
 	done
+	save_env 'yes'
 }
 
 if [[ -n ${PMODULES_ENV} ]]; then
@@ -2658,10 +2661,7 @@ if [[ -n ${PMODULES_ENV} ]]; then
 	# OverlayList might not be set. Since libmodules.tcl
 	# reads PMODULES_ENV we have to save the environment.
 	if [[ -z "${OverlayList}" ]]; then
-		declare -ag OverlayList=( "${PMODULES_ROOT}" )
-		declare -Ag OverlayDict=([${PMODULES_ROOT}]="0")
-		_init_overlay_map
-		save_env
+		_init_overlay_vars
 	fi
 else
 	pmodules_init