From 0e258cc8c9d0eb8ceb474cfe1a09bfc1cf5ba41f Mon Sep 17 00:00:00 2001
From: CV-GPhL <vonrhein@globalphasing.com>
Date: Wed, 4 Feb 2026 11:20:21 +0100
Subject: [PATCH] Null terminate buffer in file.c

Ensure the buffer is null terminated after allocation - otherwise correct results from strcmp below is undefined.
---
 src/file.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/src/file.c b/src/file.c
index 74ebeb7..170d764 100644
--- a/src/file.c
+++ b/src/file.c
@@ -651,13 +651,9 @@ herr_t det_visit_callback(hid_t root_id, const char *name,
       ERROR_JUMP(-1, close_mtype, message);
     }
 
-    /* at least one file has been seen where the NX_class attribute was not null
-     * terminated and extraneous bytes where being read by strcmp -  set the end
-     * byte to null
-     */
+    /* ensure the buffer is null terminated */
+    buffer[H5Tget_size(t_id)] = '\0';
 
-    if (str_size > 0)
-      ((char *)buffer)[str_size] = '\0';
     /* test for NXdata or NXdetector */
     {
       char *nxclass = str_size > 0 ? (char *)buffer : *((char **)buffer);