leonarski_fandClaude Opus 4.8
eadbce51bd
Build Packages / build:rpm (ubuntu2404_nocuda) (push) Successful in 10m48s
Build Packages / build:rpm (ubuntu2204_nocuda) (push) Successful in 11m35s
Build Packages / build:rpm (rocky8_nocuda) (push) Successful in 12m2s
Build Packages / build:rpm (rocky8_sls9) (push) Successful in 12m58s
Build Packages / build:rpm (rocky8) (push) Successful in 13m0s
Build Packages / build:rpm (rocky9_nocuda) (push) Successful in 13m58s
Build Packages / build:rpm (rocky9_sls9) (push) Successful in 14m29s
Build Packages / XDS test (durin plugin) (push) Successful in 7m30s
Build Packages / Generate python client (push) Successful in 39s
Build Packages / Build documentation (push) Successful in 51s
Build Packages / Create release (push) Skipped
Build Packages / build:rpm (ubuntu2404) (push) Successful in 10m11s
Build Packages / build:rpm (ubuntu2204) (push) Successful in 10m55s
Build Packages / build:rpm (rocky9) (push) Successful in 12m15s
Build Packages / XDS test (JFJoch plugin) (push) Successful in 9m11s
Build Packages / XDS test (neggia plugin) (push) Successful in 8m33s
Build Packages / DIALS test (push) Successful in 12m0s
Build Packages / Unit tests (push) Successful in 57m36s
The phi bounds were stored as plain floats internally but passed through std::optional in the constructor, which obscured the intent. Take them as float arguments defaulting to 0 instead. The convention is explicit: phi_min == phi_max means the full ring (all angles), a sector wraps across 0 when phi_min > phi_max, and otherwise phi_min <= phi_max. The "both bounds or none" rule belongs at the API/file boundary (OpenAPIConvert, reader), not in the core class, so it lives there now. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
29 lines
1.1 KiB
C++
29 lines
1.1 KiB
C++
// SPDX-FileCopyrightText: 2024 Filip Leonarski, Paul Scherrer Institute <filip.leonarski@psi.ch>
|
|
// SPDX-License-Identifier: GPL-3.0-only
|
|
|
|
#pragma once
|
|
|
|
#include "ROIElement.h"
|
|
|
|
class ROIAzimuthal : public ROIElement {
|
|
float d_min_A, d_max_A;
|
|
// Azimuthal-angle sector, normalized to [0, 360). phi_min_deg == phi_max_deg means
|
|
// the full ring (all angles); a sector with phi_min_deg > phi_max_deg wraps across 0.
|
|
float phi_min_deg = 0;
|
|
float phi_max_deg = 0;
|
|
public:
|
|
ROIAzimuthal(const std::string &name, float d_min_A, float d_max_A,
|
|
float phi_min_deg = 0, float phi_max_deg = 0);
|
|
~ROIAzimuthal() override = default;
|
|
[[nodiscard]] float GetDMin_A() const;
|
|
[[nodiscard]] float GetDMax_A() const;
|
|
[[nodiscard]] float GetQMin_recipA() const;
|
|
[[nodiscard]] float GetQMax_recipA() const;
|
|
[[nodiscard]] bool HasPhi() const; // a sector is set (phi_min_deg != phi_max_deg)
|
|
[[nodiscard]] float GetPhiMin_deg() const;
|
|
[[nodiscard]] float GetPhiMax_deg() const;
|
|
|
|
bool CheckROI(int64_t x, int64_t y, float resolution, float phi_deg) const override;
|
|
ROIConfig ExportMetadata() const override;
|
|
};
|