Three terms of the score of a model - the same F_model at every stage, the as-given start and the refined end alike - and a breakdown of it: - Riding hydrogens from the start: the dictionary's hydrogens are added before the model is first scored (REFMAC's 0-cycle restores them; they move R by 0.010-0.013 at 1.1 A). The engine is made once, with them. - The bulk-solvent mask on a grid of its own, min(d_min/3, 0.4 A), at most 2^26 points. On the density grid (1.1 A at 3.3 A) gemmi's 0.8 A shrink found no grid offset and was skipped, which put R 0.015-0.03 high at >= 2.5 A. 0.3 and 0.4 A agree to 0.001. - The overall scale and anisotropic B by robust least squares (pseudo-Huber, iteratively reweighted, c = median |residual|) in the fine pass of the k_sol/b_sol grid (ModelScaleBox::robust, refinement only; MR and validation keep the plain fit). Plain least squares on |F| is the exact LS optimum but lets a few badly-fitted strong reflections set the scale (1.1 A set: R 0.1706 against REFMAC's 0.1600). The scale fit of refinement now runs on the CPU (no ModelScaleGPUPool). RefinementSettings::score_only scores the model as given and stops; RefinementResult::score_start carries every term (k, B, anisotropic B, k_sol, b_sol, mask spacing, R in 20 shells, -lnL work/free, the likelihood FOM, hydrogens; per-reflection terms with score_only). GeometryStatistics gains rmsZ. rugnux_refine_test: --score-only, --dump. Measured against REFMAC 5.8.0431 ncyc 0 (refi bref iso) on the same model, data and flags, 14 open-arm sets 1.1-3.6 A: R-work/R-free within 0.002 on 12 (was +0.003..+0.03); 7n2s and 9yl4 score 0.003/0.005 below REFMAC, which a 0.6-0.8 A mask grid reproduces. REFMAC with ANISOU stripped scores identically, so isotropic B is not a parity term. Open: the likelihood's D/FOM (ours 0.01-0.11 higher at high resolution); geometry differs only by REFMAC's metal LINK restraints and residues outside the embedded dictionary. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015CeEGgpKdfkCTJb3YNMJcu (cherry picked from commit 4f94b21611874ad9dcf89e6771fe311a0e10bb06) (cherry picked from commit 00db6a6f539ac2da515c0a649474335f4c4b07b8)
88 lines
4.4 KiB
C++
88 lines
4.4 KiB
C++
// SPDX-FileCopyrightText: 2026 Filip Leonarski, Paul Scherrer Institute <filip.leonarski@psi.ch>
|
|
// SPDX-License-Identifier: GPL-3.0-only
|
|
|
|
#pragma once
|
|
|
|
#include <condition_variable>
|
|
#include <cstddef>
|
|
#include <memory>
|
|
#include <mutex>
|
|
#include <vector>
|
|
|
|
#include "gemmi/model.hpp"
|
|
#include "gemmi/scaling.hpp"
|
|
|
|
// Fit the overall scale, the anisotropic B and the flat bulk solvent of a model to observed
|
|
// amplitudes, writing the answer into `scaling` (k_overall, b_star, k_sol, b_sol) so that
|
|
// gemmi's own scale_data() can then apply it.
|
|
//
|
|
// The caller decides which reflections are fitted: FitModelScale reads scaling.points, which
|
|
// prepare_points() filled. Pass the WORKING set to keep the free reflections out of the scale
|
|
// model - that is a property of the call site, not of this function.
|
|
//
|
|
// Replaces gemmi's fit_isotropic_b_approximately() + fit_parameters(), which is an unbounded
|
|
// Levenberg-Marquardt: nothing there stops k_sol and b_sol reaching values a flat solvent model
|
|
// is meaningless at (b_sol of 1707 A^2 was measured on this corpus). Here k_sol and b_sol come
|
|
// from a grid search over the physical ranges, so an unphysical answer cannot be represented.
|
|
// The box the solvent parameters are searched in. The defaults are the physically reasonable
|
|
// range reported by Fokine & Urzhumtsev and adopted as phenix's default grid: k_sol in (0.1, 0.8)
|
|
// and b_sol in (10, 80) A^2, of which phenix searches b_sol 10-80 in steps of 5. A model with high
|
|
// atomic B gets a higher b_sol ceiling (SolventBMax).
|
|
struct ModelScaleBox {
|
|
double k_lo = 0.10, k_hi = 0.60;
|
|
double b_lo = 10.0, b_hi = 80.0;
|
|
// The overall scale and anisotropic B of the points of the fine pass by robust least squares
|
|
// (ModelScaling.cpp, RobustReweight) rather than plain least squares on |F|: what refinement scores a model with.
|
|
bool robust = false;
|
|
};
|
|
|
|
// The b_sol ceiling for `model`: 80 A^2, or twice the model's mean atomic B where that is higher.
|
|
// b_sol is how far the solvent's edge is smeared, and the edge can be no sharper than the atoms it
|
|
// lies against: a model at B of 300 A^2 beside a solvent held at 80 gets a solvent term that reaches
|
|
// far too deep in resolution, which only a too-small k_sol can then offset. Fokine & Urzhumtsev's
|
|
// 10-80 A^2 is for models at the B of ordinary entries (their mean b_sol 46 A^2), where the ceiling
|
|
// stays at 80.
|
|
double SolventBMax(const gemmi::Model &model);
|
|
|
|
struct ModelScaleReport {
|
|
int n_points = 0; // reflections the fit actually used
|
|
int n_grid = 0; // grid points evaluated
|
|
double r_work_fit = 1.0; // R on the fitted reflections, at the chosen solution
|
|
};
|
|
|
|
// nthreads: the grid points are fitted in parallel on up to this many threads; the answer does not
|
|
// depend on it.
|
|
ModelScaleReport FitModelScale(gemmi::Scaling<float> &scaling, ModelScaleBox box = {}, size_t nthreads = 1);
|
|
|
|
#ifdef JFJOCH_USE_CUDA
|
|
// FitModelScale on a GPU (ModelScaleGPU::FitSolvent): the same grid over the same box, the same fits and
|
|
// the same winner, with the sums over the reflections taken in double on the device where the host takes
|
|
// them in long double - so the answer is FitModelScale's to rounding, not to the bit. A few engines,
|
|
// reserved once, each a stream and room for one fit at a time; a fit takes a free one and waits for one
|
|
// where all are taken. Every kernel is deterministic, so which engine a fit gets changes no number.
|
|
class ModelScaleGPUPool {
|
|
public:
|
|
// What `engines` engines for fits of up to `max_points` reflections take on the card.
|
|
static size_t DeviceBytes(size_t max_points, size_t engines);
|
|
// On `device`. Throws JFJochException on a CUDA failure.
|
|
ModelScaleGPUPool(int device, size_t max_points, size_t engines);
|
|
~ModelScaleGPUPool();
|
|
|
|
// FitModelScale(scaling, {.b_hi = b_hi}, nthreads). Where FitModelScale would walk the grid point to
|
|
// point (five or fewer reflections for the isotropic start), it is FitModelScale on the host. Safe to
|
|
// call from several threads. Throws JFJochException on a CUDA failure.
|
|
ModelScaleReport Fit(gemmi::Scaling<float> &scaling, double b_hi, size_t nthreads);
|
|
// What the pool holds on the card.
|
|
size_t Bytes() const { return DeviceBytes(max_points_, engines_.size()); }
|
|
|
|
private:
|
|
struct Engine;
|
|
int device_;
|
|
size_t max_points_;
|
|
std::vector<std::unique_ptr<Engine>> engines_;
|
|
std::vector<Engine *> idle_;
|
|
std::mutex m_;
|
|
std::condition_variable cv_;
|
|
};
|
|
#endif
|