Files
Jungfraujoch/image_analysis/structure_refinement/ModelDensityGPU.h
T
leonarski_fandClaude Fable 5.1 546566cff4
Build Packages / Create release (push) Successful in 8s
Build Packages / build:portable:macos-arm64:nocuda (push) Successful in 5m12s
Build Packages / build:rugnux:linux-aarch64:cuda (push) Successful in 10m30s
Build Packages / build:portable:linux-x86_64:nocuda (push) Successful in 19m8s
Build Packages / build:portable:linux-x86_64:cuda (push) Successful in 23m7s
Build Packages / build:portable:windows-x86_64:nocuda (push) Successful in 23m26s
Build Packages / build:jfjoch:ubuntu2204:nocuda (push) Successful in 24m31s
Build Packages / build:portable:windows-x86_64:cuda (push) Successful in 27m40s
Build Packages / build:jfjoch:rocky8:nocuda (push) Successful in 28m31s
Build Packages / HDF5 consumer tests (DIALS, XDS) (push) Successful in 29m50s
Build Packages / build:jfjoch:rocky9:nocuda (push) Successful in 29m47s
Build Packages / build:jfjoch:ubuntu2404:nocuda (push) Successful in 23m42s
Build Packages / Generate python client (push) Successful in 32s
Build Packages / Build documentation (push) Successful in 1m0s
Build Packages / build:jfjoch:rocky8:cuda-sls9 (push) Successful in 24m45s
Build Packages / build:jfjoch:rocky9:cuda-sls9 (push) Successful in 29m59s
Build Packages / build:jfjoch:rocky8:cuda (push) Successful in 28m32s
Build Packages / build:jfjoch:ubuntu2204:cuda (push) Successful in 24m14s
Build Packages / build:jfjoch:ubuntu2404:cuda (push) Successful in 27m49s
Build Packages / build:jfjoch:rocky9:cuda (push) Successful in 30m1s
Build Packages / Unit tests (push) Successful in 1h33m58s
Build Packages / Validation Battery (push) Successful in 36m7s
Refinement: the gather's pairs built in fixed-shape buffers, and each evaluation replayed as a CUDA graph
ModelDensityGPU::Compute() no longer reads the pair count back to the host between its launches: the atoms
are counted per brick with integer atomics, the counts scanned into the bricks' segments, the segments
filled through atomics and then each brick put into model order by rank (one block per brick), which leaves
the pairs exactly as the stable radix sort of the atom-major fill left them - the gather sums in the same
order, bit for bit. The pair bound of the atoms set is checked on the host at SetAtoms() instead of on the
device at every evaluation, and the buffers shrink from four to three ints per pair.

With nothing coming back mid-evaluation, RefinementGPUEngine records the X-ray evaluation and the restraint
evaluation each as a CUDA graph on its stream (cudaStreamBeginCapture, thread-local mode) and replays it,
re-recording only where the shape changes (the atom count, a gradient asked or not, a restraint set
re-uploaded). Two graphs, not one, so that the host still fills the restraints' positions while the X-ray
half runs, as before. Where a stream cannot be captured the launches are queued as they were.

Outputs byte-identical to 037c32d9f on the in-house cytochrome C live run (MTZ arrays, HKL, models,
blobs, report). Workstation (RTX 5080): refinement 1.64 -> 1.50 s on that run.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015CeEGgpKdfkCTJb3YNMJcu
2026-10-27 05:57:57 +01:00

100 lines
5.2 KiB
C++

// SPDX-FileCopyrightText: 2026 Filip Leonarski, Paul Scherrer Institute <filip.leonarski@psi.ch>
// SPDX-License-Identifier: GPL-3.0-only
#pragma once
// The density of a model's atoms on a grid, on the GPU (CUDA builds only): gemmi's
// DensityCalculator::put_model_density_on_grid() without the symmetrize - ONE copy of the content. The
// rigid body (RigidBodyGPU.cu) and the model's structure factors (ModelStructureFactorsGPU.cu) both grid
// with it, and compose the crystal's symmetry in reciprocal space (SymmetryComposition, RigidBodyRefine.h).
//
// A gather, not a scatter: the grid is cut into bricks of BRICK^3 points, each brick is one block, and
// every point adds, in model order, each atom whose box holds it and whose radius reaches it. Nothing is
// summed with a floating-point atomic. The arithmetic is the CPU walk's (UseDensityBoxesByPlane and
// AtomDensity, ModelGrid.cpp; ModelDensityMetal.metal spells out the same), so the grid is
// PutModelDensityOnGrid()'s before its symmetrize, bit for bit, for the same atoms and centres -
// tests/ModelDensityGPUTest.cpp holds it to that.
#include <cstddef>
#include <vector>
#include <cuda_runtime.h>
#include "../indexing/CUDAMemHelpers.h"
// One atom's density on a grid, as PutModelDensityOnGrid() (ModelGrid.cpp) sets it up: gemmi's
// precalculated five-Gaussian sum and the radius it cuts the sum at.
struct ModelDensityAtom {
float a[5];
float b[5][6]; // isotropic: b[k][0] multiplies r^2; anisotropic: the matrix, u11 u22 u33 u12 u13 u23
float occ;
float radius;
float max_r2; // the radius squared, as PutModelDensityOnGrid() rounds it: float(radius^2) in double
int aniso;
};
// The grid the density is put on, u fastest: index = u + nu * (v + nv * w).
struct ModelDensityGrid {
int nu = 0, nv = 0, nw = 0;
double orth[9] = {}, frac[9] = {}; // the cell's, row-major
};
class ModelDensityGPU {
public:
// The bytes an instance of this capacity reserves on the device.
static size_t DeviceBytes(size_t max_atoms, size_t max_pairs, size_t max_bricks);
static size_t Bricks(int nu, int nv, int nw);
// The most gather bricks the 2 d + 1 points of an atom's box can fall in along an axis of n points.
static size_t AxisBrickBound(int d, int n);
// gemmi's box around each atom (MakeAtomBox, ModelGrid.cpp): the points within ceil(radius / spacing)
// of the nearest one along each axis, three per atom.
static std::vector<int> Boxes(const ModelDensityGrid &grid, const std::vector<ModelDensityAtom> &atoms);
static void Boxes(const ModelDensityGrid &grid, const ModelDensityAtom *atoms, size_t n, int *box);
// (brick, atom) pairs of the gather over at most.
static size_t PairBound(const ModelDensityGrid &grid, const std::vector<ModelDensityAtom> &atoms);
static size_t PairBound(const ModelDensityGrid &grid, const int *box, size_t n);
// Whether the gather reproduces gemmi's box walk on this grid: every atom's box narrower than the cell,
// so that no point is reached by two images of one atom.
static bool Supports(const ModelDensityGrid &grid, const std::vector<ModelDensityAtom> &atoms);
static bool Supports(const ModelDensityGrid &grid, const int *box, size_t n);
ModelDensityGPU(cudaStream_t stream, size_t max_atoms, size_t max_pairs, size_t max_bricks);
// The grid and the atoms' densities. Throws if they are over the capacity or if !Supports(). The atoms are
// read until the call returns; from pinned memory (PinnedVector) they go up by DMA.
void SetAtoms(const ModelDensityGrid &grid, const std::vector<ModelDensityAtom> &atoms);
void SetAtoms(const ModelDensityGrid &grid, const ModelDensityAtom *atoms, size_t n);
// The density into d_grid (nu * nv * nw floats, every point written). d_pos: each atom's centre in
// grid units - its fractional position times the grid size, as the CPU's DensityBox holds it, not
// wrapped into the cell - in the order SetAtoms() got them; w is not read. Queued on the stream, nothing
// waited for: the pairs are built in buffers of a fixed shape, so this records into a CUDA graph.
void Compute(const float4 *d_pos, float *d_grid);
// The densities and the boxes of the atoms last set, on the device, for a kernel that walks the same boxes.
const ModelDensityAtom *DeviceAtoms() const { return atoms; }
const int *DeviceBoxes() const { return box; }
// What the gather kernel needs of the grid.
struct Geometry {
int nu, nv, nw;
// gemmi's orth_n, orth * diag(1/nu, 1/nv, 1/nw), upper triangular, in single precision
float m00, m01, m02, m11, m12, m22;
};
private:
cudaStream_t stream;
size_t max_atoms, max_pairs, max_bricks;
Geometry geom{};
int n_atoms = 0;
CudaDevicePtr<ModelDensityAtom> atoms;
CudaDevicePtr<int> box;
CudaHostPtr<int> host_box; // the boxes' staging buffer, pinned
// per brick its atoms counted, where its segment starts (max_bricks + 1: the last entry the total) and how
// far it is filled; per pair the atom as the fill placed it, its rank in the brick, and in model order
CudaDevicePtr<int> brick_count, brick_start, brick_fill, unordered, rank, pair_atom;
CudaDevicePtr<char> cub_temp;
size_t cub_bytes = 0;
};