Files
Jungfraujoch/common/IndexingSettings.cpp
T
leonarski_fandClaude Opus 5 4e8db41785 indexing: refuse a coplanar candidate, and search the plane normal when the shortlist is flat
Three related changes to the FFT candidate path, batteried together because they touch the same
function.

A COPLANAR CANDIDATE REACHED REFINEMENT. ReduceResults filtered triples on lengths and angles only -
the 30-150 degree bound admits any flat combination - and there was no volume test. On one dataset 41
of 5535 candidates had |V|/abc below 0.05, with a clean decade gap to the next, and three of them
reached the optimizer. UnitCell is float, and for a cell that flat the metric determinant is around
1.5e-7, so float32 gets its sign wrong 19% of the time where float64 never does. The guard against a
negative argument to sqrt then CREATES the singularity it was meant to prevent: it puts c in the a-b
plane, the reciprocal volume is 1/0, and the residual is 0 times infinity. Ceres reported a
not-a-number Jacobian and wrote several hundred lines of solver output per failed solve.

VolumeFraction() is |V|/(|a||b||c|), rejected below 0.02 - about 1.1 degrees off flat, ten times below
the flattest real candidate observed and a thousand times above where float loses the sign. It is
enforced at the producer and at the two optimizer entry points. Note the existing sanity checks use
ABSOLUTE volume, which a 320 cubic-angstrom flat cell passes. The same reciprocal-volume division is
now guarded at the two remaining sites that share the pattern.

A SHORTLIST CONFINED TO ONE PLANE cannot close a cell, and the row it is missing is the plane normal.
That is detected from the scatter-matrix eigenvalue ratio - measured, degenerate clouds score 2e-5 to
3.3e-4 against 0.026 or more for every non-degenerate one, a factor of eighty - and one further
transform is spent with the same direction count inside a three-degree cap about the normal, so the
plan and buffers are untouched. More directions cannot substitute: at the exact true direction the
long axis ranks 1422 of 16384 by prominence while the shortlist cut is four times higher. Ranking, not
sampling, is the obstacle. A four-fold denser grid was measured and rejected - it reaches the same
answer to three decimal places and takes a run from 2.5 to 8 GB of device memory.

fft_min_unit_cell_A is reachable as --fft-min-unit-cell and is lowered automatically by -C, mirroring
how the maximum is already raised. The default of 10 is unchanged: a lower floor admits spurious
sub-cells on protein data, and over 73 protein runs the floor was never lowered while the sibling
maximum did fire twice, so the path is live and correctly inert.

Corpus of 93 datasets, both arms, one build: 72 bit-identical on report content and p.hkl checksum, 13
failing identically, and the count of working datasets rises by one. The volume guard fires on 58 of
93 and 47 of those stay bit-identical - it fires constantly and almost never changes an answer, which
is what it should do. Solver chatter falls from 919 lines across three datasets to none. The cap
fires on 4 of 93, none of them in the in-house or private arms.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Lc5JG6kJqZoCWaoZ43JGTW
2026-08-29 20:31:20 +02:00

244 lines
7.9 KiB
C++

// SPDX-FileCopyrightText: 2025 Filip Leonarski, Paul Scherrer Institute <filip.leonarski@psi.ch>
// SPDX-License-Identifier: GPL-3.0-only
#include "IndexingSettings.h"
#include "JFJochException.h"
#include "CUDAWrapper.h"
#include <cmath>
#define check_max(param, val, max) if ((val) > (max)) throw JFJochException(JFJochExceptionCategory::InputParameterAboveMax, param)
#define check_min(param, val, min) if ((val) < (min)) throw JFJochException(JFJochExceptionCategory::InputParameterBelowMin, param)
#define check_finite(param, val) if (!std::isfinite(val)) throw JFJochException(JFJochExceptionCategory::InputParameterInvalid, param)
IndexingSettings::IndexingSettings() {
if (get_gpu_count() > 0)
algorithm = IndexingAlgorithmEnum::FFBIDX;
else
algorithm = IndexingAlgorithmEnum::None;
}
IndexingSettings &IndexingSettings::ViableCellMinSpots(int64_t input) {
check_min("ViableCellMinSpots", input, 6);
viable_cell_min_spots = input;
return *this;
}
int64_t IndexingSettings::GetViableCellMinSpots() const {
return viable_cell_min_spots;
}
IndexingSettings &IndexingSettings::Algorithm(IndexingAlgorithmEnum input) {
switch (input) {
case IndexingAlgorithmEnum::Auto:
case IndexingAlgorithmEnum::FFBIDX:
case IndexingAlgorithmEnum::FFT:
case IndexingAlgorithmEnum::FFTW:
case IndexingAlgorithmEnum::None:
algorithm = input;
break;
default:
throw JFJochException(JFJochExceptionCategory::InputParameterInvalid,
"Invalid value for indexing algorithm enum parameter");
}
return *this;
}
// The accepted range, not the default (which stays 500 A - see IndexingSettings.h). The FFT can
// only recover a basis vector up to this length, so the ceiling is exactly the longest cell the
// indexer can ever find; at 500 it excluded 1091 of the PDB's 206950 X-ray entries (0.53%) outright.
// 1200 A leaves 8. Nothing pays for the wider range: the histogram is sized from the VALUE in use,
// and only a caller that asks for more - a given cell that needs it, or the long-axis rescue - gets
// a longer transform.
IndexingSettings &IndexingSettings::FFT_MaxUnitCell_A(float input) {
check_finite("FFT indexing max unit cell (A)", input);
check_min("FFT indexing max unit cell (A)", input, 50);
check_max("FFT indexing max unit cell (A)", input, fft_max_unit_cell_limit_A);
fft_max_unit_cell_A = input;
return *this;
}
IndexingSettings &IndexingSettings::FFT_MinUnitCell_A(float input) {
check_finite("FFT indexing min unit cell (A)", input);
check_min("FFT indexing min unit cell (A)", input, fft_min_unit_cell_limit_A);
check_max("FFT indexing min unit cell (A)", input, 40);
fft_min_unit_cell_A = input;
return *this;
}
IndexingSettings & IndexingSettings::FFT_MaxAngle_deg(float input) {
check_finite("FFT indexing max angle (deg)", input);
check_min("FFT indexing max angle (deg)", input, 0);
check_max("FFT indexing max angle (deg)", input, 180);
fft_max_angle_deg = input;
return *this;
}
IndexingSettings & IndexingSettings::FFT_MinAngle_deg(float input) {
check_finite("FFT indexing min angle (deg)", input);
check_min("FFT indexing min angle (deg)", input, 0);
check_max("FFT indexing min angle (deg)", input, 180);
fft_min_angle_deg = input;
return *this;
}
float IndexingSettings::GetFFT_MinAngle_deg() const {
return fft_min_angle_deg;
}
float IndexingSettings::GetFFT_MaxAngle_deg() const {
return fft_max_angle_deg;
}
IndexingSettings &IndexingSettings::FFT_NumVectors(int64_t input) {
check_min("FFT indexing number of search vectors", input, 128);
fft_num_vectors = input;
return *this;
}
IndexingSettings &IndexingSettings::FFT_HighResolution_A(float input) {
check_finite("FFT indexing high resolution (A)", input);
check_min("FFT indexing high resolution (A)", input, 0.5);
check_max("FFT indexing high resolution (A)", input, 6.0);
fft_high_resolution_A = input;
return *this;
}
IndexingAlgorithmEnum IndexingSettings::GetAlgorithm() const {
return algorithm;
}
float IndexingSettings::GetFFT_MaxUnitCell_A() const {
return fft_max_unit_cell_A;
}
float IndexingSettings::GetFFT_MinUnitCell_A() const {
return fft_min_unit_cell_A;
}
int64_t IndexingSettings::GetFFT_NumVectors() const {
return fft_num_vectors;
}
float IndexingSettings::GetFFT_HighResolution_A() const {
return fft_high_resolution_A;
}
IndexingSettings &IndexingSettings::Tolerance(float input) {
check_min("Indexing tolerance", input, 0.0);
check_max("Indexing tolerance", input, 0.5);
indexing_tolerance = input;
return *this;
}
float IndexingSettings::GetTolerance() const {
return indexing_tolerance;
}
int64_t IndexingSettings::GetIndexingThreads() const {
return indexing_threads;
}
IndexingSettings &IndexingSettings::IndexingThreads(int64_t input) {
check_min("Indexing thread count", input, 1);
check_max("Indexing thread count", input, 64);
indexing_threads = input;
return *this;
}
int64_t IndexingSettings::GetRefineThreads() const {
return refine_threads;
}
IndexingSettings &IndexingSettings::RefineThreads(int64_t input) {
check_min("Candidate-cell refinement thread count", input, 1);
check_max("Candidate-cell refinement thread count", input, MAX_REFINE_THREADS);
refine_threads = input;
return *this;
}
IndexingSettings &IndexingSettings::UnitCellDistTolerance(float input) {
check_min("Relative unit cell distance tolerance vs. reference", input, 0.0001);
check_max("Relative unit cell distance tolerance vs. reference", input, 0.2001);
unit_cell_dist_tolerance_vs_reference = input;
return *this;
}
float IndexingSettings::GetUnitCellDistTolerance() const {
return unit_cell_dist_tolerance_vs_reference;
}
float IndexingSettings::GetUnitCellAngleTolerance_deg() const {
return unit_cell_angle_tolerance_deg;
}
GeomRefinementAlgorithmEnum IndexingSettings::GetGeomRefinementAlgorithm() const {
return refinement;
}
IndexingSettings &IndexingSettings::GeomRefinementAlgorithm(GeomRefinementAlgorithmEnum input) {
refinement = input;
return *this;
}
IndexingSettings & IndexingSettings::IndexIceRings(bool input) {
index_ice_rings = input;
return *this;
}
IndexingSettings & IndexingSettings::RotationIndexing(bool input) {
enable_rotation_indexing = input;
return*this;
}
IndexingSettings & IndexingSettings::RotationIndexingMinAngularRange_deg(float input) {
check_finite("Rotation indexing minimum angular range (deg.)", input);
check_min("Rotation indexing minimum angular range (deg.)", input, 1.0);
rotation_indexing_min_angular_range_deg = input;
return *this;
}
IndexingSettings & IndexingSettings::RotationIndexingAngularStride_deg(float input) {
check_finite("Rotation indexing angular stride (deg.)", input);
check_min("Rotation indexing angular stride (deg.)", input, 0.0);
rotation_indexing_angular_stride_deg = input;
return *this;
}
bool IndexingSettings::GetRotationIndexing() const {
return enable_rotation_indexing;
}
float IndexingSettings::GetRotationIndexingMinAngularRange_deg() const {
return rotation_indexing_min_angular_range_deg;
}
float IndexingSettings::GetRotationIndexingAngularStride_deg() const {
return rotation_indexing_angular_stride_deg;
}
bool IndexingSettings::GetIndexIceRings() const {
return index_ice_rings;
}
bool IndexingSettings::GetBlockingBehavior() const {
return blocking_behavior;
}
IndexingSettings &IndexingSettings::BlockingBehavior(bool input) {
blocking_behavior = input;
return *this;
}
int64_t IndexingSettings::GetMaxExtraLattices() const {
return max_extra_lattices;
}
IndexingSettings &IndexingSettings::MaxExtraLattices(int64_t input) {
check_min("Max extra lattices", input, 0);
check_max("Max extra lattices", input, 10);
max_extra_lattices = input;
return *this;
}