Files
Jungfraujoch/reader/JFJochHDF5Reader.h
T
leonarski_fandClaude Opus 4.8 0dfaf0a58a
Build Packages / build:windows:nocuda (push) Successful in 15m33s
Build Packages / build:windows:cuda (push) Successful in 17m48s
Build Packages / build:viewer-tgz:cpu (push) Successful in 6m23s
Build Packages / build:viewer-tgz:cuda (push) Successful in 6m53s
Build Packages / build:rpm (ubuntu2204_nocuda) (push) Successful in 10m12s
Build Packages / build:rpm (rocky8_nocuda) (push) Successful in 10m35s
Build Packages / build:rpm (rocky9_nocuda) (push) Successful in 10m51s
Build Packages / build:rpm (ubuntu2404_nocuda) (push) Successful in 8m47s
Build Packages / build:rpm (rocky8_sls9) (push) Successful in 9m30s
Build Packages / build:rpm (rocky8) (push) Successful in 10m18s
Build Packages / build:rpm (rocky9_sls9) (push) Successful in 11m5s
Build Packages / build:rpm (rocky9) (push) Successful in 11m5s
Build Packages / build:rpm (ubuntu2204) (push) Successful in 10m40s
Build Packages / build:rpm (ubuntu2404) (push) Successful in 11m14s
Build Packages / Generate python client (push) Successful in 15s
Build Packages / Build documentation (push) Successful in 50s
Build Packages / Create release (push) Skipped
Build Packages / XDS test (durin plugin) (push) Successful in 7m13s
Build Packages / XDS test (JFJoch plugin) (push) Successful in 7m27s
Build Packages / XDS test (neggia plugin) (push) Successful in 6m46s
Build Packages / DIALS test (push) Successful in 10m59s
Build Packages / Unit tests (push) Successful in 1h50m3s
Build Packages / Unit tests (pull_request) Successful in 1h31m40s
Build Packages / build:windows:cuda (pull_request) Successful in 12m14s
Build Packages / build:viewer-tgz:cpu (pull_request) Successful in 6m16s
Build Packages / build:viewer-tgz:cuda (pull_request) Successful in 6m47s
Build Packages / build:rpm (rocky8_nocuda) (pull_request) Successful in 9m25s
Build Packages / build:rpm (rocky9_nocuda) (pull_request) Successful in 10m13s
Build Packages / build:rpm (ubuntu2204_nocuda) (pull_request) Successful in 8m8s
Build Packages / build:rpm (ubuntu2404_nocuda) (pull_request) Successful in 8m36s
Build Packages / build:rpm (rocky8_sls9) (pull_request) Successful in 10m10s
Build Packages / build:rpm (rocky9_sls9) (pull_request) Successful in 10m54s
Build Packages / build:rpm (rocky8) (pull_request) Successful in 9m56s
Build Packages / build:rpm (rocky9) (pull_request) Successful in 10m53s
Build Packages / build:rpm (ubuntu2204) (pull_request) Successful in 9m46s
Build Packages / build:rpm (ubuntu2404) (pull_request) Successful in 10m21s
Build Packages / DIALS test (pull_request) Successful in 12m15s
Build Packages / XDS test (durin plugin) (pull_request) Successful in 7m10s
Build Packages / XDS test (JFJoch plugin) (pull_request) Successful in 7m40s
Build Packages / XDS test (neggia plugin) (pull_request) Successful in 7m1s
Build Packages / Generate python client (pull_request) Successful in 25s
Build Packages / Build documentation (pull_request) Successful in 49s
Build Packages / Create release (pull_request) Skipped
Build Packages / build:windows:nocuda (pull_request) Successful in 16m1s
rugnux: don't reuse absent spots on plain DECTRIS datasets
reuse_rotation_spots defaults on, so the two-pass first phase read stored spots
from /entry/MX. A standard DECTRIS dataset has no spot-finding results, so every
frame came back with zero spots and indexing failed ("Two-pass rotation indexing
failed") instead of falling back to finding spots.

Add HasStoredSpots() to the reader (HDF5MetadataSource::HasSpots): spots exist if
/entry/MX/nPeaks is present in the master (integrated _process.h5) or the per-image
data file (VDS/legacy) - the same master-first-then-source path ReadSpots uses.
Rugnux reuses stored spots only when they exist, otherwise it runs spot finding
(and logs it); --redo-rotation-spots already forced finding.

Verified: a true no-/entry/MX rotation dataset fails on the old code and indexes
(P21) on the new; all jungfraujoch files (spots in master or in data files) still
reuse unchanged.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-11 22:56:28 +02:00

74 lines
3.0 KiB
C++

// SPDX-FileCopyrightText: 2024 Filip Leonarski, Paul Scherrer Institute <filip.leonarski@psi.ch>
// SPDX-License-Identifier: GPL-3.0-only
#pragma once
#include <map>
#include <memory>
#include <optional>
#include <string>
#include <vector>
#include "JFJochReader.h"
#include "JFJochReaderSpots.h"
#include "HDF5ImageSource.h"
#include "HDF5MetadataSource.h"
#include "../writer/HDF5Objects.h"
#include "../image_analysis/IntegrationOutcome.h"
// Composes one shared raw-image source with one or more metadata sources ("snapshots") over the
// same images: the original _master.h5 plus optional reprocessing _process.h5 results. The active
// snapshot supplies the dataset and per-image metadata; the image source always supplies pixels,
// so switching snapshots never reloads image data.
class JFJochHDF5Reader : public JFJochReader {
HDF5ImageSource image_source_;
std::map<std::string, std::shared_ptr<HDF5MetadataSource> > snapshots_;
std::shared_ptr<HDF5MetadataSource> active_metadata_;
std::string active_snapshot_;
size_t number_of_images = 0;
bool LoadImage_i(std::shared_ptr<JFJochReaderDataset> &dataset,
DataMessage &message,
std::vector<uint8_t> &buffer,
int64_t image_number,
bool update_dataset) override;
HDF5ImageLocator::Location GetImageLocation(int64_t image_number) const;
public:
~JFJochHDF5Reader() override = default;
void ReadFile(const std::string &filename);
uint64_t GetNumberOfImages() const override;
void Close() override;
std::vector<HDF5DataSourceMessage> GetHDF5DataSource(
uint64_t first_image = 0,
std::optional<uint64_t> image_count = {}
) const;
std::vector<IntegrationOutcome> ReadReflections(size_t start_image = 0, std::optional<size_t> end_image = {}) const;
std::vector<SpotToSave> ReadSpots(int64_t image) const override;
// True if the loaded file stores spot-finding results; false for a plain DECTRIS dataset (no
// /entry/MX), so callers can find spots instead of reusing absent ones.
[[nodiscard]] bool HasStoredSpots() const;
CompressedImage ReadCalibration(std::vector<uint8_t> &tmp, const std::string &name) const;
std::shared_ptr<JFJochReaderRawImage> GetRawImage(int64_t image_number) override;
// Metadata snapshots over the same images. The original file is registered as "Original" on
// ReadFile and is the initial active snapshot; reprocessing results can be added later.
void RegisterSnapshot(const std::string &name, const std::string &master_path);
void RemoveSnapshot(const std::string &name); // "Original" cannot be removed
void SetActiveSnapshot(const std::string &name);
std::vector<std::string> SnapshotNames() const;
std::string ActiveSnapshot() const;
// All snapshot datasets (name -> dataset), for overlaying every run's plots at once.
std::vector<std::pair<std::string, std::shared_ptr<const JFJochReaderDataset>>> AllSnapshotDatasets() const;
};