Files
Jungfraujoch/image_analysis/spot_finding/StrongPixelSet.cpp
T
leonarski_fandClaude Opus 5 6081b6bc43 docs: credit the L test, FFT indexing, TORO, Niggli, peakfinder8 and SparseCCL
Six methods the pages name or describe carried no citation: Padilla & Yeates
(the L test), Steller, Bolotovsky & Rossmann (the projection/FFT autoindexing
MOSFLM implements), TORO (what ffbidx implements), Krivy & Gruber and the
ITA lattice-character table (the reduction and Bravais assignment), Cheetah's
peakfinder8 (the per-ring background statistics of the adaptive finder) and
Hennequin et al.'s SparseCCL (already credited to traccc, now also to its
authors). Each gets its ACKNOWLEDGEMENT.md paragraph, a References entry in
CPU_DATA_ANALYSIS.md, and a one-line credit at the algorithm. The
Sheriff & Hendrickson / Popov & Bourenkov entry is re-scoped so each claim
sits on the paper that supports it - P&B 2003 is titled, and credited for the
sigma-aware anisotropy estimation its statistic modelling contains, not for
the tensor and its constraints. All DOIs verified against the publishers;
the SparseCCL DOI resolves to IEEE document 9049184 (IEEE blocks content
scraping, so verified by the resolved document id plus two independent
sources).

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EFEJG6WBQv8th4UJFNe53N
2026-09-02 09:18:36 +02:00

184 lines
7.7 KiB
C++

// SPDX-FileCopyrightText: 2024 Filip Leonarski, Paul Scherrer Institute <filip.leonarski@psi.ch>
// SPDX-License-Identifier: GPL-3.0-only
// SparseCCL code taken from https://github.com/acts-project/traccc/blob/main/core/include/traccc/clusterization/detail/sparse_ccl.hpp
// (c) 2021-2022 CERN for the benefit of the ACTS project
// Mozilla Public License Version 2.0
// The algorithm: Hennequin, Couturier, Gligorov & Lacassagne (2019) DASIP 2019, 65-70 (SparseCCL)
//
// The union-find and the two-scan structure are theirs. How a pixel's earlier neighbours are FOUND
// is not: see sparseccl below.
#include <algorithm>
#include <bitset>
#include "StrongPixelSet.h"
StrongPixelSet::StrongPixelSet() : strong_pixel_count(0) {
pixels.reserve(max_strong_pixel_per_module);
}
void StrongPixelSet::AddStrongPixel(uint16_t col, uint16_t line, int32_t photons) {
pixels.push_back(strong_pixel{.col = col, .line = line, .counts = photons});
++strong_pixel_count;
}
uint32_t StrongPixelSet::find_root(uint32_t e) {
uint32_t r = e;
while (L[r] != r)
r = L[r];
return r;
}
uint32_t StrongPixelSet::make_union(uint32_t e1, uint32_t e2) {
uint32_t e;
if (e1 < e2) {
e = e1;
L[e2] = e;
} else {
e = e2;
L[e1] = e;
}
return e;
}
std::vector<DiffractionSpot> StrongPixelSet::sparseccl(const SpotFindingSettings &settings) {
L.resize(pixels.size());
unsigned int labels = 0;
// First scan: pixel association. The pixels arrive in raster order - line ascending, column
// ascending within a line - which upstream uses to walk a sliding window of the last two lines,
// testing every pixel in it for adjacency. That is quadratic in how many strong pixels a line
// pair holds: fine for the silicon-tracker hits it was written for, but a flooded detector line
// holds four thousand of them, and labelling a fully lit frame took 76 seconds.
//
// Since the columns ascend, the window need not be walked. A pixel's earlier 8-neighbours are
// exactly the one to its left and the at most three above it, so keep the previous line's range
// and a cursor into it that only ever moves forward - the same four neighbours the GPU extractor
// finds by binary search. Same edge set, same unions in the same order, therefore the same
// labels; the flooded frame now takes 0.16 s.
uint32_t line_begin = 0; // first pixel of the line being scanned
uint32_t prev_begin = 0, prev_end = 0; // the pixels of the line above it
uint32_t up = 0; // cursor into [prev_begin, prev_end)
for (uint32_t i = 0; i < pixels.size(); ++i) {
L[i] = i;
if (i > 0 && pixels[i].line != pixels[i - 1].line) {
// The line above is the previous one only if it really is the line above: a line with no
// strong pixel at all leaves nothing to join to.
prev_begin = (pixels[i].line == pixels[i - 1].line + 1) ? line_begin : i;
prev_end = i;
line_begin = i;
up = prev_begin;
}
uint32_t ai = i;
while (up < prev_end && pixels[up].col + 1 < pixels[i].col)
++up;
for (uint32_t j = up; j < prev_end && pixels[j].col <= pixels[i].col + 1; ++j)
ai = make_union(ai, find_root(j));
// The pixel to the left comes last, as it did when the window was walked in order.
if (i > line_begin && pixels[i - 1].col + 1 == pixels[i].col)
ai = make_union(ai, find_root(i - 1));
}
// second scan: transitive closure
for (uint32_t i = 0; i < L.size(); ++i) {
if (L[i] == i) {
L[i] = labels++;
} else {
L[i] = L[L[i]];
}
}
std::vector<DiffractionSpot> spots(labels);
// The bounding box travels with the accumulation rather than on DiffractionSpot: it is wanted
// only to judge the shape here, and carrying it further would leave a member that
// ConvertToImageCoordinates silently invalidates.
std::vector<uint16_t> min_col(labels, UINT16_MAX), max_col(labels, 0);
std::vector<uint16_t> min_line(labels, UINT16_MAX), max_line(labels, 0);
for (uint32_t i = 0; i < L.size(); i++) {
const uint32_t l = L[i];
spots[l].AddPixel(pixels[i].col, pixels[i].line, pixels[i].counts);
min_col[l] = std::min(min_col[l], pixels[i].col);
max_col[l] = std::max(max_col[l], pixels[i].col);
min_line[l] = std::min(min_line[l], pixels[i].line);
max_line[l] = std::max(max_line[l], pixels[i].line);
}
std::vector<DiffractionSpot> out;
for (uint32_t l = 0; l < labels; l++) {
if (spots[l].PixelCount() > settings.max_pix_per_spot)
continue;
const int64_t w = static_cast<int64_t>(max_col[l]) - min_col[l] + 1;
const int64_t h = static_cast<int64_t>(max_line[l]) - min_line[l] + 1;
if (SpotShapeAccepted(spots[l].PixelCount(), std::max(w, h)))
out.push_back(spots[l]);
}
return out;
}
void StrongPixelSet::FindComponentsImage(const SpotFindingSettings &settings, std::vector<DiffractionSpot> &spots) {
// No StrongPixelLimit test here: the caller knows how big the image is and has already applied it.
// Size and shape are applied by sparseccl.
for (const auto &spot: sparseccl(settings))
spots.push_back(spot);
}
void StrongPixelSet::FindSpots(const DiffractionExperiment &experiment, const SpotFindingSettings &settings,
std::vector<DiffractionSpot> &spots, uint16_t module_number) {
// Per module, so the bar is the module's own - and ReadFPGAOutput has already refused anything
// past max_strong_pixel_per_module, far below it.
if (!pixels.empty() && (strong_pixel_count < StrongPixelLimit(RAW_MODULE_SIZE))) {
for (const auto &spot: sparseccl(settings)) {
if (spot.PixelCount() >= settings.min_pix_per_spot.value_or(2)) {
auto s = spot;
s.ConvertToImageCoordinates(experiment, module_number);
spots.push_back(s);
}
}
}
}
void StrongPixelSet::ReadFPGAOutput(const DiffractionExperiment & experiment,
const DeviceOutput &output) {
// Too many strong pixels will kill performance in data processing, so protection is needed
// Also if there are no strong pixels, there is no point in looking for them
if ((output.spot_finding_result.strong_pixel_count == 0) ||
(output.spot_finding_result.strong_pixel_count > max_strong_pixel_per_module)) {
// If max strong pixel per module condition kicks-in, still report correct strong pixel count
strong_pixel_count = output.spot_finding_result.strong_pixel_count;
return;
}
auto pixel_depth = experiment.GetByteDepthImage();
auto out_ptr = (uint32_t *) output.spot_finding_result.strong_pixel;
for (int i = 0; i < RAW_MODULE_SIZE / (8 * sizeof(out_ptr[0])); i++) {
size_t npixel = i * 8 * sizeof(out_ptr[0]);
size_t line = npixel / RAW_MODULE_COLS;
if (out_ptr[i] != 0) {
std::bitset<32> bitset(out_ptr[i]);
for (int j = 0; j < 32; j++) {
if (bitset.test(j)) {
size_t col = (npixel | j) % RAW_MODULE_COLS;
if (pixel_depth == 2)
AddStrongPixel(col, line, output.pixels[npixel | j]);
else if (pixel_depth == 1)
AddStrongPixel(col, line, ((int8_t *)output.pixels)[npixel | j]);
else if (pixel_depth == 4)
AddStrongPixel(col, line, ((int32_t *)output.pixels)[npixel | j]);
}
}
}
}
}
uint32_t StrongPixelSet::GetStrongPixelCount() const {
return strong_pixel_count;
}