Files
Jungfraujoch/viewer/JFJochImageReadingWorker.h
T
leonarski_fandClaude Opus 5 2ab8c55dfa rugnux and the viewer read SMV and gzipped miniCBF
Two more of the formats deposited data actually arrives in, found by processing a
corpus of it: every PETRA III EMBL set is .cbf.gz, and NSRRC and the whole ADSC
Quantum era are SMV. Both were previously "no native input".

SMV is an ASCII "KEY=value;" block between braces, then the pixels - no container,
no compression, nothing to decode by offset - so reader/SMV.{h,cpp} and
JFJochSMVReader are a smaller job than the marCCD pair they sit beside, and need no
new dependency at all. Two things the format does not give us, both said out loud
rather than papered over:

* It states no saturation value, so overloads are judged on the 16-bit container
  alone. That can only fail to call a pixel saturated, never condemn a good one,
  but a CCD at the top of its range does saturate, so the reader warns once.
* Its beam centre is in MILLIMETRES and which of X/Y is the fast direction is a
  convention rather than a rule. Measured on one ALS ADSC sweep the file's value is
  TRANSPOSED: as stated it indexes 2/60 frames, and the run's own beam-centre
  measurement (which adopts the right one automatically) indexes 60/60. Swapping it
  here would fit that writer and might break another, so the header is read as the
  format defines it and the measurement stays the arbiter. Revisit with a second
  vendor's SMV in hand.

.cbf.gz needed only Slurp() in MiniCBF.cpp, through which every read already passes:
it sniffs the two-byte gzip magic - not the file name - and takes a zlib path when it
is there, leaving the plain path free of zlib's buffer copy. zlib-ng is already in the
build, so this is a link line, not a dependency. The sweep template grew a suffix,
because ".cbf" and ".cbf.gz" are separate sweeps and std::filesystem cannot split the
double extension on its own.

The viewer's single cbf_reader becomes three, dispatched by CanRead() in the same
order as rugnux. Dispatch is by CONTENT in both: ".img" is used by miniCBF, marCCD
AND SMV depending on the writer, and a PDB detector label has now been wrong about
the format four times, so an extension decides nothing.

Measured, de novo, no flags: 9fcg (1800 gzipped frames) gives P4 and a cell 0.06%
from the deposited one at 1.37 A against a deposited 1.54; 6oel (ADSC SMV) gives
F4132 - 96 operations, the most a protein space group can have - and a cell 0.05%
out, 100% indexed. Tests cover both formats and the transposed-beam-centre case with
fixtures written byte for byte, so they need no external data.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-09-16 22:35:05 +02:00

270 lines
12 KiB
C++

// SPDX-FileCopyrightText: 2025 Filip Leonarski, Paul Scherrer Institute <filip.leonarski@psi.ch>
// SPDX-License-Identifier: GPL-3.0-only
#pragma once
#include <QObject>
#include <QString>
#include <QVector>
#include <QRect>
#include <QMutex>
#include <QTimer>
#include <QElapsedTimer>
#include "../reader/JFJochHDF5Reader.h"
#include "../reader/JFJochCBFReader.h"
#include "../reader/JFJochMarCCDReader.h"
#include "../reader/JFJochSMVReader.h"
#include "../common/Logger.h"
#include "JFJochHttpReader.h"
#include "../image_analysis/MXAnalysisWithoutFPGA.h"
#include "../common/BraggIntegrationSettings.h"
#include "../common/ScalingSettings.h"
#include "../image_analysis/bragg_prediction/BraggPrediction.h"
#include "../image_analysis/LoadFCalcFromMtz.h" // ReferenceMtzData + LoadReferenceMtz
#include "SimpleImage.h"
#include "ReferenceMtzInfo.h"
#include "../common/MovingAverage.h"
Q_DECLARE_METATYPE(std::shared_ptr<const JFJochReaderDataset>)
Q_DECLARE_METATYPE(std::shared_ptr<const JFJochReaderImage>)
Q_DECLARE_METATYPE(DiffractionExperiment)
Q_DECLARE_METATYPE(SpotFindingSettings)
Q_DECLARE_METATYPE(IndexingSettings)
Q_DECLARE_METATYPE(AzimuthalIntegrationSettings)
Q_DECLARE_METATYPE(BraggIntegrationSettings)
Q_DECLARE_METATYPE(ScalingSettings)
Q_DECLARE_METATYPE(UnitCell)
Q_DECLARE_METATYPE(std::shared_ptr<const SimpleImage>)
Q_DECLARE_METATYPE(BrokerStatus)
Q_DECLARE_METATYPE(ROIDefinition)
// Everything a reprocessing job needs, captured from the worker's current state in one locked read.
struct ReprocessingInputs {
bool valid = false;
QString file;
DiffractionExperiment experiment;
PixelMask pixel_mask;
SpotFindingSettings spot_finding;
std::vector<MergedReflection> reference_data; // empty unless a reference MTZ is loaded
// The rotation axis the file was opened with, before the settings panel had a say. `experiment`
// carries the panel's, which may have cleared it; this is what a fresh `rugnux` run would see.
std::optional<GoniometerAxis> file_goniometer;
};
#include "RunData.h"
class JFJochImageReadingWorker : public QObject {
Q_OBJECT
public:
// HTTPSync: follow latest image + dataset. HTTPSyncDataset: follow dataset/plots/image count
// but keep the displayed image frozen (entered by manually selecting an image while following).
enum class AutoloadMode {HTTPSync, HTTPSyncDataset, Movie, None};
Q_ENUM(AutoloadMode)
private:
mutable QMutex m;
bool http_mode = false;
AutoloadMode autoload_mode = AutoloadMode::None;
// A stored file is read by one of these, whichever its format needs; file_reader points at the
// one in use. The HDF5-only extras - calibration images and reprocessing snapshots - always go
// through hdf5_reader, and a raw image sweep simply has none of them, so raw_mode covers all
// three of the raw formats rather than CBF alone.
JFJochHDF5Reader hdf5_reader;
JFJochCBFReader cbf_reader;
JFJochMarCCDReader marccd_reader;
JFJochSMVReader smv_reader;
JFJochReader *file_reader = &hdf5_reader;
bool cbf_mode = false; // "a raw sweep is open", whichever of the three formats it is
JFJochHttpReader http_reader;
QString current_file;
DiffractionExperiment curr_experiment;
// Once the user edits ROIs they override whatever the file carried, for this and
// every subsequently loaded image, until a new file is opened.
std::optional<ROIDefinition> roi_override_;
// The rotation axis of the open file, captured before the settings panel can change it — see
// ReprocessingInputs::file_goniometer.
std::optional<GoniometerAxis> file_goniometer_;
std::map<std::string, QString> run_labels_; // snapshot id -> editable display label
IndexingSettings indexing_settings;
AzimuthalIntegrationSettings azint_settings;
BraggIntegrationSettings bragg_settings;
ScalingSettings scaling_settings;
// Reference reflections (from a reference MTZ), kept independent of the loaded dataset - they
// survive file switches and feed reference-based scaling / CCref reprocessing jobs.
std::optional<ReferenceMtzData> reference_;
std::unique_ptr<IndexerThreadPool> indexing;
std::shared_ptr<JFJochReaderImage> current_image_ptr;
std::unique_ptr<AzimuthalIntegrationMapping> azint_mapping;
std::unique_ptr<MXAnalysisWithoutFPGA> image_analysis;
std::unique_ptr<IndexAndRefine> index_and_refine;
// Azimuthal profile buffer of the most recently analyzed image (filled by Analyze).
std::unique_ptr<AzimuthalIntegrationProfile> last_profile_;
SpotFindingSettings spot_finding_settings;
std::optional<int64_t> current_image;
int64_t current_summation = 1;
int64_t total_images = 0;
int64_t jump_value = 1;
Logger logger{"jfjoch_viewer"};
bool auto_reanalyze = false;
QTimer *autoload_timer;
int autoload_interval = 500; // milliseconds
// Broker status polling (independent of image sync, runs whenever connected over HTTP)
QTimer *status_timer = nullptr;
int status_interval = 1000; // milliseconds
bool http_connected = false;
// Adaptive autoload interval based on recent load+analysis time
MovingAverage autoload_ms_ma{8}; // window size (tune as needed)
int autoload_interval_min_ms = 50; // 20 Hz is the top performance!
int autoload_interval_max_ms = 2000; // 0.5 Hz as bottom limit
float autoload_safety_factor = 2.0f;
// Backpressure: cap how many frames may be "in flight" to the GUI (emitted but not yet rendered
// and acked via ImageConsumed). The autoload timer won't produce another frame while the cap is
// reached, so a fast producer can't grow the queued-event backlog without bound.
int images_in_flight = 0;
int max_images_in_flight = 4;
// Same backpressure for the dataset stream (see EmitDatasetLoaded_i / DatasetConsumed): each
// queued datasetLoaded event pins a full dataset (mask + per-image plots), so cap how many may
// be in flight to the GUI. This also coalesces dataset-only follow (HTTPSyncDataset), which emits
// no image and so was never gated by images_in_flight - stale datasets are dropped, the next tick
// sends the latest. Without this the datasetLoaded backlog grew without bound (100 GB OOM).
int datasets_in_flight = 0;
int max_datasets_in_flight = 2;
// File open retry/back-off (GPFS via NFSv4 visibility lag)
struct PendingLoadRequest {
QString filename;
qint64 image_number = 0;
qint64 summation = 1;
};
QTimer *file_open_retry_timer = nullptr;
PendingLoadRequest pending_load;
bool file_open_retry_active = false;
bool file_open_retry_warned = false;
int file_open_retry_attempts = 0;
int file_open_retry_delay_ms = 100;
int file_open_retry_delay_max_ms = 10000;
QElapsedTimer file_open_retry_elapsed;
void ResetFileOpenRetry_i();
void ScheduleFileOpenRetry_i(const QString& reason);
void LoadFile_i(const QString &filename, qint64 image_number, qint64 summation, bool retry);
void LoadImage_i(int64_t image_number, int64_t summation);
void EmitImageLoaded_i(const std::shared_ptr<const JFJochReaderImage>& image);
void EmitDatasetLoaded_i(const std::shared_ptr<const JFJochReaderDataset>& dataset);
void RefreshDatasetOnly_i();
void SetHttpConnected_i(bool connected, const QString &addr);
void ReanalyzeImage_i();
void UpdateDataset_i(const std::optional<DiffractionExperiment>& experiment);
void UpdateAzint_i(const JFJochReaderDataset *dataset);
void UpdateUserMask_i(const std::vector<uint32_t> &mask);
void SetROIDefinition_i(const ROIDefinition &rois);
void ApplyROIOverrideToImage_i(); // rewrite current_image_ptr's dataset with roi_override_
void setAutoLoadMode_i(AutoloadMode mode);
void ActivateSnapshot_i(const QString &name);
void EmitRuns_i(); // emit runsChanged with every snapshot dataset + its label
void EmitReferenceInfo_i(); // emit referenceMtzChanged from reference_ + current data
signals:
void datasetLoaded(std::shared_ptr<const JFJochReaderDataset>);
void imageLoaded(std::shared_ptr<const JFJochReaderImage>);
void imageStatsUpdated(std::shared_ptr<const JFJochReaderImage>);
void imageNumberChanged(int64_t total_images, int64_t current_image);
void setRings(const QVector<float> &v);
void simpleImageLoaded(std::shared_ptr<const SimpleImage> image);
void autoloadChanged(AutoloadMode mode);
void fileLoadError(QString title, QString message);
void fileLoadRetryStatus(bool active, QString message);
void brokerStatusUpdated(BrokerStatus status);
void httpConnectionChanged(bool connected, QString addr);
void liveRateChanged(double hz);
void snapshotsChanged(QStringList names, QString active);
void runsChanged(QVector<RunData> runs, QString active_id);
void fileOpened(); // a new file/stream was loaded - listeners should reset per-file state
void referenceMtzChanged(ReferenceMtzInfo info); // a reference MTZ was (un)loaded - update the dock
public:
JFJochImageReadingWorker(const SpotFindingSettings &settings, const DiffractionExperiment& experiment, QObject *parent = nullptr);
~JFJochImageReadingWorker() override = default;
// Captures the current file + experiment + mask + spot-finding settings so a processing job
// uses exactly the same settings as interactive analysis. Thread-safe (locks the worker mutex).
ReprocessingInputs GetReprocessingInputs() const;
private slots:
void AutoLoadTimerExpired();
void StatusTimerExpired();
void FileOpenRetryTimerExpired();
public slots:
void LoadFile(const QString &filename, qint64 image_number, qint64 summation, bool retry);
void CloseFile();
void LoadImage(int64_t image_number, int64_t summation);
void UpdateDataset(const DiffractionExperiment& experiment);
// The calibrant as its ring q values (2*pi/d, 1/A) rather than a cell, so a standard whose rings
// are measured rather than enumerated - hexagonal ice - can be calibrated against too.
void FindCenter(QVector<float> ring_q, bool guess, bool refine_tilt);
void Analyze();
void UpdateSpotFindingSettings(const SpotFindingSettings &settings, const IndexingSettings &indexing, int64_t max_spots);
void ReanalyzeImages(bool input);
void UpdateAzintSettings(const AzimuthalIntegrationSettings& settings);
void UpdateBraggIntegrationSettings(BraggIntegrationSettings settings);
void UpdateScalingSettings(ScalingSettings settings);
// Load (column empty = auto-select) or clear a reference MTZ; kept independent of the dataset.
void SetReferenceMtz(QString path, QString column);
void ClearReferenceMtz();
void SetROIDefinition(const ROIDefinition &rois);
void DownloadROIsFromServer();
void UploadROIsToServer();
void MaskFromSelectedROI(QString name, bool add); // rasterise an ROI into the user mask
void SaveUserMaskTIFF(QString filename);
void LoadUserMaskTIFF(QString filename, bool replace);
void UploadUserMask();
void ClearUserMask();
void LoadCalibration(QString dataset);
void setAutoLoadMode(AutoloadMode mode);
void setAutoLoadJump(int64_t val);
// GUI acks that it has consumed (rendered) one frame, freeing an in-flight slot. Drives the
// autoload backpressure so the reader can't outrun the viewer (see images_in_flight).
void ImageConsumed();
// GUI ack that it has consumed (fanned out + rendered) one dataset, freeing an in-flight slot.
// Drives the datasetLoaded backpressure so the reader can't outrun the viewer's dataset drain.
void DatasetConsumed();
// Register a reprocessing result (_process.h5) as a metadata snapshot over the same images and
// make it the active dataset; SetActiveSnapshot switches between registered snapshots.
void RegisterProcessingSnapshot(QString id, QString label, QString master_path);
void SetActiveSnapshot(QString name);
void RenameRun(QString id, QString label); // change a run's display label (legend)
void RemoveRun(QString id); // drop a reprocessing snapshot (not "Original")
};