Build Packages / XDS test (JFJoch plugin) (push) Successful in 11m4s
Build Packages / Unit tests (push) Skipped
Build Packages / build:windows:nocuda (push) Successful in 17m46s
Build Packages / build:windows:cuda (push) Successful in 20m20s
Build Packages / build:viewer-tgz:cpu (push) Successful in 15m56s
Build Packages / build:viewer-tgz:cuda (push) Successful in 17m57s
Build Packages / build:rugnux-tgz (x86_64) (push) Successful in 14m10s
Build Packages / build:rugnux:windows (push) Successful in 11m12s
Build Packages / build:rugnux:aarch64 (cross) (push) Successful in 7m14s
Build Packages / build:rpm (rocky8_nocuda) (push) Successful in 22m13s
Build Packages / build:rpm (rocky9_nocuda) (push) Successful in 19m17s
Build Packages / build:rpm (ubuntu2204_nocuda) (push) Successful in 21m21s
Build Packages / build:rpm (ubuntu2404_nocuda) (push) Successful in 17m26s
Build Packages / build:rpm (rocky8_sls9) (push) Successful in 23m56s
Build Packages / build:rpm (rocky9_sls9) (push) Successful in 20m48s
Build Packages / build:rpm (rocky8) (push) Successful in 23m43s
Build Packages / build:rpm (rocky9) (push) Successful in 20m38s
Build Packages / build:rpm (ubuntu2204) (push) Successful in 24m57s
Build Packages / build:rpm (ubuntu2404) (push) Successful in 20m58s
Build Packages / XDS test (durin plugin) (push) Successful in 10m43s
Build Packages / Generate python client (push) Successful in 47s
Build Packages / Build documentation (push) Successful in 1m5s
Build Packages / Create release (push) Skipped
Build Packages / XDS test (neggia plugin) (push) Successful in 8m57s
Build Packages / DIALS test (push) Successful in 18m40s
* `rugnux --model` reports CC(model, data) - the correlation of the merged intensities with the placed, scaled model - by resolution shell, on the same shells as CC1/2, with the reflection count and a significance for each. * `rugnux --model` fits the model's scale, anisotropic B and bulk-solvent parameters on the working reflections only, so the R-free it reports is measured against a model no free reflection helped scale. * The bulk-solvent parameters of `rugnux --model` are searched over their physically meaningful range instead of being fitted without bounds, so a model is never scaled with a solvent term that has silently switched itself off. * The rigid-body placement of `rugnux --model` uses the same bounded bulk solvent as the reported fit, so a model is no longer placed against a target carrying a solvent term with no physical meaning. * `rugnux --model` puts the model into the data's own description of the lattice before placing it, so a model whose cell is written on other axes - I-centred where the run indexed C-centred, a different unique axis, a permuted orthorhombic cell - is placed rather than scored where it was read; `MODEL_CHANGE_OF_BASIS=` and `MODEL_SETTING_AS_READ=` report it when it happens. * The rugnux results report opens with a summary - `VERDICT=` (`OK`, `WARNINGS`, `UNUSABLE`, `FAILED`), `VERDICT_TEXT=`, `PATHOLOGY_FLAGS=` with one closed-vocabulary code per condition that warned, and the `WARNING:` lines, which used to close the file - and the sections after it are renumbered 1-5 with no gaps. * `rugnux --developer` writes the full results report - the pipeline-internal keys and the long explanations the default report now leaves out - and `--finalist-ledger` adds the evidence for every space group the search considered, not only the one it adopted. * The results report warns when the merged data carry no usable signal and when too little of reciprocal space was measured inside the fitted resolution, and omits `FITTED_RESOLUTION` where the CC1/2 curve it is fitted on never falls off. * rugnux detects translational pseudo-symmetry and reports it under the `PSEUDO_TRANSLATION` flag as `TNCS_DETECTED=` and the `TNCS_*` keys - a translation the merged data are exactly invariant under is reported as `UNDECLARED_LATTICE_TRANSLATION=` under `LATTICE_TRANSLATION` instead - and a detected pseudo-translation can no longer buy a false screw axis in the space-group search or hide a twin from the L-test (`L_TEST_VS_TNCS=`). * The space-group search determines glide planes from zonal systematic absences, so a non-Sohncke space group such as P 2_1/c or Pbca is named where the run previously stopped at its Sohncke subgroup; `SOHNCKE_SPACE_GROUP=` carries the best Sohncke group beside it on every run that searched, and a centre of symmetry is never claimed. * Where the cell metric carries more rotational symmetry than the Bravais class the indexer named, the extra rotations are put to the intensities and the space-group search is asked again on the metric's own cell - adopted only where the intensities confirm the higher symmetry - so a lattice that is nearly but not exactly hexagonal, or whose reduction landed in a sub-cell, still reaches its true point group. * Systematic-absence calls rest on the evidence rather than on counts: a screw axis whose absent class the data show extinct is no longer refused because a handful of reflections in it read as present, and `SPACE_GROUP_ALTERNATIVES=` no longer drops a candidate that differs only on a zone the sweep never measured. * A reference correlation measured on too few reflections is refused instead of scored zero, so a run given a reference MTZ is no longer reindexed on an operator that mapped almost everything outside the reference's coverage. * A frame counts as indexed from 6 spots on its lattice rather than 9, so a weakly diffracting crystal whose frames cannot carry 9 is no longer refused the lattice it fits; `--min-indexed-spots` overrides it. * `-C` accepts a known cell in any equivalent description - conventional or primitive, centred or not - instead of only the reduced primitive form, so a centred cell given the way it is published no longer makes the run report that it found no lattice. * Each reflection is corrected for the sensor's quantum efficiency at the angle it meets the detector (attenuation lengths from the NIST tables, which also fixes the spot-width parallax term on CdTe) and for the attenuation of the flight path between the sample and its pixel; `--flight-path air|helium|vacuum` declares the medium - default air, since no file states it - and the report says what was assumed and what it was worth. The unmerged MTZ records the factors in new `QE` and `FLIGHT` columns beside `LP`, so raw counts are `I / LP * QE * FLIGHT`, and `_process.h5` in new optional `qe` and `flight` datasets. * Rotation geometry post-refinement fits the crystal and the detector at once, against the observed spot positions and the observed rocking angles together, so the refined distance depends far less on how wrong the file's distance was. * A coarsely sliced sweep integrates correctly: partials are joined into one rocking event by angle rather than by frame count, so two crossings of the Ewald sphere are no longer summed into one full, and at 0.5 degrees per image or coarser the per-frame geometry refinement accepts a spot whose miss the exposure's own rotation accounts for. * `rugnux --mode scale` reports the detector tilt and direct beam of the geometry it re-scaled at, instead of zeros that read as a flat detector, and no longer warns that no image was indexed on a run whose lattice came from its input file. * Every rotation run that determined a space group and merged reports what the mounting cost: `SPINDLE_LOST_UNIQUE_FRACTION=` is the fraction (0-1) of unique reflections the mounting made unmeasurable under the measured point group, also written to the master as `/entry/MX/spindleLostUniqueFraction` and what the mounting warning fires on; `SPINDLE_SYMMETRY_AXIS_ANGLE_DEG=` / `SPINDLE_SYMMETRY_AXIS_ORDER=` describe the mounting in the `--developer` report. * Stills and grid scans carry a per-image `spindle_blind_fraction` - how much of a rotation sweep's blind cone this orientation would make unrecoverable, 0.5 and above calling for a second orientation - through the CBOR stream, HDF5 (`/entry/MX/spindleBlindFraction`), the plot and scan-result APIs, and the viewer and frontend plots; an absent value means the frame could not be assessed and is not a 0. * The results report's `REPORT_VERSION` is 7. Reviewed-on: #77 Co-authored-by: Filip Leonarski <filip.leonarski@psi.ch>
117 lines
7.4 KiB
C++
117 lines
7.4 KiB
C++
// SPDX-FileCopyrightText: 2026 Filip Leonarski, Paul Scherrer Institute <filip.leonarski@psi.ch>
|
|
// SPDX-License-Identifier: GPL-3.0-only
|
|
|
|
#pragma once
|
|
|
|
#include <cstddef>
|
|
#include <optional>
|
|
#include <vector>
|
|
|
|
#include "../../common/Coord.h"
|
|
#include "../../common/CrystalLattice.h"
|
|
|
|
// How much of a single sweep's blind cone this orientation makes unrecoverable.
|
|
//
|
|
// A sweep about the spindle never brings a reciprocal point closer than theta_max =
|
|
// asin(lambda / 2d) to the axis onto the Ewald sphere, so a double cone of half-angle theta_max
|
|
// is missing from every resolution shell whatever the crystal does. That loss is normally
|
|
// repaired by the point group, which maps the cone onto measured territory. It is not repaired
|
|
// when the operator's axis lies inside the cone, because then the cone maps onto itself - and a
|
|
// still cannot know the point group, but it can measure where the crystal's short lattice rows
|
|
// are, and a symmetry axis is always a lattice row, and usually among the short ones (over 107
|
|
// solved cells, 88% of symmetry axes fall inside the 2.5x length window below).
|
|
//
|
|
// Score = the fraction of the blind cone that a 2-fold about the worst plausible row direction
|
|
// carries back into the blind cone: two equal caps of angular radius theta_max whose centres are
|
|
// 2*beta apart. 0 means any operator about that direction moves the cone entirely off itself and
|
|
// one sweep loses nothing symmetry could have given; 1 means the whole cone is lost. Nothing about
|
|
// the goniometer enters, so the number describes the problem and leaves the remedy - a chi offset,
|
|
// a second sweep, accepting the loss - to the beamline.
|
|
//
|
|
// The score is a WORST-CASE BOUND under an assumption of no symmetry, not an estimate: a still
|
|
// cannot rule out that the nearest plausible row is a lone 2-fold, so it is scored as one. BOTH
|
|
// ends of the miss-angle range are that diad's bad case. A row ON the spindle maps the cone onto
|
|
// itself whatever its order; a row PERPENDICULAR to the spindle maps it onto the cone's opposite
|
|
// lobe - equally unmeasured, and a band rather than a cap, so the commoner of the two - but only
|
|
// for a LONE DIAD: an axis of order >= 3 there fully repairs the cone (measured unrepaired
|
|
// fraction 0.000 for orders 3, 4 and 6 against 1.000 for order 2), which a still cannot know.
|
|
// The safe zone is the middle, and the miss-angle is folded about 45 deg accordingly. On
|
|
// higher-symmetry crystals the bound is therefore deliberately pessimistic, and the cost model
|
|
// accepts that: at theta_max = 15 deg it engages, at the 0.5 trigger threshold, on roughly a
|
|
// quarter of harmless mountings (a single strong row's perpendicular band alone covers ~11% of
|
|
// orientation space), against a false negative that costs the dataset a hole no amount of sweep
|
|
// can fill.
|
|
|
|
// Fraction of a cap of angular radius theta that its own image under a 2-fold covers, as a function
|
|
// of x = (folded miss-angle) / theta_max; the caller does the folding. Exact in the flat limit.
|
|
// Checked against a Monte-Carlo of the true spherical overlap the folded score is within 0.006 up to
|
|
// theta_max = 20 deg and within 0.024 up to 45 deg, so the closed form is used as is. Only past
|
|
// 45 deg - which needs lambda > 1.41 * d_min, so a long-wavelength beamline - does the sphere's
|
|
// curvature start to tell, and there it UNDER-reports, by 0.05 at theta_max = 50 deg and 0.13 at
|
|
// 55 deg. There the score is a lower bound on the loss rather than an estimate of it.
|
|
float BlindConeSelfOverlap(float x);
|
|
|
|
// Below this many spots the row shortlist is no longer trustworthy: measured on the stills of
|
|
// 22 solved crystals - 22 independent mounts, however many frames each contributed - the fraction
|
|
// of severe orientations reported harmless falls from 0.22 at 30 spots to 0.05 at 60 and is flat
|
|
// above. Fewer spots means NO value - which automation must treat as "engage", the recoverable
|
|
// error - never a middling score.
|
|
constexpr size_t SPINDLE_MIN_SPOTS = 60;
|
|
|
|
// asin(lambda/2d) in degrees; 0 when either input is unusable. d_min_A should be the setup's
|
|
// GEOMETRIC resolution (DiffractionExperiment::GetDetectorMaxResolution_A), the upper bound on any
|
|
// sweep collected without moving the detector - see spindle_theta_max_deg in Indexer.h for why.
|
|
float SpindleThetaMax_deg(float wavelength_A, float d_min_A);
|
|
|
|
// The trigger the score exists for: beamline automation engaging a recovery protocol - a two-sweep
|
|
// collection, a goniometer reorientation - with no human in the loop. The stored and transported
|
|
// quantity stays the continuous score; these three states are the canonical reading of it, fixed
|
|
// by design with nothing for a beamline to tune:
|
|
//
|
|
// Engage score >= 0.5
|
|
// DontEngage score < 0.5
|
|
// CannotSay no score at all - too few spots, no shortlist, the consistency guard refused,
|
|
// the path never computed one. Automation MUST treat CannotSay as Engage: the error
|
|
// costs are asymmetric. A false negative is unrecoverable - the protocol does not
|
|
// fire, one sweep is collected, and the data are permanently short - while a false
|
|
// positive costs an extra wedge, minutes of beamtime.
|
|
//
|
|
// The 0.5 threshold is geometry, not tuning. The score is monotone in the folded miss-angle, so
|
|
// any threshold is a fold-angle gate; 0.5 gates at fold <= 0.4040 * theta_max. Engaging on any
|
|
// overlap at all (score > 0) would gate at fold < theta_max, whose perpendicular band alone spans
|
|
// sin(theta_max) of orientation space per row - 26% at theta_max = 15 deg - and unions over a
|
|
// frame's rows to well over half of all mountings, degenerating the trigger into "always". At 0.5
|
|
// the residual missed loss is bounded below half the cone.
|
|
enum class SpindleTrigger { Engage, DontEngage, CannotSay };
|
|
|
|
constexpr float SPINDLE_ENGAGE_THRESHOLD = 0.5f;
|
|
|
|
inline SpindleTrigger SpindleTriggerState(const std::optional<float> &score) {
|
|
if (!score.has_value())
|
|
return SpindleTrigger::CannotSay;
|
|
return *score >= SPINDLE_ENGAGE_THRESHOLD ? SpindleTrigger::Engage : SpindleTrigger::DontEngage;
|
|
}
|
|
|
|
struct SpindleSeverity {
|
|
float score = 0.0f; // [0,1]
|
|
float row_length_A = 0; // the row the score was taken on; 0 = a direction inferred from the
|
|
// normal of a row pair, whose own row length the frame cannot see
|
|
float miss_angle_deg = 0;
|
|
};
|
|
|
|
// rows/magnitudes: the FilterFFTResults shortlist and each entry's FFT peak prominence.
|
|
// Returns nothing when there is no shortlist to decide on.
|
|
std::optional<SpindleSeverity> SpindleBlindFraction(const std::vector<Coord> &rows,
|
|
const std::vector<float> &magnitudes,
|
|
const Coord &spindle,
|
|
float theta_max_deg);
|
|
|
|
// The same severity read off an indexed lattice instead of an FFT shortlist, for the paths that
|
|
// index without a row search (a known-cell indexer on the online stills path). The candidate rows
|
|
// are the lattice's shortest few distinct directions - as many as the FFT shortlist resolves in
|
|
// practice, so the bound is over comparable evidence on either path - with equal magnitudes: a
|
|
// lattice does not rank its rows, and all of them are equally real.
|
|
std::optional<SpindleSeverity> SpindleBlindFractionFromLattice(const CrystalLattice &lattice,
|
|
const Coord &spindle,
|
|
float theta_max_deg);
|