Files
Jungfraujoch/image_analysis/spot_finding/SpotExtractorGPU.h
T
leonarski_fandFilip Leonarski 19b135186d
Build Packages / Create release (push) Successful in 7s
Build Packages / build:portable:macos-arm64:nocuda (push) Successful in 4m56s
Build Packages / build:rugnux:linux-aarch64:cuda (push) Successful in 9m10s
Build Packages / build:portable:linux-x86_64:nocuda (push) Successful in 13m51s
Build Packages / build:portable:linux-x86_64:cuda (push) Successful in 16m56s
Build Packages / build:jfjoch:rocky8:nocuda (push) Successful in 20m59s
Build Packages / build:portable:windows-x86_64:nocuda (push) Successful in 21m25s
Build Packages / build:jfjoch:rocky9:nocuda (push) Successful in 21m17s
Build Packages / build:jfjoch:ubuntu2204:nocuda (push) Successful in 14m14s
Build Packages / HDF5 consumer tests (DIALS, XDS) (push) Successful in 25m59s
Build Packages / build:portable:windows-x86_64:cuda (push) Successful in 25m48s
Build Packages / build:jfjoch:ubuntu2404:nocuda (push) Successful in 15m52s
Build Packages / build:jfjoch:rocky8:cuda-sls9 (push) Successful in 19m33s
Build Packages / Generate python client (push) Successful in 29s
Build Packages / Build documentation (push) Successful in 1m19s
Build Packages / build:jfjoch:ubuntu2204:cuda (push) Successful in 20m49s
Build Packages / build:jfjoch:rocky9:cuda-sls9 (push) Successful in 25m31s
Build Packages / build:jfjoch:rocky8:cuda (push) Successful in 25m24s
Build Packages / build:jfjoch:rocky9:cuda (push) Successful in 26m5s
Build Packages / build:jfjoch:ubuntu2404:cuda (push) Successful in 22m19s
Build Packages / Unit tests (push) Failing after 2h28m24s
Build Packages / Validation Battery (push) Successful in 40m33s
v1.0.0-rc.175 (#85)
* Rugnux: Processes a collection live while jfjoch_broker writes it (`rugnux <master.h5> <broker URL>`).
* Rugnux: Processing starts on the first images and confirms its choices once all are in, so analysis can begin during collection.
* Rugnux: Faster processing, especially on servers with several GPUs and CPU sockets and on computers without a GPU (`--no-gpu`, macOS).
* Rugnux: Uses much less GPU memory, so large data sets stay on the GPU of smaller cards, and a data set too large for the card is processed on the CPU instead.
* Rugnux: On macOS, Bragg integration runs on the Apple GPU.
* Rugnux: Better handling of twinning and pseudo-symmetry, with the twin hypothesis written as `<prefix>_twin_<SG>.mtz`, and a wrong `--model` no longer confirms the data or decides the hand.
* Rugnux: `--model` accepts predicted (AlphaFold) models and falls back to molecular replacement when the model is not placed as a rigid body (experimental `--mr` forces it), settling space group, hand and twinning and writing a different answer as `<prefix>_mr.mtz`.
* Rugnux: Molecular replacement is faster and settles the space group in more cases with several copies in the asymmetric unit.
* Rugnux: Deposition-ready mmCIF, a richer report, and numbered steps on the terminal with the full log in `<prefix>_log.txt`; `_P1.mtz`, `--estimate-beam-center` and `--beam-center-search` are removed.
* Rugnux: The beam-stop shadow is found correctly on tilted detectors.
* Rugnux: Stills files that record a stationary goniometer axis get the default stills geometry refinement.
* jfjoch_viewer: "Analyze dataset" uses the same defaults as a bare `rugnux <file>`, and shows the results of processed CBF, marCCD and SMV sweeps.
* jfjoch_viewer: The Files panel refreshes on F5 and every few seconds, and the plot type and other selections stay put during live collection.
* jfjoch_writer: Memory stays bounded and old data files are closed efficiently on long runs, any failure ends the run in an error state the broker is told about, and the master file appears only after its data files; the ZeroMQ pusher logs when a stalled writer makes it drop images.
* Fixes: The TCP image pusher no longer blocks the broker's receiver, GPU out-of-memory failures stop with a clear message, and the XDS plugin masks module and chip edges.

---------

Co-authored-by: Filip Leonarski <jungfrau@filips-mac-mini.home>
Reviewed-on: #85
Co-authored-by: Filip Leonarski <filip.leonarski@psi.ch>
2026-10-16 15:34:43 +02:00

104 lines
5.2 KiB
C++

// SPDX-FileCopyrightText: 2026 Filip Leonarski, Paul Scherrer Institute <filip.leonarski@psi.ch>
// SPDX-License-Identifier: GPL-3.0-only
#pragma once
// Device-side connected-component extraction for the GPU spot finders.
//
// The GPU finders flag strong pixels into a packed bit buffer ON THE DEVICE. Reading spots out of it
// used to mean copying that whole buffer back (2.26 MB per frame at 18 MP) and scanning it bit by bit
// on the host. This does the whole extraction where the data already is, so nothing about the image
// comes back - only the finished spot list, a few hundred entries.
//
// The algorithm is the sparse formulation the ACTS/traccc project settled on for the same problem
// (sparse silicon-detector hits): the strong pixels are compacted into a list that is sorted by flat
// index, each pixel finds its at most FOUR backward 8-neighbours by binary search in that list, and
// the resulting graph is labelled with a lock-free union-find. A dense image-wide labelling
// (Playne-equivalence, BUF/BKE, nppiLabelMarkers, cv::cuda::connectedComponents) would label 18
// million pixels to find five hundred.
//
// It reproduces the host StrongPixelSet::sparseccl EXACTLY, not just equivalently:
// * both make a component's root its lowest list index, so both find the same roots;
// * labels are handed out by a prefix sum over the roots in ascending order, which is the order the
// host's second scan hands them out in, so the SPOT ORDER is identical;
// * the centroid sums are accumulated per component in integers, term for term as
// DiffractionSpot::AddPixel does them, so there is no rounding for the two compilers to disagree
// about, and the order the device adds them in changes nothing.
// tests/SpotExtractorGPUParityTest.cpp holds the two to each other on realistic, occupancy-swept and
// pathological frames, and checks that repeating a frame gives byte-identical output.
#include <cstdint>
#include <memory>
#include <vector>
#include "../../common/DiffractionSpot.h"
#include "../indexing/CUDAMemHelpers.h"
#include "SpotFindingSettings.h"
// Per-component sums, in exactly the form DiffractionSpot holds them: x and y are sum(col*photons)
// and sum(line*photons), not a centroid.
struct SpotExtractorGPUSpot {
int64_t x;
int64_t y;
int64_t photons;
int64_t max_photons;
int32_t pixel_count;
// Longer side of the component's bounding box, for SpotShapeAccepted. It fits in what used to be
// padding, so carrying it costs nothing.
int32_t bbox_side;
};
class SpotExtractorGPU {
std::shared_ptr<CudaStream> stream;
const int32_t width;
const size_t nwords;
// Strong pixels this engine's buffers hold, and above which the extraction gives up on the frame -
// StrongPixelLimit, so it follows the detector rather than standing at a constant. 116 bytes of
// device memory apiece, 32 MB on an 18-megapixel detector.
const uint32_t max_strong;
// Spots copied back together with their count in one transfer. A frame with more than this many
// surviving spots - far past anything indexable - simply takes a second copy.
static constexpr uint32_t SPOT_PREFIX = 4096;
int compact_blocks = 0;
CudaDevicePtr<uint32_t> gpu_res_mask; // packed, bit set = pixel excluded
CudaDevicePtr<uint32_t> gpu_block_count;
CudaDevicePtr<uint32_t> gpu_block_offset;
CudaDevicePtr<uint32_t> gpu_nstrong;
CudaDevicePtr<uint32_t> gpu_index; // strong pixels, sorted by flat index
CudaDevicePtr<int32_t> gpu_value;
CudaDevicePtr<uint32_t> gpu_parent; // union-find parent
CudaDevicePtr<uint32_t> gpu_root;
CudaDevicePtr<uint32_t> gpu_label; // compact label, indexed by root
CudaDevicePtr<int4> gpu_box; // bounding box per component
CudaDevicePtr<uint32_t> gpu_nlabel; // components found
CudaDevicePtr<SpotExtractorGPUSpot> gpu_spot;
CudaDevicePtr<SpotExtractorGPUSpot> gpu_spot_out;
CudaDevicePtr<uint32_t> gpu_nspot;
CudaHostPtr<uint32_t> host_nstrong;
CudaHostPtr<uint32_t> host_nspot;
CudaHostPtr<SpotExtractorGPUSpot> host_spot; // SPOT_PREFIX entries, pinned
std::vector<SpotExtractorGPUSpot> overflow_spot; // only for a frame with more spots than that
public:
SpotExtractorGPU(int32_t width, int32_t height, std::shared_ptr<CudaStream> stream);
// Waits for the stream: its pooled buffers are freed next (see CudaDevicePtr).
~SpotExtractorGPU() { if (stream) cudaStreamSynchronize(*stream); }
void SetResolutionMask(const std::vector<uint32_t> &packed_mask);
// gpu_strong is the finder's device bit buffer, gpu_image the preprocessed image it was built
// from. Fills spots with every component of at most max-pix pixels, in the same order the host
// extractor would.
void Extract(const uint32_t *gpu_strong, const int32_t *gpu_image,
const SpotFindingSettings &settings, std::vector<DiffractionSpot> &spots);
// Strong pixels the last Extract() saw, after the resolution mask. Reported whether or not the
// frame was given up on, which is the point of it: a frame at or above max_strong yields no spots
// at all, and this is what says so.
[[nodiscard]] uint32_t StrongPixelCount() const { return *host_nstrong.get(); }
};