Files
Jungfraujoch/viewer/windows/JFJochViewerImageListWindow.cpp
leonarski_fandClaude Opus 5.5 7bc98279a9 rugnux: image counts per stage and a per-image merged vector
The report now states how many images made it through each stage, as
counts beside the indexing rate: IMAGES_INDEXED and LATTICES_INDEXED
(section 2; a stills measure, --developer on rotation like
INDEXING_RATE), IMAGES_INTEGRATED (section 2) and IMAGES_MERGED
(section 3), plus an "Images" summary line and a console line. An image
is integrated on its main lattice only - extra lattices are indexed but
not integrated - so integrated images are also integrated lattices.

The merge records per image whether any of its observations reached
it (MergeStatistics::image_merged): on stills from MergeOnTheFly's
AddImages (past the cell form, scale and --min-image-cc), on rotation
from the disposition ledger (not rejected). It drives the merged column
of _plot.txt (which on stills used to be approximated by "has a scale"),
goes to the _process.h5 as /entry/MX/imageMerged (and through CBOR),
is read back by the reader, replaces MergedCrystals for --mode scale's
INPUT_nn rows, and --mode scale now writes a _plot.txt for its merge.
_plot.txt gains an indexed column at the end, so no column moves.

jfjoch_viewer's image list gets a Merged column and, from the Index and
Merged header context menus, Yes/No/N/A row filters that combine (e.g.
indexed but not merged); a file without imageMerged shows N/A.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HVeDQrPqZ52Tp6rzzZGxf3
2026-11-19 13:51:31 +01:00

314 lines
11 KiB
C++

// SPDX-FileCopyrightText: 2025 Filip Leonarski, Paul Scherrer Institute <filip.leonarski@psi.ch>
// SPDX-License-Identifier: GPL-3.0-only
#include "JFJochViewerImageListWindow.h"
#include <QVBoxLayout>
#include <QHeaderView>
#include <QCloseEvent>
#include <QMenu>
namespace {
constexpr int ScaleSortRole = Qt::UserRole + 1;
constexpr double ScaleNotAvailableSortValue = -1.0e100;
// The Yes/No columns, filtered from the header's context menu.
constexpr int IndexColumn = 2;
constexpr int MergedColumn = 3;
const QStringList YesNoValues = {"Yes", "No", "N/A"};
}
void ImageListFilterModel::SetFilter(int column, const QSet<QString> &values) {
allowed[column] = values;
invalidateFilter();
}
void ImageListFilterModel::ClearFilter(int column) {
allowed.remove(column);
invalidateFilter();
}
bool ImageListFilterModel::Allows(int column, const QString &value) const {
return !allowed.contains(column) || allowed[column].contains(value);
}
bool ImageListFilterModel::filterAcceptsRow(int source_row, const QModelIndex &source_parent) const {
for (auto it = allowed.cbegin(); it != allowed.cend(); ++it)
if (!it.value().contains(sourceModel()->index(source_row, it.key(), source_parent).data().toString()))
return false;
return true;
}
JFJochViewerImageListWindow::JFJochViewerImageListWindow(QWidget *parent) : JFJochHelperWindow(parent) {
QWidget *centralWidget = new QWidget(this);
setCentralWidget(centralWidget);
QVBoxLayout *layout = new QVBoxLayout(centralWidget);
tableView = new QTableView(this);
tableModel = new QStandardItemModel(this);
setupTableModel();
proxyModel = new ImageListFilterModel(this);
proxyModel->setSourceModel(tableModel);
proxyModel->setSortRole(ScaleSortRole);
tableView->setModel(proxyModel);
tableView->sortByColumn(0, Qt::AscendingOrder);
tableView->setEditTriggers(QAbstractItemView::NoEditTriggers);
tableView->setSortingEnabled(true);
tableView->verticalHeader()->setVisible(false);
tableView->horizontalHeader()->setSectionsClickable(true);
tableView->horizontalHeader()->setSortIndicatorShown(true);
tableView->setSelectionBehavior(QAbstractItemView::SelectRows);
tableView->setSelectionMode(QAbstractItemView::SingleSelection);
tableView->horizontalHeader()->setSectionResizeMode(QHeaderView::Stretch);
layout->addWidget(tableView);
setWindowTitle("Image statistics");
resize(800, 600);
connect(tableView, &QTableView::doubleClicked, this, &JFJochViewerImageListWindow::onTableRowDoubleClicked);
// A click on a header sorts; its context menu filters the Yes/No columns.
tableView->horizontalHeader()->setContextMenuPolicy(Qt::CustomContextMenu);
connect(tableView->horizontalHeader(), &QHeaderView::customContextMenuRequested,
this, &JFJochViewerImageListWindow::onHeaderMenu);
}
void JFJochViewerImageListWindow::onHeaderMenu(const QPoint &pos) {
const int column = tableView->horizontalHeader()->logicalIndexAt(pos);
if (column != IndexColumn && column != MergedColumn)
return;
QMenu menu(this);
for (const QString &value : YesNoValues) {
QAction *action = menu.addAction(value);
action->setCheckable(true);
action->setChecked(proxyModel->Allows(column, value));
}
menu.addSeparator();
QAction *all = menu.addAction("Show all");
QAction *chosen = menu.exec(tableView->horizontalHeader()->mapToGlobal(pos));
if (!chosen)
return;
QSet<QString> values;
if (chosen != all)
for (QAction *action : menu.actions())
if (action->isCheckable() && action->isChecked())
values.insert(action->text());
if (chosen == all || values.size() == YesNoValues.size())
proxyModel->ClearFilter(column);
else
proxyModel->SetFilter(column, values);
const QString name = column == IndexColumn ? "Index" : "Merged";
tableModel->setHeaderData(column, Qt::Horizontal, proxyModel->IsFiltered(column) ? name + " *" : name);
}
void JFJochViewerImageListWindow::setupTableModel()
{
tableModel->setColumnCount(9);
tableModel->setHeaderData(0, Qt::Horizontal, "#");
tableModel->setHeaderData(1, Qt::Horizontal, "Bkg");
tableModel->setHeaderData(2, Qt::Horizontal, "Index");
tableModel->setHeaderData(3, Qt::Horizontal, "Merged");
tableModel->setHeaderData(4, Qt::Horizontal, "Spots");
tableModel->setHeaderData(5, Qt::Horizontal, "Res. [A]");
tableModel->setHeaderData(6, Qt::Horizontal, "Max val");
tableModel->setHeaderData(7, Qt::Horizontal, "Scale factor");
tableModel->setHeaderData(8, Qt::Horizontal, "Scale CC");
}
void JFJochViewerImageListWindow::addDataRow(int imageNumber, double backgroundEstimate,
const QString& indexingResult,
const QString& mergeResult,
int spotCount,
double resolutionEstimate,
int64_t max_value,
double image_scale_factor,
double image_scale_cc_percent) {
QList<QStandardItem*> rowItems;
QStandardItem *imageItem = new QStandardItem();
imageItem->setData(imageNumber, Qt::DisplayRole);
imageItem->setData(imageNumber, ScaleSortRole);
rowItems.append(imageItem);
QStandardItem *bgItem = new QStandardItem();
bgItem->setData(backgroundEstimate, Qt::DisplayRole);
bgItem->setData(backgroundEstimate, ScaleSortRole);
rowItems.append(bgItem);
for (const QString &result : {indexingResult, mergeResult}) {
QStandardItem *item = new QStandardItem(result);
if (result == "Yes")
item->setData(1, ScaleSortRole);
else if (result == "No")
item->setData(0, ScaleSortRole);
else
item->setData(-1, ScaleSortRole);
rowItems.append(item);
}
QStandardItem *spotItem = new QStandardItem();
spotItem->setData(spotCount, Qt::DisplayRole);
spotItem->setData(spotCount, ScaleSortRole);
rowItems.append(spotItem);
QStandardItem *resolutionItem = new QStandardItem();
resolutionItem->setData(QString::number(resolutionEstimate, 'f', 2), Qt::DisplayRole);
resolutionItem->setData(resolutionEstimate, ScaleSortRole);
rowItems.append(resolutionItem);
QStandardItem *maxValueItem = new QStandardItem();
maxValueItem->setData(static_cast<int32_t>(max_value), Qt::DisplayRole);
maxValueItem->setData(static_cast<int32_t>(max_value), ScaleSortRole);
rowItems.append(maxValueItem);
QStandardItem *scaleFactorItem = new QStandardItem();
if (std::isfinite(image_scale_factor)) {
scaleFactorItem->setData(image_scale_factor, Qt::DisplayRole);
scaleFactorItem->setData(image_scale_factor, ScaleSortRole);
} else {
scaleFactorItem->setData("N/A", Qt::DisplayRole);
scaleFactorItem->setData(ScaleNotAvailableSortValue, ScaleSortRole);
}
rowItems.append(scaleFactorItem);
QStandardItem *scaleCCItem = new QStandardItem();
if (std::isfinite(image_scale_cc_percent)) {
scaleCCItem->setData(QString::number(image_scale_cc_percent, 'f', 1) + "%", Qt::DisplayRole);
scaleCCItem->setData(image_scale_cc_percent, ScaleSortRole);
} else {
scaleCCItem->setData("N/A", Qt::DisplayRole);
scaleCCItem->setData(ScaleNotAvailableSortValue, ScaleSortRole);
}
rowItems.append(scaleCCItem);
tableModel->appendRow(rowItems);
}
void JFJochViewerImageListWindow::clearAllData() {
tableModel->removeRows(0, tableModel->rowCount());
}
void JFJochViewerImageListWindow::datasetLoaded(std::shared_ptr<const JFJochReaderDataset> in_dataset) {
dataset = std::move(in_dataset);
// One row of nine QStandardItems per image, arriving on every dataset tick of a live
// acquisition. Not worth doing for a window nobody has open.
if (!isVisible()) {
pending_fill = true;
return;
}
fillTable();
}
void JFJochViewerImageListWindow::showEvent(QShowEvent *event) {
JFJochHelperWindow::showEvent(event);
if (pending_fill) {
pending_fill = false;
fillTable();
}
}
void JFJochViewerImageListWindow::fillTable() {
clearAllData();
highlighted_row = -1;
if (!dataset)
return;
for (int i = 0; i < dataset->experiment.GetImageNum(); i++) {
float bkg_estimate = 0;
if (dataset->bkg_estimate.size() > i)
bkg_estimate = dataset->bkg_estimate[i];
int32_t spot_count = 0;
if (dataset->spot_count.size() > i)
spot_count = dataset->spot_count[i];
float res_estimation = 0.0f;
if (dataset->resolution_estimate.size() > i)
res_estimation = dataset->resolution_estimate[i];
QString indexing_result = "N/A";
if (dataset->indexing_result.size() > i) {
if (dataset->indexing_result[i] == 0)
indexing_result = "No";
else
indexing_result = "Yes";
}
QString merge_result = "N/A";
if (dataset->merge_result.size() > i)
merge_result = dataset->merge_result[i] == 0 ? "No" : "Yes";
int64_t max_value = 0;
if (dataset->max_value.size() > i)
max_value = dataset->max_value[i];
double image_scale_factor = NAN;
if (dataset->image_scale_factor.size() > i)
image_scale_factor = dataset->image_scale_factor[i];
double image_scale_cc_percent = NAN;
if (dataset->image_scale_cc.size() > i)
image_scale_cc_percent = dataset->image_scale_cc[i] * 100.0;
addDataRow(i + 1,
bkg_estimate,
indexing_result,
merge_result,
spot_count,
res_estimation,
max_value,
image_scale_factor,
image_scale_cc_percent);
}
}
void JFJochViewerImageListWindow::setRowBackground(int row, const QBrush &brush) {
if (row < 0 || row >= tableModel->rowCount())
return;
for (int col = 0; col < tableModel->columnCount(); ++col) {
if (QStandardItem *item = tableModel->item(row, col))
item->setBackground(brush);
}
}
void JFJochViewerImageListWindow::imageLoaded(std::shared_ptr<const JFJochReaderImage> image) {
int curr_row = -1;
if (image)
curr_row = image->ImageData().number;
if (curr_row == highlighted_row)
return;
// Only the row losing the highlight and the row gaining it change. Repainting every cell
// emitted dataChanged for the whole model - and a proxy re-sort - on each frame.
setRowBackground(highlighted_row, QBrush()); // back to the palette's own
// A translucent wash of the palette's highlight, so the text keeps its own colour and stays
// readable on the light and the dark palette alike.
QColor wash = palette().color(QPalette::Highlight);
wash.setAlpha(90);
setRowBackground(curr_row, wash);
highlighted_row = curr_row;
}
void JFJochViewerImageListWindow::onTableRowDoubleClicked(const QModelIndex &index) {
if (!index.isValid())
return;
QModelIndex sourceIndex = proxyModel->mapToSource(index);
int imageNumber = tableModel->item(sourceIndex.row(), 0)->data(Qt::DisplayRole).toInt();
emit imageSelected(imageNumber - 1, 1);
}