leonarski_fandClaude Opus 5
968d456a11
Build Packages / Create release (push) Successful in 40s
Build Packages / build:rugnux:aarch64 (cross) (push) Successful in 6m58s
Build Packages / build:rugnux-tgz (x86_64) (push) Successful in 8m35s
Build Packages / build:viewer-tgz:cpu (push) Successful in 9m50s
Build Packages / build:viewer-tgz:cuda (push) Successful in 11m18s
Build Packages / build:rpm (rocky8_nocuda) (push) Successful in 12m38s
Build Packages / build:windows:nocuda (push) Successful in 17m14s
Build Packages / build:windows:cuda (push) Successful in 19m46s
Build Packages / HDF5 consumer tests (DIALS, XDS) (push) Successful in 22m17s
Build Packages / build:rpm (rocky9_nocuda) (push) Successful in 17m8s
Build Packages / build:rpm (ubuntu2404_nocuda) (push) Successful in 16m25s
Build Packages / build:rpm (ubuntu2204_nocuda) (push) Successful in 17m37s
Build Packages / build:rugnux:windows (push) Successful in 10m36s
Build Packages / build:rpm (rocky8_sls9) (push) Successful in 16m38s
Build Packages / Generate python client (push) Successful in 17s
Build Packages / build:rpm (rocky9_sls9) (push) Successful in 16m37s
Build Packages / Build documentation (push) Successful in 1m7s
Build Packages / build:rpm (rocky8) (push) Successful in 17m11s
Build Packages / build:rpm (ubuntu2404) (push) Successful in 16m55s
Build Packages / build:rpm (ubuntu2204) (push) Successful in 17m31s
Build Packages / build:rpm (rocky9) (push) Successful in 19m38s
Build Packages / Unit tests (push) Successful in 1h41m0s
From the five-agent review of rc168-rc170 and the ticking-bomb hunt: - Every CUDA kernel launch is followed by cuda_err(cudaGetLastError()) (or the file's own check idiom) - 53 launches in 11 files ran unchecked, so a non-sticky launch failure (out-of-resources on a shared GPU, a zero grid) silently handed stale device buffers downstream as good data. The FFT indexer got this check in bfe95b4ed; this is the same gap everywhere else. BeamCenterFFTGPU already checked every launch through CheckLastKernel. - ShadowFinder: a non-finite or absurd beam centre is refused before it can become a negative ring index (an out-of-bounds write) or an arbitrarily large per-ring table; a pixel whose polarization correction is not strictly positive is not usable - divided by zero it put an inf into the pooled means, which the running box sums turn into NaN for a whole row. - FileWriter: the network-supplied image number is bounded by the collection's declared number_of_images - unbounded it sized per-image vectors, a huge value was a fatal allocation and a wrapping product an out-of-bounds heap write. - ROICircle/ROIAzimuthal: parameters must be finite, not merely positive - NaN passes every <= test, inf passes > 0, and both reached the preview drawing where a non-finite loop bound hangs the rendering thread. - Reader + viewer: documented that SWMR / growing HDF5 files are not supported - a file we open is expected to be final, which is why re-opening the currently open path deliberately does not re-read it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
84 lines
2.6 KiB
C++
84 lines
2.6 KiB
C++
// SPDX-FileCopyrightText: 2024 Filip Leonarski, Paul Scherrer Institute <filip.leonarski@psi.ch>
|
|
// SPDX-License-Identifier: GPL-3.0-only
|
|
|
|
#include <cmath>
|
|
#include "JFJochMath.h"
|
|
#include "ROIAzimuthal.h"
|
|
#include "JFJochException.h"
|
|
|
|
static float NormalizePhi_deg(float phi) {
|
|
phi = std::fmod(phi, 360.0f);
|
|
if (phi < 0)
|
|
phi += 360.0f;
|
|
return phi;
|
|
}
|
|
|
|
ROIAzimuthal::ROIAzimuthal(const std::string &in_name, float in_d_min_A, float in_d_max_A,
|
|
float in_phi_min_deg, float in_phi_max_deg)
|
|
: ROIElement(in_name),
|
|
phi_min_deg(NormalizePhi_deg(in_phi_min_deg)),
|
|
phi_max_deg(NormalizePhi_deg(in_phi_max_deg)) {
|
|
// isfinite, not just > 0: NaN passes every <= test and inf passes > 0 (see ROICircle).
|
|
if (!std::isfinite(in_d_min_A) || !std::isfinite(in_d_max_A)
|
|
|| (in_d_min_A <= 0) || (in_d_max_A <= 0)
|
|
|| !std::isfinite(in_phi_min_deg) || !std::isfinite(in_phi_max_deg))
|
|
throw JFJochException(JFJochExceptionCategory::InputParameterInvalid,
|
|
"Resolution and angles must be positive finite numbers");
|
|
if (in_d_min_A > in_d_max_A) {
|
|
d_max_A = in_d_min_A;
|
|
d_min_A = in_d_max_A;
|
|
} else {
|
|
d_max_A = in_d_max_A;
|
|
d_min_A = in_d_min_A;
|
|
}
|
|
}
|
|
|
|
float ROIAzimuthal::GetDMin_A() const {
|
|
return d_min_A;
|
|
}
|
|
|
|
float ROIAzimuthal::GetDMax_A() const {
|
|
return d_max_A;
|
|
}
|
|
|
|
bool ROIAzimuthal::HasPhi() const {
|
|
return phi_min_deg != phi_max_deg;
|
|
}
|
|
|
|
float ROIAzimuthal::GetPhiMin_deg() const {
|
|
return phi_min_deg;
|
|
}
|
|
|
|
float ROIAzimuthal::GetPhiMax_deg() const {
|
|
return phi_max_deg;
|
|
}
|
|
|
|
bool ROIAzimuthal::CheckROI(int64_t x, int64_t y, float resolution, float phi_deg) const {
|
|
if (resolution < d_min_A || resolution > d_max_A)
|
|
return false;
|
|
if (phi_min_deg == phi_max_deg)
|
|
return true; // full ring: all angles
|
|
if (phi_min_deg <= phi_max_deg)
|
|
return (phi_deg >= phi_min_deg) && (phi_deg <= phi_max_deg);
|
|
return (phi_deg >= phi_min_deg) || (phi_deg <= phi_max_deg); // sector wraps across 0
|
|
}
|
|
|
|
float ROIAzimuthal::GetQMax_recipA() const {
|
|
return 2.0f * PI / d_min_A;
|
|
}
|
|
|
|
float ROIAzimuthal::GetQMin_recipA() const {
|
|
return 2.0f * PI / d_max_A;
|
|
}
|
|
|
|
ROIConfig ROIAzimuthal::ExportMetadata() const {
|
|
double qmin = GetQMin_recipA();
|
|
double qmax = GetQMax_recipA();
|
|
return ROIConfig{
|
|
.type = ROIConfig::ROIType::Azim,
|
|
.name = name,
|
|
.azim = ROIConfigAzim{.qmin = qmin, .qmax = qmax,
|
|
.phi_min = phi_min_deg, .phi_max = phi_max_deg}
|
|
};
|
|
}
|