// SPDX-FileCopyrightText: 2026 Filip Leonarski, Paul Scherrer Institute // SPDX-License-Identifier: GPL-3.0-only #include #include #include #include #include "AdaptiveSpotFinderCPU.h" namespace { // Number of background pixels a ring needs before its own statistics are trusted; sparser rings // (detector corners, heavily masked, innermost) fall back to the whole-frame background. constexpr int64_t MIN_RING_PIXELS = 40; // Inverse standard-normal CDF (Acklam's rational approximation, ~1e-9 accuracy). Only called once // per frame, so accuracy over speed. double NormalQuantile(double p) { if (p <= 0.0) return -40.0; if (p >= 1.0) return 40.0; static const double a[] = {-3.969683028665376e+01, 2.209460984245205e+02, -2.759285104469687e+02, 1.383577518672690e+02, -3.066479806614716e+01, 2.506628277459239e+00}; static const double b[] = {-5.447609879822406e+01, 1.615858368580409e+02, -1.556989798598866e+02, 6.680131188771972e+01, -1.328068155288572e+01}; static const double c[] = {-7.784894002430293e-03, -3.223964580411365e-01, -2.400758277161838e+00, -2.549732539343734e+00, 4.374664141464968e+00, 2.938163982698783e+00}; static const double d[] = {7.784695709041462e-03, 3.224671290700398e-01, 2.445134137142996e+00, 3.754408661907416e+00}; const double plow = 0.02425, phigh = 1.0 - 0.02425; if (p < plow) { double q = std::sqrt(-2.0 * std::log(p)); return (((((c[0]*q+c[1])*q+c[2])*q+c[3])*q+c[4])*q+c[5]) / ((((d[0]*q+d[1])*q+d[2])*q+d[3])*q+1.0); } else if (p <= phigh) { double q = p - 0.5, r = q*q; return (((((a[0]*r+a[1])*r+a[2])*r+a[3])*r+a[4])*r+a[5])*q / (((((b[0]*r+b[1])*r+b[2])*r+b[3])*r+b[4])*r+1.0); } else { double q = std::sqrt(-2.0 * std::log(1.0 - p)); return -(((((c[0]*q+c[1])*q+c[2])*q+c[3])*q+c[4])*q+c[5]) / ((((d[0]*q+d[1])*q+d[2])*q+d[3])*q+1.0); } } // Smallest integer count whose Poisson(mu) upper tail P(X >= k) <= p. This is the correct // significance floor while the background is countable (it carries the sqrt(mu) shot-noise // implicitly, so a bright low-resolution ring gets a high threshold). It DEGENERATES at mu -> 0 // (a single photon on a zero background is "significant"), which is why it is max'd with a // read-noise-floored Gaussian arm by the caller. Short-circuits to Gaussian for large mu. float PoissonThreshold(double mu, double p, double z) { if (mu > 50.0) return static_cast(mu + z * std::sqrt(mu)); if (mu < 1e-6) mu = 1e-6; const double target = 1.0 - p; double pmf = std::exp(-mu); double cdf = pmf; int k = 0; while (cdf < target && k < 1000) { ++k; pmf *= mu / k; cdf += pmf; } return static_cast(k + 1); } } // namespace AdaptiveSpotFinderCPU::AdaptiveSpotFinderCPU(const AzimuthalIntegrationMapping &in_mapping) : ImageSpotFinder(static_cast(in_mapping.GetWidth()), static_cast(in_mapping.GetHeight())), mapping(in_mapping) { const size_t nbins = mapping.GetBinNumber(); ring_sum.assign(nbins, 0.0); ring_sum2.assign(nbins, 0.0); ring_cnt.assign(nbins, 0); ring_mean.assign(nbins, 0.0f); ring_sigma.assign(nbins, 0.0f); ring_thr.assign(nbins, 0.0f); // comp_of is allocated lazily (only the persistence variant needs it). } // Accumulate per-ring mean/variance from the raw (photon) image. clip_k <= 0 -> use every valid // pixel (first pass); clip_k > 0 -> keep only pixels within clip_k sigma of the current ring mean, // which removes the Bragg peaks from the background estimate. void AdaptiveSpotFinderCPU::AccumulateRings(const ImagePreprocessorBuffer &image, float clip_k) { const auto &pixel_to_bin = mapping.GetPixelToBin(); const size_t nbins = ring_sum.size(); const size_t npix = static_cast(width) * height; std::fill(ring_sum.begin(), ring_sum.end(), 0.0); std::fill(ring_sum2.begin(), ring_sum2.end(), 0.0); std::fill(ring_cnt.begin(), ring_cnt.end(), 0); for (size_t pxl = 0; pxl < npix; ++pxl) { const int32_t v = image[pxl]; if (v == INT32_MIN || v == INT32_MAX) continue; // bad / saturated const uint16_t b = pixel_to_bin[pxl]; if (b >= nbins) continue; // masked / out of range (UINT16_MAX) if (clip_k > 0.0f) { const float lo = ring_mean[b] - clip_k * ring_sigma[b]; const float hi = ring_mean[b] + clip_k * ring_sigma[b]; if (v < lo || v > hi) continue; // exclude peaks / outliers } ring_sum[b] += v; ring_sum2[b] += static_cast(v) * v; ring_cnt[b] += 1; } for (size_t b = 0; b < nbins; ++b) { if (ring_cnt[b] > 0) { const double m = ring_sum[b] / ring_cnt[b]; const double var = std::max(0.0, ring_sum2[b] / ring_cnt[b] - m * m); ring_mean[b] = static_cast(m); ring_sigma[b] = static_cast(std::sqrt(var)); } } } std::vector AdaptiveSpotFinderCPU::Run(const ImagePreprocessorBuffer &image, const SpotFindingSettings &settings, const std::vector &res_mask) { if (settings.spot_persistence) return RunPersistence(image, settings, res_mask); const auto &pixel_to_bin = mapping.GetPixelToBin(); const size_t nbins = ring_sum.size(); const size_t npix = static_cast(width) * height; // --- Stage A: robust per-ring background (one plain pass + two sigma-clip passes) --- AccumulateRings(image, 0.0f); AccumulateRings(image, 3.0f); AccumulateRings(image, 3.0f); // --- Stage B: per-ring threshold from the single portable knob E (false pixels / frame) --- int64_t n_total = 0; double g_sum = 0.0, g_sum2 = 0.0; for (size_t b = 0; b < nbins; ++b) { n_total += ring_cnt[b]; g_sum += ring_sum[b]; g_sum2 += ring_sum2[b]; } if (n_total == 0) return {}; const double E = std::max(1.0f, settings.false_pixels_per_frame); double p = E / static_cast(n_total); p = std::min(std::max(p, 1e-9), 0.1); const float z = static_cast(NormalQuantile(1.0 - p)); // A ring's threshold is background mean + z sigmas. sigma combines the ring's own (peak-excluded) // scatter with an excess-noise floor READ: near-zero-background rings scatter MORE than pure // Poisson (charge sharing / read noise / occasional spurious low counts), so a per-ring sigma // alone collapses toward zero on empty high-resolution rings and the threshold would flood. READ // is a detector-level photon-scale constant (the same for every dataset -- it is NOT the // per-dataset knob), so the operating point still self-calibrates through mean and sigma while // staying physical where the background vanishes. const float READ = 1.0f; auto ring_threshold = [&](float mean, float sigma) { // Poisson significance (correct where the background is countable) floored by a // read-noise-aware Gaussian arm (which alone survives mean -> 0, where Poisson degenerates // to "one photon is significant" and would flood the empty high-resolution rings). const float gauss = mean + z * std::sqrt(sigma * sigma + READ * READ); const float poisson = PoissonThreshold(mean, static_cast(p), static_cast(z)); return std::max(gauss, poisson); }; // whole-frame fallback background for rings too sparse to trust on their own const double g_mean = g_sum / n_total; const double g_sigma = std::sqrt(std::max(0.0, g_sum2 / n_total - g_mean * g_mean)); const float g_thr = ring_threshold(static_cast(g_mean), static_cast(g_sigma)); for (size_t b = 0; b < nbins; ++b) ring_thr[b] = (ring_cnt[b] < MIN_RING_PIXELS) ? g_thr : ring_threshold(ring_mean[b], ring_sigma[b]); // --- Stage C: flag strong pixels into the bit buffer (value >= ring threshold) --- for (size_t i = 0; i < OutputSize(); ++i) output_buffer[i] = 0; std::bitset<32> out = 0; for (size_t pxl = 0; pxl < npix; ++pxl) { const int32_t v = image[pxl]; const uint16_t b = pixel_to_bin[pxl]; bool strong = false; if (v == INT32_MAX) strong = true; else if (v != INT32_MIN && b < nbins && v >= ring_thr[b]) strong = true; const int32_t bit = pxl % 32; if (strong) out.set(bit); if (bit == 31) { output_buffer[pxl / 32] = out.to_ulong(); out.reset(); } } if (npix % 32 != 0) output_buffer[OutputSize() - 1] = out.to_ulong(); // --- Stage D: connected components + resolution mask + min/max-pix (shared with classic path) --- return ExtractSpots(image, settings, res_mask); } // Threshold-free variant. Build a noise-normalised image z = (I - ring_mean)/sqrt(ring_sigma^2+READ^2) // (same per-ring background and read-noise floor as the hard variant), then score every intensity // maximum by its 0-D topological persistence: sweep the height from high to low, each maximum is // "born" and, when its basin meets a taller one at a saddle, "dies" with persistence = birth - saddle // (in sigma units). A lone noise spike merges into the sea almost immediately (persistence ~1); a real // peak stands many sigma proud. Emitting maxima with persistence >= z(E) needs no photon threshold and // no min-pix, and deblends touching peaks (each keeps its own maximum). Union-find, same idiom as the // classic connected-component labeller. This is the offline/rugnux "soft" alternative to the hard cut. std::vector AdaptiveSpotFinderCPU::RunPersistence(const ImagePreprocessorBuffer &image, const SpotFindingSettings &settings, const std::vector &res_mask) { const auto &pixel_to_bin = mapping.GetPixelToBin(); const size_t nbins = ring_sum.size(); const size_t npix = static_cast(width) * height; if (comp_of.size() != npix) comp_of.assign(npix, -1); AccumulateRings(image, 0.0f); AccumulateRings(image, 3.0f); AccumulateRings(image, 3.0f); int64_t n_total = 0; double g_sum = 0.0, g_sum2 = 0.0; for (size_t b = 0; b < nbins; ++b) { n_total += ring_cnt[b]; g_sum += ring_sum[b]; g_sum2 += ring_sum2[b]; } if (n_total == 0) return {}; const double E = std::max(1.0f, settings.false_pixels_per_frame); double p = std::min(std::max(E / static_cast(n_total), 1e-9), 0.1); const float z = static_cast(NormalQuantile(1.0 - p)); const float READ = 1.0f; const float PERS_THR = z; // a maximum must stand z sigmas above its saddle to be a spot const float Z_FLOOR = 2.0f; // loose landscape floor: a compute bound, not a detection threshold const float g_mean = static_cast(g_sum / n_total); const float g_sigma = static_cast(std::sqrt(std::max(0.0, g_sum2 / n_total - g_mean * (double)g_mean))); auto mu_of = [&](uint16_t b) { return ring_cnt[b] < MIN_RING_PIXELS ? g_mean : ring_mean[b]; }; auto se_of = [&](uint16_t b) { const float s = ring_cnt[b] < MIN_RING_PIXELS ? g_sigma : ring_sigma[b]; return std::sqrt(s * s + READ * READ); }; // Candidate pixels: everything above a loose noise-normalised floor (in-resolution, not masked). struct Cand { float z; int32_t pxl; }; std::vector cand; for (size_t pxl = 0; pxl < npix; ++pxl) { if (res_mask[pxl]) continue; const int32_t v = image[pxl]; if (v == INT32_MIN) continue; const uint16_t b = pixel_to_bin[pxl]; if (b >= nbins) continue; const float zz = (v == INT32_MAX) ? 1.0e6f : (v - mu_of(b)) / se_of(b); if (zz > Z_FLOOR) cand.push_back({zz, static_cast(pxl)}); } if (cand.empty()) return {}; std::sort(cand.begin(), cand.end(), [](const Cand &a, const Cand &b) { return a.z > b.z; }); // Union-find over candidates, processed highest first. parent/birth/pers are per-component. std::vector parent; std::vector birth, pers; parent.reserve(cand.size()); birth.reserve(cand.size()); pers.reserve(cand.size()); auto find = [&](int32_t c) { while (parent[c] != c) { parent[c] = parent[parent[c]]; c = parent[c]; } return c; }; for (const auto &cd : cand) { const int32_t pxl = cd.pxl; const int32_t col = pxl % width, row = pxl / width; int32_t roots[8]; int nr = 0; for (int dr = -1; dr <= 1; ++dr) for (int dc = -1; dc <= 1; ++dc) { if (dr == 0 && dc == 0) continue; const int rr = row + dr, cc = col + dc; if (rr < 0 || rr >= height || cc < 0 || cc >= width) continue; const int32_t np = rr * width + cc; if (comp_of[np] < 0) continue; // neighbour not yet processed (lower z) const int32_t r = find(comp_of[np]); bool dup = false; for (int i = 0; i < nr; ++i) if (roots[i] == r) dup = true; if (!dup && nr < 8) roots[nr++] = r; } if (nr == 0) { // new maximum born const int32_t c = static_cast(parent.size()); parent.push_back(c); birth.push_back(cd.z); pers.push_back(1.0e9f); comp_of[pxl] = c; } else { int32_t tall = roots[0]; for (int i = 1; i < nr; ++i) if (birth[roots[i]] > birth[tall]) tall = roots[i]; for (int i = 0; i < nr; ++i) if (roots[i] != tall) { pers[roots[i]] = birth[roots[i]] - cd.z; parent[roots[i]] = tall; } comp_of[pxl] = tall; } } for (size_t c = 0; c < parent.size(); ++c) if (parent[c] == static_cast(c)) pers[c] = birth[c] - Z_FLOOR; // survivors // One spot per surviving maximum whose persistence clears the significance bar. std::unordered_map spots; for (const auto &cd : cand) { const int32_t root = find(comp_of[cd.pxl]); if (pers[root] < PERS_THR) continue; const int32_t pxl = cd.pxl; const int64_t v = (image[pxl] == INT32_MAX) ? 65535 : image[pxl]; spots[root].AddPixel(pxl % width, pxl / width, v); } for (const auto &cd : cand) comp_of[cd.pxl] = -1; // reset for the next frame (touched pixels only) std::vector out; out.reserve(spots.size()); for (auto &kv : spots) out.push_back(kv.second); return out; }