rugnux: the per-reflection correction factor is named for what it is, not for what it once held

The factor multiplied into each integrated intensity was called rlp, for reciprocal
Lorentz-polarization, and until this week that is all it held. It now also carries
the sensor efficiency at the angle the beam arrives, and on the stills path it holds
that efficiency and the polarization with no Lorentz term at all - correctly, since
the Lorentz factor of a still is one. Three different products under one name that
promises exactly one of them, in code where the neighbouring member is the total
correction.

Rename it prescaling_corr: multiplicative, applied before scaling, therefore not a
scale, and silent about its contents - which is the point, since the contents have
now grown twice. It is also what DIALS calls the same product. The stills refinement
member spelled "1 / rlp" becomes inv_corr, and the comments and usage text that
promised "the Lorentz-polarization factor and nothing else" now say what is actually
there.

The Lorentz term keeps its own name where it is computed, because that name is
correct. The two external spellings are untouched: the CBOR key and the reflection
dataset are a published format, and a reader that meets an unknown key would take
the factor as zero, which both the merge key and the ingest treat as a reflection to
drop - so every reflection would vanish and the run would still exit zero.

No output changes: the merged and unmerged files of two full runs are byte for byte
what the previous binary wrote, four stored files from before the efficiency
correction still re-scale identically, and the reflection datasets of the process
file are unchanged.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EFEJG6WBQv8th4UJFNe53N

This commit is contained in:

leonarski_f

2026-09-05 13:41:16 +02:00

co-authored by

Claude Opus 5

parent d6ccdbdb61

commit db9cc9106f

36 changed files with 134 additions and 113 deletions

									
										reader/HDF5MetadataSource.cpp
									
		+1
		-1
	
												View File
												
				@@ -396,7 +396,7 @@ bool ReadReflectionsFromGroup(HDF5Object &file,

				            .bkg = bkg.at(i),

				            .var_bkg = var_bkg_val,

				            .sigma = int_err.at(i),

				            .rlp = lp_val,

				            .prescaling_corr = lp_val,

				            .partiality = partiality_val,

				            .zeta = zeta_val,

				            .image_scale_corr = image_scale_corr_val