From d19f0686cb70eeaf05069ba9a486354849b3664d Mon Sep 17 00:00:00 2001 From: Filip Leonarski Date: Thu, 19 Nov 2026 08:37:59 +0100 Subject: [PATCH] docs: rotamers are searched; the Metal path's four kernels; the k_sol box as it is The "not yet" list named a rotamer search, which the side-chain field does; the Metal path runs four refinement kernels, not only the density gather; the ModelScaling.h comment gave k_sol up to 0.8 where the box stops at 0.6. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01HVeDQrPqZ52Tp6rzzZGxf3 --- docs/CPU_DATA_ANALYSIS_REFINEMENT.md | 7 ++++--- image_analysis/structure_refinement/ModelScaling.h | 6 +++--- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/docs/CPU_DATA_ANALYSIS_REFINEMENT.md b/docs/CPU_DATA_ANALYSIS_REFINEMENT.md index d5c2a82f2..d58b195ac 100644 --- a/docs/CPU_DATA_ANALYSIS_REFINEMENT.md +++ b/docs/CPU_DATA_ANALYSIS_REFINEMENT.md @@ -851,10 +851,11 @@ What the refinement does not do yet - each a known gap, not a design choice: density, not by refining each in turn. - **Alternative conformations and occupancies**: existing conformers are refined in place; no occupancy is refined and no conformer is added. -- **Rotamer and peptide-flip search**, and **Ramachandran restraints**. +- **Peptide-flip search** and **Ramachandran restraints** (side chains are searched over their staggered rotamers + by the side-chain field, ยง15.7). - **Real-space refinement**, and **jelly-body or reference-model restraints**. -- **A full Metal (Apple GPU) path**: on macOS the model density is gathered on the GPU and the rest of the - refinement runs on the CPU. +- **A full Metal (Apple GPU) path**: on macOS the model density, the atom-gradient sums, the solvent mask's + shrink and the side-chain field's sums run on the GPU and the rest of the refinement runs on the CPU. - **Validation beyond geometry**: the report gives the bond and angle rmsd, the metal-bond rmsd and the number of clashes, not a MolProbity-style analysis (Ramachandran, rotamer and clashscore statistics). diff --git a/image_analysis/structure_refinement/ModelScaling.h b/image_analysis/structure_refinement/ModelScaling.h index 0017b9547..37dd30c2f 100644 --- a/image_analysis/structure_refinement/ModelScaling.h +++ b/image_analysis/structure_refinement/ModelScaling.h @@ -24,9 +24,9 @@ // Levenberg-Marquardt: nothing there stops k_sol and b_sol reaching values a flat solvent model // is meaningless at (b_sol of 1707 A^2 was measured on this corpus). Here k_sol and b_sol come // from a grid search over the physical ranges, so an unphysical answer cannot be represented. -// The box the solvent parameters are searched in. The defaults are the physically reasonable -// range reported by Fokine & Urzhumtsev and adopted as phenix's default grid: k_sol in (0.1, 0.8) -// and b_sol in (10, 80) A^2, of which phenix searches b_sol 10-80 in steps of 5. A model with high +// The box the solvent parameters are searched in: k_sol in (0.10, 0.60) and b_sol in (10, 80) A^2. +// The b_sol range is the physically reasonable one reported by Fokine & Urzhumtsev and phenix's +// default grid (b_sol 10-80 in steps of 5); their k_sol range reaches 0.8, the box here stops at 0.6. A model with high // atomic B gets a higher b_sol ceiling (SolventBMax). struct ModelScaleBox { double k_lo = 0.10, k_hi = 0.60;