v1.0.0-rc.145 (#55)

This is an UNSTABLE release. The release has significant modifications for HDF5 writing logic - in case of troubles go back to 1.0.0-rc.144.

* **Default HDF5 writing mode is with VDS, not soft-links** - this improves DIALS compatibility and makes format more future-proof, NXmx legacy format might be phased-out in the future.
* XDS plugin: Improve performance of VDS reading.
* jfjoch_writer: Significant improvement on how file systems I/O are handled through a dedicated pass-through VFD.
* jfjoch_writer: Clean-up of HDF5 routines to better handle issues.

Reviewed-on: #55

writer/FileWriter.cpp

@@ -15,7 +15,6 @@ FileWriter::FileWriter(const StartMessage &request)
     if (start_message.file_format)
         format = start_message.file_format.value();
 
-    // defailt
     if (start_message.images_per_file <= 0)
         start_message.images_per_file = default_images_per_file;
 
@@ -103,9 +102,11 @@ void FileWriter::CloseFile(uint64_t file_number) {
     if (closed_files.contains(file_number))
         return;
 
-    AddStats(files[file_number]->Close());
+    auto file_stats = files[file_number]->Close();
     files[file_number].reset();
     closed_files.insert(file_number);
+
+    AddStats(file_stats);
 }
 
 void FileWriter::CloseOldFiles(uint64_t current_image_number) {
@@ -126,12 +127,31 @@ void FileWriter::CloseOldFiles(uint64_t current_image_number) {
 std::vector<HDF5DataFileStatistics> FileWriter::Finalize() {
     std::lock_guard<std::mutex> lock(hdf5_mutex);
 
+    std::exception_ptr first_exception;
+
     for (uint64_t f = 0; f < files.size(); ++f) {
-        if (files[f] && !closed_files.contains(f))
-            CloseFile(f);
+        if (files[f] && !closed_files.contains(f)) {
+            try {
+                CloseFile(f);
+            } catch (...) {
+                if (!first_exception)
+                    first_exception = std::current_exception();
+            }
+        }
     }
-    if (master_file)
-        master_file.reset();
+
+    if (master_file) {
+        try {
+            master_file.reset();
+        } catch (...) {
+            if (!first_exception)
+                first_exception = std::current_exception();
+        }
+    }
+
+    if (first_exception)
+        std::rethrow_exception(first_exception);
+
     return stats;
 }