v1.0.0-rc.135 (#44)

This is an UNSTABLE release. The release has significant modifications and bug fixes, if things go wrong, it is better to revert to 1.0.0-rc.132.

* Multiple small bug fixes scattered across the whole code base. (detected with GPT-5.4)
* jfjoch_viewer: Improve image render performance

Reviewed-on: #44
Co-authored-by: Filip Leonarski <filip.leonarski@psi.ch>
Co-committed-by: Filip Leonarski <filip.leonarski@psi.ch>

common/DiffractionSpot.cpp

@@ -40,6 +40,8 @@ int64_t DiffractionSpot::MaxCount() const {
 }
 
 Coord DiffractionSpot::RawCoord() const {
+    if (photons == 0)
+        return {0, 0, 0};
     return {x / (float)photons, y / (float)photons, 0};
 }
 
@@ -47,10 +49,6 @@ int64_t DiffractionSpot::PixelCount() const {
     return pixel_count;
 }
 
-double DiffractionSpot::GetResolution(const DiffractionGeometry &geom) const {
-    return geom.PxlToRes(x  / (float)photons, y / (float)photons);
-}
-
 void DiffractionSpot::AddPixel(uint32_t col, uint32_t line, int64_t photons) {
     this->x += col * (float) photons;
     this->y += line * (float) photons;
@@ -65,7 +63,10 @@ void DiffractionSpot::ConvertToImageCoordinates(const DiffractionExperiment &exp
     this->y = c_out.y * (float) photons;
 }
 
-SpotToSave DiffractionSpot::Export(const DiffractionGeometry &geometry, int64_t image_num) const {
+std::optional<SpotToSave> DiffractionSpot::Export(const DiffractionGeometry &geometry, int64_t image_num) const {
+    if (photons == 0)
+        return std::nullopt;
+
     auto d = geometry.PxlToRes(x / (float) photons, y / (float) photons);
 
     float phi = 0.0f;
@@ -75,7 +76,7 @@ SpotToSave DiffractionSpot::Export(const DiffractionGeometry &geometry, int64_t
         phi = geometry.GetRotation()->GetAngle_deg(image_num) + geometry.GetRotation()->GetWedge_deg() / 2.0f;
     }
 
-    return {
+    return SpotToSave{
         .x = x / static_cast<float>(photons),
         .y = y / static_cast<float>(photons),
         .phi = phi,