v1.0.0-rc.135 (#44)

This is an UNSTABLE release. The release has significant modifications and bug fixes, if things go wrong, it is better to revert to 1.0.0-rc.132.

* Multiple small bug fixes scattered across the whole code base. (detected with GPT-5.4)
* jfjoch_viewer: Improve image render performance

Reviewed-on: #44
Co-authored-by: Filip Leonarski <filip.leonarski@psi.ch>
Co-committed-by: Filip Leonarski <filip.leonarski@psi.ch>

common/DiffractionExperiment.cpp

@@ -311,7 +311,7 @@ std::chrono::microseconds DiffractionExperiment::GetFrameCountTime() const {
 }
 
 bool DiffractionExperiment::GetFrameCountTimeAuto() const {
-    return detector_settings.GetCountTime().has_value();
+    return !detector_settings.GetCountTime().has_value();
 }
 
 std::chrono::microseconds DiffractionExperiment::GetImageCountTime() const {
@@ -698,7 +698,7 @@ void DiffractionExperiment::FillMessage(StartMessage &message) const {
     message.detector_serial_number = detector.GetSerialNumber();
     message.write_master_file = dataset.IsWriteNXmxHDF5Master();
     message.overwrite = file_writer.IsOverwriteExistingFiles();
-    message.file_format = file_writer.GetHDF5MasterFormatVersion();
+    message.file_format = file_writer.GetFileFormat();
     message.ring_current_mA = dataset.GetRingCurrent_mA();
     message.sample_temperature_K = dataset.GetSampleTemperature_K();
     message.fluorescence_spectrum = dataset.GetFluorescenceSpectrum();
@@ -1084,7 +1084,7 @@ int64_t DiffractionExperiment::GetImagesPerFile() const {
     auto tmp = dataset.GetImagesPerFile();
 
     if (tmp == 0
-        || file_writer.GetHDF5MasterFormatVersion() == FileWriterFormat::NXmxIntegrated)
+        || file_writer.GetFileFormat() == FileWriterFormat::NXmxIntegrated)
         return GetImageNum();
     else
         return tmp;
@@ -1404,12 +1404,12 @@ bool DiffractionExperiment::IsElectronSource() const {
 }
 
 DiffractionExperiment &DiffractionExperiment::SetFileWriterFormat(FileWriterFormat input) {
-    file_writer.HDF5MasterFormatVersion(input);
+    file_writer.FileFormat(input);
     return *this;
 }
 
 FileWriterFormat DiffractionExperiment::GetFileWriterFormat() const {
-    return file_writer.GetHDF5MasterFormatVersion();
+    return file_writer.GetFileFormat();
 }
 
 DiffractionGeometry DiffractionExperiment::GetDiffractionGeometry() const {