From b4a29ebb32236c8f8de4a3fa11c2fcce47a9a6ec Mon Sep 17 00:00:00 2001 From: Filip Leonarski Date: Thu, 9 Jul 2026 09:44:21 +0200 Subject: [PATCH] Update grid scan_result test for dropped placeholder rows Commit 023a30cb0 intentionally filters uncollected placeholder rows (number = -1) out of ScanResultGenerator::GetResult() but left this test asserting the old full-grid vector size. The 3x3 grid collects only 7 of 9 cells, so scan_result now has 7 rows; the two uncollected placeholders sit at grid indices 5 and 8, after the checked positions, so the number assertions still hold. Co-Authored-By: Claude Fable 5 --- tests/JFJochReceiverProcessingTest.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/JFJochReceiverProcessingTest.cpp b/tests/JFJochReceiverProcessingTest.cpp index 8bae482a..801baebd 100644 --- a/tests/JFJochReceiverProcessingTest.cpp +++ b/tests/JFJochReceiverProcessingTest.cpp @@ -977,7 +977,9 @@ TEST_CASE("JFJochIntegrationTest_ZMQ_lysozyme_spot_and_index_grid", "[JFJochRece CHECK(receiver_out.status.images_sent == experiment.GetImageNum()); CHECK(!receiver_out.status.cancelled); - REQUIRE(receiver_out.scan_result.images.size() == 9); + // 3x3 grid = 9 cells, but only 7 images collected; the two uncollected + // placeholder rows (grid indices 5 and 8) are dropped from scan_result. + REQUIRE(receiver_out.scan_result.images.size() == 7); CHECK(receiver_out.scan_result.images[0].number == 0); CHECK(receiver_out.scan_result.images[1].number == 3); CHECK(receiver_out.scan_result.images[3].number == 1);