v1.0.0-rc.118 (#25)

This is an UNSTABLE release and not recommended for production use (please use rc.111 instead).

* jfjoch_viewer: Fix issue when HTTP sync silently disconnected when it was enabled when the broker was starting measurement.
* jfjoch_broker: Add protections on time of geometry optimization and reduce rotation recalculations

Reviewed-on: #25
Co-authored-by: Filip Leonarski <filip.leonarski@psi.ch>
Co-committed-by: Filip Leonarski <filip.leonarski@psi.ch>

image_analysis/RotationIndexer.cpp

@@ -41,6 +41,8 @@ void RotationIndexer::SetLattice(const CrystalLattice &lattice) {
 }
 
 void RotationIndexer::TryIndex() {
+    indexing_tried = true;
+
     // Index
     std::vector<SpotToSave> v_sel;
     std::vector<Coord> coords_sel;
@@ -57,7 +59,6 @@ void RotationIndexer::TryIndex() {
             idx.begin() + max_spots,
             idx.end(),
             [this](std::size_t a, std::size_t b) {
-                // Replace `.intensity` with the actual SpotToSave intensity member
                 return v_[a].intensity > v_[b].intensity;
             }
         );
@@ -111,7 +112,7 @@ std::optional<RotationIndexerResult> RotationIndexer::ProcessImage(int64_t image
 
     const auto rot = axis_->GetTransformation(image);
 
-    if (!indexed_lattice && image >= last_accumulated_image + image_stride) {
+    if (!indexing_tried && image >= last_accumulated_image + image_stride) {
         v_.reserve(v_.size() + spots.size());
         coords_.reserve(coords_.size() + spots.size());
 
@@ -125,32 +126,19 @@ std::optional<RotationIndexerResult> RotationIndexer::ProcessImage(int64_t image
         accumulated_images++;
         last_accumulated_image = image;
 
-        if (!indexed_lattice && accumulated_images >= min_images_for_indexing && image >= first_image_to_try_indexing) {
+        if (accumulated_images >= min_images_for_indexing && image >= first_image_to_try_indexing)
             TryIndex();
-            // If fails increase rotation range by a factor of two
-            if (!indexed_lattice)
-                first_image_to_try_indexing *= 2;
-        }
     }
 
-    if (indexed_lattice) {
-        return RotationIndexerResult{
-            .lattice = indexed_lattice->Multiply(rot.transpose()),
-            .search_result = search_result_,
-            .geom = updated_geom_
-        };
-    }
-    return {};
+    return GetLattice();
 }
 
-std::optional<RotationIndexerResult> RotationIndexer::Finalize() {
+std::optional<RotationIndexerResult> RotationIndexer::GetLattice() {
     if (!indexed_lattice)
-        TryIndex();
-    if (!indexed_lattice)
-        return std::nullopt;
+        return {};
     return RotationIndexerResult{
         .lattice = indexed_lattice.value(),
         .search_result = search_result_,
-        .geom = geom_
+        .geom = updated_geom_
     };
 }