From 7d5551fd86fc22d83d9f66cd5333a3083d2ba602 Mon Sep 17 00:00:00 2001 From: Filip Leonarski Date: Sat, 10 Oct 2026 14:02:58 +0200 Subject: [PATCH] battery: the no-crystal controls join the ci tier nothing_1 and nothing_2 now pass the no-crystal test by about seven decades (tails 10^-2.06 and 10^-2.70 against 1e-9) instead of 0.3-0.9, so a change that moves one stray reflection no longer flips them, and a regression that lets a chance lattice through fails CI. The ci tier is 28 sets. Co-Authored-By: Claude Opus 5.5 (1M context) Claude-Session: https://claude.ai/code/session_01EizBKhTqrAYago9KJG3dA3 --- .gitea/workflows/battery.yml | 2 +- tools/battery/README.md | 6 ++++-- tools/battery/inhouse.json | 4 ++-- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/.gitea/workflows/battery.yml b/.gitea/workflows/battery.yml index 785024627..9be7f04ef 100644 --- a/.gitea/workflows/battery.yml +++ b/.gitea/workflows/battery.yml @@ -1,6 +1,6 @@ name: Validation Battery -# Every push runs the ci tier of tools/battery (25 sets, about 10 minutes of rugnux on an RTX 5080, +# Every push runs the ci tier of tools/battery (28 sets, about 10 minutes of rugnux on an RTX 5080, # plus the build); the full battery (open + inhouse arms, about 2 hours of rugnux there) runs only # when started by hand. Both run on the one machine that holds the battery data, one at a time (the # concurrency group below), under their own runner label, with the data mounted read-only and diff --git a/tools/battery/README.md b/tools/battery/README.md index 343db2fe8..aff727312 100644 --- a/tools/battery/README.md +++ b/tools/battery/README.md @@ -269,7 +269,7 @@ R-free have a reference. `$B table RUN` prints it again for any finished run. - **smoke** covers the readers, the symmetry classes and some known hard cases; several of its sets fail on purpose. -- **ci** is the routine regression check: 26 sets that passed with the same space group and steady +- **ci** is the routine regression check: 28 sets that passed with the same space group and steady d_min and ISa in every full run of rc174 and rc175, with no warning that questions the lattice or the group (supercell, harmonic, twinning, untested centring). It spans HDF5, miniCBF, cbf.gz, marCCD (both formats) and SMV; every crystal system, centred and high-symmetry lattices, small @@ -277,7 +277,9 @@ R-free have a reference. `$B table RUN` prints it again for any finished run. (8qaw, about 2 minutes) - about 10 minutes of rugnux in all on the RTX 5080. A set that starts failing for a known, accepted reason leaves the tier; one that is merely slow stays. KDP joined later than the rest: it passes as an `indistinguishable_alternative` (I41md for I-42d), and its - twinning warning is most likely a false alarm from four heavy atoms in the cell. + twinning warning is most likely a false alarm from four heavy atoms in the cell. The two no-crystal + controls (nothing_1, nothing_2) joined once the no-crystal test got its own significance (1e-9): + they pass by reporting no lattice, about seven decades short of that level. **Exit status.** `run` exits with status 1 when a ci-tier set in the run failed - a wrong lattice or space group, a crash, a timeout or a missing input - and names those sets. This holds in any diff --git a/tools/battery/inhouse.json b/tools/battery/inhouse.json index 230fc0d91..e796742f0 100644 --- a/tools/battery/inhouse.json +++ b/tools/battery/inhouse.json @@ -36,8 +36,8 @@ {"id": "myob_x06da_powder_2", "input": "myob_x06da_powder_2/MyoB2-2_5ddd7d_master.h5", "wavelength": 0.95373, "ref": {"sgno": 3, "cell": [35.576, 28.811, 63.529, 90.0, 105.593, 90.0], "anomalous": false, "isa": 2.19, "completeness": 58.0, "r_meas": 1.106, "cc_half": 0.655, "multiplicity": 4.71, "dmin_low": 2.98, "r_meas_low": 0.706, "cc_half_high": 0.788, "dmin": 0.99, "dmin_rule": "xds_range", "dmin_xds": 0.99, "dmax": 999.0}, "tags": ["h5", "myoglobin", "twin"], "ref_override": {"sg": "P 1 21 1", "sgno": 4}, "ref_override_why": "myoglobin, P 1 21 1. XDS does not judge screw axes (it reports P 2)", "model": "4dc8"}, {"id": "myob_x06da_split", "input": "myob_x06da_split/MyoB2-4_079740_master.h5", "wavelength": 0.95373, "ref": {"sgno": 3, "cell": [35.39, 28.783, 63.626, 90.0, 105.544, 90.0], "anomalous": false, "isa": 12.41, "completeness": 77.7, "r_meas": 0.577, "cc_half": 0.984, "multiplicity": 4.38, "dmin_low": 4.48, "r_meas_low": 0.091, "cc_half_high": 0.994, "dmin": 1.506, "dmin_rule": "xds_range", "dmin_xds": 1.506, "dmax": 50.0}, "tags": ["h5", "myoglobin", "twin"], "ref_override": {"sg": "P 1 21 1", "sgno": 4}, "ref_override_why": "myoglobin, P 1 21 1. XDS does not judge screw axes (it reports P 2)", "model": "4dc8"}, {"id": "myob_x06da_sparse", "input": "myob_x06da_sparse/MyoB2-5_7cef9c_master.h5", "wavelength": 0.95373, "ref": {"sgno": 3, "cell": [35.388, 28.752, 64.083, 90.0, 106.352, 90.0], "anomalous": false, "isa": 5.46, "completeness": 73.7, "r_meas": 0.326, "cc_half": 0.972, "multiplicity": 5.21, "dmin_low": 5.92, "r_meas_low": 0.146, "cc_half_high": 0.254, "dmin": 2.0, "dmin_rule": "xds_range", "dmin_xds": 2.0, "dmax": 50.0}, "tags": ["h5", "myoglobin", "twin"], "ref_override": {"sg": "P 1 21 1", "sgno": 4}, "ref_override_why": "myoglobin, P 1 21 1. XDS does not judge screw axes (it reports P 2)", "model": "4dc8"}, - {"id": "nothing_2", "input": "nothing_2/test-28_3400ac_master.h5", "wavelength": 0.99988, "expect": "no_lattice", "tags": ["h5", "control"]}, - {"id": "nothing_1", "input": "nothing_1/test-28_9bf604_master.h5", "wavelength": 0.99988, "expect": "no_lattice", "tags": ["h5", "control"]}, + {"id": "nothing_2", "input": "nothing_2/test-28_3400ac_master.h5", "wavelength": 0.99988, "expect": "no_lattice", "tags": ["h5", "control"], "tiers": {"ci": "no-crystal control: must report no lattice"}}, + {"id": "nothing_1", "input": "nothing_1/test-28_9bf604_master.h5", "wavelength": 0.99988, "expect": "no_lattice", "tags": ["h5", "control"], "tiers": {"ci": "no-crystal control: must report no lattice"}}, {"id": "aspirin_x10sa_20keV", "input": "aspirin_x10sa_20keV/aspirin_1_002_master.h5", "wavelength": 0.61993, "cod": "7050897", "tags": ["h5", "monoclinic", "small-molecule"], "ref": {"sgno": 4, "cell": [11.262, 6.543, 11.257, 90.0, 95.916, 90.0], "anomalous": true, "isa": 27.4, "completeness": 84.0, "r_meas": 0.033, "cc_half": 0.999, "multiplicity": 3.14, "dmin_low": 2.01, "r_meas_low": 0.033, "cc_half_high": 0.997, "dmin": 0.68, "dmin_rule": "xds_range", "dmin_xds": 0.68, "dmax": 50.0}, "ref_override": {"sg": "P 1 21/c 1", "sgno": 14}, "ref_override_why": "aspirin form I, P 21/c; COD 7050897 - C. C. Wilson, New J. Chem. 26 (2002) 1733-1739, doi:10.1039/b203775k. XDS reports only Sohncke groups (P 21)", "tiers": {"ci": "small molecule, centrosymmetric P21/c"}}, {"id": "aspirin_x10sa_25keV", "input": "aspirin_x10sa_25keV/aspirin_1_001_master.h5", "wavelength": 0.49594, "cod": "7050897", "tags": ["h5", "monoclinic", "small-molecule"], "ref": {"sgno": 4, "cell": [11.255, 6.541, 11.259, 90.0, 95.916, 90.0], "anomalous": true, "isa": 29.25, "completeness": 86.6, "r_meas": 0.034, "cc_half": 0.999, "multiplicity": 3.15, "dmin_low": 1.63, "r_meas_low": 0.032, "cc_half_high": 0.994, "dmin": 0.55, "dmin_rule": "xds_range", "dmin_xds": 0.55, "dmax": 50.0}, "ref_override": {"sg": "P 1 21/c 1", "sgno": 14}, "ref_override_why": "aspirin form I, P 21/c; COD 7050897 - C. C. Wilson, New J. Chem. 26 (2002) 1733-1739, doi:10.1039/b203775k. XDS reports only Sohncke groups (P 21)"}, {"id": "citricacid_x10sa_20keV", "input": "citricacid_x10sa_20keV/citricacid_1_005_master.h5", "wavelength": 0.61993, "cod": "5000063", "tags": ["h5", "monoclinic", "small-molecule"], "ref": {"sgno": 4, "cell": [11.454, 5.579, 12.67, 90.0, 111.587, 90.0], "anomalous": true, "isa": 20.44, "completeness": 82.0, "r_meas": 0.041, "cc_half": 0.997, "multiplicity": 3.1, "dmin_low": 2.02, "r_meas_low": 0.05, "cc_half_high": 0.997, "dmin": 0.68, "dmin_rule": "xds_range", "dmin_xds": 0.68, "dmax": 50.0}, "ref_override": {"sg": "P 1 21/c 1", "sgno": 14}, "ref_override_why": "anhydrous citric acid, P 21/a (P 21/c in the standard setting); COD 5000063 - J. P. Glusker, J. A. Minkin, A. L. Patterson, Acta Cryst. B25 (1969) 1066-1072, doi:10.1107/S0567740869003542. XDS reports only Sohncke groups (P 21)"},