v1.0.0-rc.129 (#36)

This is an UNSTABLE release. The release has significant modifications and bug fixes, if things go wrong, it is better to revert to 1.0.0-rc.124.

* jfjoch_broker: Significant improvements in TCP image socket, as a viable alternative for ZeroMQ sockets (only a single port on broker side, dynamically change number of writers, acknowledgments for written files)
* jfjoch_broker: Delta phi is calculated also for still data in Bragg prediction
* jfjoch_broker: Image pusher statistics are accessible via the REST interface
* jfjoch_writer: Supports TCP image socket and for these auto-forking option

Reviewed-on: #36
Co-authored-by: Filip Leonarski <filip.leonarski@psi.ch>
Co-committed-by: Filip Leonarski <filip.leonarski@psi.ch>

common/ZMQWrappers.cpp

@@ -95,10 +95,14 @@ bool ZMQSocket::SendZeroCopy(void *data, size_t size,void (*callback)(void *, vo
     }
 
     auto result = zmq_msg_send(&msg, socket, (blocking ? 0 : ZMQ_DONTWAIT));
-    zmq_msg_close(&msg);
 
-    if (result == size)
-        return true;
+    // https://libzmq.readthedocs.io/en/latest/zmq_msg_send.html
+    // zmq_msg_close only if it fails to send
+    if (result >= 0)
+        return true;  // msg is now owned by ZMQ — do NOT close it
+
+    // Send failed — we must close the message ourselves
+    zmq_msg_close(&msg);
 
     if ((errno == EAGAIN) || (errno == EINTR))
         return false;