Merge branch 'c-screw-undetermined' into pool-C

This commit is contained in:
leonarski_f committed 2026-09-20 18:45:17 +02:00
commit 508fcfb400
8 files changed
+281 -2

No files matched your search

+36
View File
@@ -475,6 +475,42 @@ ReportDocument BuildReportDocument(const std::string &output_prefix,
alts += (alts.empty() ? "" : " | ") + alt.xhm();
Add(s, KeyText("SPACE_GROUP_ALTERNATIVES", alts.empty() ? "NONE" : alts));
// ...and WHICH axis is open, which the list of names above does not say. A screw the data
// could not test is not a near miss between two groups - it is a question nobody asked, and
// the group that gets written is the one claiming no screw, by convention. Say the axis, say
// why, and leave SPACE_GROUP_NAME and the written files exactly as they are: a reflection
// file cannot hold "maybe a screw".
std::string undet;
if (result.space_group_search.has_value())
for (const auto &u : result.space_group_search->undetermined_screws)
undet += (undet.empty() ? "" : " ") + std::string(1, u.axis);
Add(s, KeyText("SPACE_GROUP_SCREW_UNDETERMINED", undet.empty() ? "NONE" : undet,
undet.empty()));
if (!undet.empty() && result.space_group_search.has_value()) {
std::string why;
for (const auto &u : result.space_group_search->undetermined_screws)
why += fmt::format(
"\n {}: the {} row {}", u.axis, u.row_label,
u.n_observed == 0
? "holds no reflections in this merge at all, so a screw along this axis\n"
" was never tested - the row was not recorded (it can lie in the "
"spindle's blind\n cone, or outside the resolution range)."
: u.n_control == 0
? fmt::format("holds {} reflection(s) but no control class to judge their\n"
" strength against, so how weak they are says nothing.",
u.n_observed)
: fmt::format("does not separate the candidates ({} absent, {} control).",
u.n_absent, u.n_control));
Add(s, Prose(fmt::format(
" SPACE_GROUP_SCREW_UNDETERMINED names the axes whose SCREW these data could not\n"
" decide at all:{}\n"
" On those axes SPACE_GROUP_NAME is not an answer - the answer is it or any of\n"
" SPACE_GROUP_ALTERNATIVES, and no measurement here chooses. The lowest-numbered\n"
" group, the one claiming no screw, is what the .mtz/.cif/.hkl carry, because a\n"
" reflection file must name one group. To settle it, collect the missing row: a\n"
" different crystal orientation, or a sweep that reaches it.", why)));
}
// The hand is a separate question from the alternatives, decidable from the 22 groups' numbers
// alone. Written only where the group HAS an enantiomorphic partner: on every other group the
// answer is NOT_APPLICABLE, which answers a question nobody asked.