v1.0.0-rc.128 (#35)

This is an UNSTABLE release. The release has significant modifications and bug fixes, if things go wrong, it is better to revert to 1.0.0-rc.124.

* jfjoch_broker: Handle properly reuse of image buffer locations
* jfjoch_broker: Fix bug in counting idle slots
* jfjoch_broker: Force obtuse angle for monoclinic cells
* jfjoch_process: Change scaling refinement tolerance

Reviewed-on: #35
Co-authored-by: Filip Leonarski <filip.leonarski@psi.ch>
Co-committed-by: Filip Leonarski <filip.leonarski@psi.ch>

image_pusher/ZMQStream2PusherSocket.cpp

@@ -31,9 +31,8 @@ bool ZMQStream2PusherSocket::Send(const uint8_t *data, size_t size) {
 
 void ZMQStream2PusherSocket::StartWriterThread() {
     std::unique_lock ul(m);
-
-    send_future = std::async(std::launch::async, &ZMQStream2PusherSocket::WriterThread, this);
     active = true;
+    send_future = std::async(std::launch::async, &ZMQStream2PusherSocket::WriterThread, this);
 }
 
 void ZMQStream2PusherSocket::StopWriterThread() {
@@ -56,8 +55,10 @@ void ZMQStream2PusherSocket::WriterThread() {
     while (!e.end) {
         // When hitting timeout on SendZeroCopy consider it a transmission error and switch to non-blocking communication
         bool blocking_send = !transmission_error;
-        if (!s.SendZeroCopy(e.z->GetImage(), e.z->GetImageSize(), zmq_socket_free, e.z, blocking_send))
+        if (!s.SendZeroCopy(e.z->GetImage(), e.z->GetImageSize(), zmq_socket_free, e.z, blocking_send)) {
             transmission_error = true;
+            e.z->release(); // Important: callback won't run on failed enqueue/send
+        }
         e = queue.GetBlocking();
     }
 }