rugnux report: count overloads and overlapping spots, warn with advice

Overloads: the integrated reflections whose signal disk held a saturated
pixel are counted on the integration outcome before the merge, over the
whole range and over the reflections coarser than 4 A, where they
concentrate (log line "Overloads:", report OVERLOADED_REFLECTIONS*). An
OVERLOADS warning fires from 0.05% of all, or 0.25% of the low-resolution
reflections, and recommends attenuation / a shorter exposure. Measured: a
strongly diffracting in-house sweep reads 0.017% / 0.42% (warned), an
ordinary sweep with a few hundred overloaded partials 0.001% / 0.012%.

Overlaps: both integration engines count the signal disks a nearer
neighbour's prediction takes pixels from (the overlap ownership the default
--overlap exclude already builds), and those left under --overlap-minpk of
their own - BraggIntegrationCounts::overlapped / overlapped_major (log line
"Overlapping spots:", report OVERLAPPED_REFLECTIONS*). An OVERLAPS warning
fires from 1% in the second and recommends a longer distance, finer slicing
or a smaller beam; on 10 battery sets it fires on the two long-axis ones
(8.3% and 13.4%), the rest read 0.0-0.44%. Summary lines for both;
documented in RUGNUX_REPORT.md.

Counters only; nothing reads them. p.mtz md5-identical to the rc175
battery on 10 sets.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SVmAWnzCmRKAXVUCdc4iNi
This commit is contained in:
leonarski_fandClaude Opus 5.5 committed 2026-10-09 18:36:25 +02:00
1 parent f462047038
commit 2632b77eb5
11 files changed
+207 -6

No files matched your search

+27
View File
@@ -1236,3 +1236,30 @@ TEST_CASE("ResultReport_BeamCentreOff", "[Diagnostics]") {
CHECK(text.find("\nPATHOLOGY_FLAGS= BEAM_CENTRE_OFF\n") != std::string::npos);
CHECK(text.find("the background's word alone") != std::string::npos);
}
TEST_CASE("ResultReport_OverloadsAndOverlaps", "[Diagnostics]") {
DiffractionExperiment x(DetJF(1));
ProcessResult result;
result.integrated_reflections = 100000;
result.integrated_reflections_low_res = 5000;
result.overloaded_reflections = 5;
result.overloaded_reflections_low_res = 5;
result.predicted_reflections = 100000;
result.overlapped_reflections = 5000;
result.overlapped_reflections_major = 500;
auto text = RenderResultReport("p", "in.h5", x, result);
CHECK(text.find("\nOVERLOADED_REFLECTIONS= 5\n") != std::string::npos);
CHECK(text.find("\nOVERLOADED_REFLECTIONS_LOW_RES_PCT= 0.100\n") != std::string::npos);
CHECK(text.find("\nOVERLAPPED_REFLECTIONS_MAJOR_PCT= 0.50\n") != std::string::npos);
CHECK(text.find("\nPATHOLOGY_FLAGS= NONE\n") != std::string::npos);
// 1.2% of the low-resolution reflections overloaded, 1.5% left under MINPK: both warn.
result.overloaded_reflections = 60;
result.overloaded_reflections_low_res = 60;
result.overlapped_reflections_major = 1500;
text = RenderResultReport("p", "in.h5", x, result);
CHECK(text.find("\nPATHOLOGY_FLAGS= OVERLOADS OVERLAPS\n") != std::string::npos);
CHECK(text.find("Attenuate the beam") != std::string::npos);
CHECK(text.find("Move the detector back") != std::string::npos);
}