Rigid body: no JFJOCH_RIGID_BODY_CPU; GPU/CPU parity tests tightened
The GPU rigid body is chosen by whether a card is there, nothing else. A run that must stay on the CPU says so at the process level (CUDA_VISIBLE_DEVICES=), which RigidBodyGPUPool::Create already honours through get_gpu_count(). Parity tests ([ModelValidation][gpu], compiled into jfjoch_test on a CUDA build): - every GPU case now SKIPs without a card, instead of passing silently; - ModelMaskGPU_MatchesGemmi also checks that the CPU path's PutMaskOnGrid is gemmi's mask bit for bit on the same grid, so the GPU mask is held against the CPU path itself; - RigidBodyGPU_MatchesCPU: Jacobian columns 2e-3 -> 5e-4 relative (measured up to 5e-5; the floor is the 1e-4 the scale's near-tie can move every column by). Residuals stay at 2e-4 of <Fobs> (measured up to 3.9e-5); - RigidBodyGPU_FitAgreesWithCPU: fit endpoint 2e-3 -> 1e-5 A rmsd (measured up to 5e-7 A). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D1G8gJVAy6gp1K5Dz3NE5C
This commit is contained in:
1 parent
b1f79ed27f
commit
23812b902c
4 files changed
+35
-33
No files matched your search
@@ -230,7 +230,7 @@ const Case CASES[] = {
|
||||
|
||||
TEST_CASE("ModelScaleGPU_FitMatchesGemmi", "[ModelValidation][gpu]") {
|
||||
if (get_gpu_count() == 0)
|
||||
return;
|
||||
SKIP("No GPU");
|
||||
for (const Case &c : CASES) {
|
||||
INFO(c.name);
|
||||
gemmi::UnitCell cell(c.a, c.b, c.c, c.alpha, c.beta, c.gamma);
|
||||
@@ -261,7 +261,7 @@ TEST_CASE("ModelScaleGPU_FitMatchesGemmi", "[ModelValidation][gpu]") {
|
||||
|
||||
TEST_CASE("ModelScaleGPU_SolventGridMatchesFitModelScale", "[ModelValidation][gpu]") {
|
||||
if (get_gpu_count() == 0)
|
||||
return;
|
||||
SKIP("No GPU");
|
||||
for (const Case &c : CASES) {
|
||||
INFO(c.name);
|
||||
gemmi::UnitCell cell(c.a, c.b, c.c, c.alpha, c.beta, c.gamma);
|
||||
@@ -283,7 +283,7 @@ TEST_CASE("ModelScaleGPU_SolventGridMatchesFitModelScale", "[ModelValidation][gp
|
||||
// per-evaluation fit at that solvent pair.
|
||||
TEST_CASE("ModelScaleGPU_MatchesGemmiOnAModelsPoints", "[ModelValidation][gpu]") {
|
||||
if (get_gpu_count() == 0)
|
||||
return;
|
||||
SKIP("No GPU");
|
||||
const char *crysts[] = {
|
||||
"CRYST1 40.000 50.000 60.000 90.00 90.00 90.00 P 1 1\n",
|
||||
"CRYST1 40.000 50.000 60.000 90.00 100.00 90.00 C 1 2 1 4\n",
|
||||
@@ -319,7 +319,7 @@ TEST_CASE("ModelScaleGPU_MatchesGemmiOnAModelsPoints", "[ModelValidation][gpu]")
|
||||
|
||||
TEST_CASE("ModelScaleGPU_Deterministic", "[ModelValidation][gpu]") {
|
||||
if (get_gpu_count() == 0)
|
||||
return;
|
||||
SKIP("No GPU");
|
||||
gemmi::UnitCell cell(72, 44, 51, 90, 112, 90);
|
||||
gemmi::Scaling<float> cpu = MakeScaling(cell, *gemmi::find_spacegroup_by_name("C 1 2 1"), 2.5);
|
||||
GpuPoints gpu(cpu);
|
||||
|
||||
Reference in new issue
Block a user