rugnux: don't reuse absent spots on plain DECTRIS datasets

reuse_rotation_spots defaults on, so the two-pass first phase read stored spots from /entry/MX. A standard DECTRIS dataset has no spot-finding results, so every frame came back with zero spots and indexing failed ("Two-pass rotation indexing failed") instead of falling back to finding spots. Add HasStoredSpots() to the reader (HDF5MetadataSource::HasSpots): spots exist if /entry/MX/nPeaks is present in the master (integrated _process.h5) or the per-image data file (VDS/legacy) - the same master-first-then-source path ReadSpots uses. Rugnux reuses stored spots only when they exist, otherwise it runs spot finding (and logs it); --redo-rotation-spots already forced finding. Verified: a true no-/entry/MX rotation dataset fails on the old code and indexes (P21) on the new; all jungfraujoch files (spots in master or in data files) still reuse unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-11 22:56:28 +02:00
parent f737424bdf
commit 0dfaf0a58a
5 changed files with 31 additions and 1 deletions
@@ -1180,3 +1180,16 @@ std::vector<SpotToSave> HDF5MetadataSource::ReadSpots(int64_t requested_image) c

    return tmp_message.spots;
 }
+
+bool HDF5MetadataSource::HasSpots() const {
+    // Stored spots (jungfraujoch spot finding) live under /entry/MX; a plain DECTRIS file has none,
+    // so ReadSpots would silently return nothing and the caller must find them itself. ReadSpots
+    // reads /entry/MX/nPeaks master-first-then-source, so check both: the integrated _process.h5
+    // keeps it in the master, while a VDS/legacy dataset keeps the per-image arrays in the data file.
+    if (!master_file || number_of_images == 0)
+        return false;
+    if (master_file->Exists("/entry/MX/nPeaks"))
+        return true;
+    const auto loc = ResolveMeta(0);
+    return loc.file && loc.file->Exists("/entry/MX/nPeaks");
+}