Anderson: accelerate a scaling loop only near its fixed point, and never again once its step grows (RESULT-CHANGING)

The Anderson commit before this one changed three rc176 battery results, which is why it was
reverted there. One of them is the acceleration's own doing: on a split myoglobin sweep (P2_1,
ISa 2.5) the partials loops never settle - one walks at a step of ~2e-2 for as long as it runs -
and the fulls loops walk from their first round (their cross-validated lambda moves every round,
so the map itself is not fixed). Restarting the history whenever the step grew only rebuilt a
one- or two-round history and extrapolated along the walk: the stalled loops ended somewhere
else, the pre-pass fulls smoothing window went from ~7 frames to ~1, and CC1/2 fell 0.701 -> 0.595.

Two rules now confine the acceleration to the regime it is for - a map contracting to its fixed
point:
- a loop is accelerated only once its plain step is below ten times the tolerance (1e-2);
- the first round whose weighted residual grew turns the acceleration off for the rest of the
  loop (AndersonMixing::Stopped), instead of restarting it.
A loop that walks therefore stays the plain loop it was in rc176. The growth rule alone gave
CC1/2 0.625; with the onset, 0.701, as rc176.

Measured against rc176 bc191bb80 (GPU, workstation):
- myob_x06da_split: P2_1, CC1/2 0.701, d 1.81 A - as rc176; 481 -> 257 scaling iterations.
- 7qij 434 -> 126 iterations, 9v16 273 -> 101, same space group and statistics.
- ci tier (29 sets, no null model): 28 unchanged beyond noise; sum of times 580 -> 585 s
  (9gdj +9 s, below).
The two other changes are NOT Anderson's and stay:
- insu_I_x06da_weak I23 -> I222: the all-observations search refuses I23 on a merge chi2 ratio
  2.08 against a 1.85 bound; plain scaling converged to 1e-5 gives 2.07-2.09 and refuses it too.
  Only the plain loop stopped at 1e-3 passed - the bound was set on unconverged scaling.
- 9gdj +9 s, same answer: the early beam-centre comparison's "loses beyond noise" margin
  (-0.002 against 2 sigma 0.0016) moves by ~0.07 between scaling paths, so the converged loop no
  longer takes the shortcut and both centres are judged on all frames; the file's centre is kept
  either way.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PXc1zD1yxHqaR1DGdCTHL4
This commit is contained in:
leonarski_fandClaude Opus 5.5 committed 2026-10-19 18:49:24 +02:00
1 parent 138abafa14
commit 0894230671
5 files changed
+33 -13

No files matched your search

+6 -3
View File
@@ -104,12 +104,15 @@ TEST_CASE("AndersonMixing_ZeroWeightTakesThePlainStep", "[RotationScale]") {
CHECK(anderson.Restarts() == 0);
}
TEST_CASE("AndersonMixing_RestartsWhenTheResidualGrows", "[RotationScale]") {
TEST_CASE("AndersonMixing_PlainOnceTheResidualGrows", "[RotationScale]") {
AndersonMixing anderson(5);
const std::vector<double> w{1.0};
CHECK(anderson.Next({1.0}, {0.5}, w)[0] == 0.5); // no history: the plain step
anderson.Next({0.5}, {0.25}, w); // residual fell: history kept
CHECK(!anderson.Stopped());
CHECK(anderson.Next({0.0}, {2.0}, w)[0] == 2.0); // residual grew: the plain step
CHECK(anderson.Stopped());
CHECK(anderson.Next({2.0}, {2.1}, w)[0] == 2.1); // and plain from then on, though it fell again
CHECK(anderson.Next({2.1}, {2.15}, w)[0] == 2.15);
CHECK(anderson.Restarts() == 0);
CHECK(anderson.Next({0.0}, {2.0}, w)[0] == 2.0); // residual grew: history dropped, plain step
CHECK(anderson.Restarts() == 1);
}