Commit Graph
32 Commits
Author SHA1 Message Date
duan_jandClaude Fable 5 46aed87a4c style: narrow the log pop-out view for the pyright gate
CI / lint (push) Skipped
CI / test (3.11) (push) Skipped
CI / test (3.12) (push) Skipped
CI / test (3.13) (push) Skipped
CI / test-with-beamline-plugins (pxi_bec) (push) Skipped
CI / test-with-beamline-plugins (pxii_bec) (push) Skipped
CI / test-with-beamline-plugins (pxiii_bec) (push) Skipped
CI / test (3.11) (pull_request) Successful in 1m1s
CI / test (3.12) (pull_request) Successful in 1m0s
CI / test (3.13) (pull_request) Successful in 1m0s
CI / test-with-beamline-plugins (pxi_bec) (pull_request) Successful in 1m0s
CI / test-with-beamline-plugins (pxii_bec) (pull_request) Successful in 1m2s
CI / test-with-beamline-plugins (pxiii_bec) (pull_request) Successful in 1m18s
CI / test-with-coverage (pull_request) Successful in 1m31s
CI / coverage-analysis (pull_request) Successful in 3s
CI / lint (pull_request) Successful in 2m29s
The Optional _popout_view is assert-narrowed once after opening; the
unguarded accesses were the last three diff-gate violations.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-08-07 17:52:30 +02:00
duan_jandClaude Fable 5 b4d680494b test: cover the sample-status logic, wheel guard, pop-outs, and log mirror
CI / lint (push) Skipped
CI / test (3.11) (push) Skipped
CI / test (3.12) (push) Skipped
CI / test (3.13) (push) Skipped
CI / test-with-beamline-plugins (pxi_bec) (push) Skipped
CI / test-with-beamline-plugins (pxii_bec) (push) Skipped
CI / test-with-beamline-plugins (pxiii_bec) (push) Skipped
CI / test (3.11) (pull_request) Successful in 58s
CI / test (3.13) (pull_request) Successful in 55s
CI / test (3.12) (pull_request) Successful in 1m1s
CI / test-with-beamline-plugins (pxi_bec) (pull_request) Successful in 1m4s
CI / test-with-beamline-plugins (pxii_bec) (pull_request) Successful in 1m3s
CI / test-with-beamline-plugins (pxiii_bec) (pull_request) Successful in 1m18s
CI / test-with-coverage (pull_request) Successful in 1m29s
CI / coverage-analysis (pull_request) Successful in 3s
CI / lint (pull_request) Failing after 2m32s
New tests for what the port added: status tint priority and
context-dependent chip filters on the dewar/queue model, the
right-button wheel guard (motor protection), PopoutWindow edge maths,
manual-resize fallback, close-hides behavior and DockTitleBar, the
chip drag-drop relabeling, and the console-log pop-out mirror. The
widgets' __main__ self-checks are superseded by these and removed.
Brings PR diff coverage from 70% to 81% (gate: 80%).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-08-07 17:48:50 +02:00
duan_jandClaude Fable 5 9908411d4a test: track the sample-table column shift, sort imports
The frozen #+status column shifted data columns +1, so the User-column
model tests move from index 5 to 6; ruff import-sort fixes for
main_window and log_panel ride along.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-08-07 17:11:06 +02:00
duan_jandClaude Fable 5 86b3f56690 style: move panel and model colors to the shared palette
Mechanical swap of hardcoded color literals for styles.py constants and
qcolor() across panels, models, and scan_logic. portrait_mode.py drops
its private palette block; beamline_controls and data_collection_settings
gain object names so the new $border QSS rules can target them. The
status-panel test asserts the palette hex instead of 'red'.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-08-07 10:19:28 +02:00
duan_jandClaude Fable 5 5948b51c80 test: cover the beamline state bar
CI / lint (push) Skipped
CI / test (3.11) (push) Skipped
CI / test (3.12) (push) Skipped
CI / test (3.13) (push) Skipped
CI / test-with-beamline-plugins (pxi_bec) (push) Skipped
CI / test-with-beamline-plugins (pxii_bec) (push) Skipped
CI / test-with-beamline-plugins (pxiii_bec) (push) Skipped
CI / test (3.13) (pull_request) Successful in 42s
CI / test-with-beamline-plugins (pxii_bec) (pull_request) Successful in 45s
CI / test (3.12) (pull_request) Successful in 54s
CI / test-with-beamline-plugins (pxi_bec) (pull_request) Successful in 56s
CI / test-with-beamline-plugins (pxiii_bec) (pull_request) Successful in 1m8s
CI / lint (pull_request) Failing after 2m0s
CI / test (3.11) (pull_request) Successful in 2m33s
CI / test-with-coverage (pull_request) Successful in 2m26s
CI / coverage-analysis (pull_request) Successful in 3s
Availability sets (routes + menu shortcuts, Moving/unknown), signal
gating, palette and cursors per availability, red/blue active states,
adaptive label wrapping, left-click hint paths, hover-hint timer
lifecycle, and pending-target clearing. Lifts the PR diff coverage back
over the 80 percent gate (measured 88 percent locally).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-08-06 18:39:27 +02:00
duan_jandClaude Fable 5 38dbb16b9c feat: start all collapsible panels collapsed by default
A fresh GUI shows only the banners; the Beamline state panel keeps its
own expanded default. A user's saved per-title states still override.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-08-06 16:54:44 +02:00
duan_jandClaude Fable 5 a1118ad6e2 style: fix lint for the banner/adaptive changes
CI / lint (push) Skipped
CI / test (3.11) (push) Skipped
CI / test (3.12) (push) Skipped
CI / test (3.13) (push) Skipped
CI / test-with-beamline-plugins (pxi_bec) (push) Skipped
CI / test-with-beamline-plugins (pxii_bec) (push) Skipped
CI / test-with-beamline-plugins (pxiii_bec) (push) Skipped
CI / test (3.11) (pull_request) Successful in 53s
CI / test-with-beamline-plugins (pxi_bec) (pull_request) Successful in 51s
CI / test (3.13) (pull_request) Successful in 56s
CI / test-with-beamline-plugins (pxiii_bec) (pull_request) Successful in 56s
CI / test-with-coverage (pull_request) Successful in 1m16s
CI / coverage-analysis (pull_request) Successful in 3s
CI / test-with-beamline-plugins (pxii_bec) (pull_request) Successful in 1m38s
CI / test (3.12) (pull_request) Successful in 2m25s
CI / lint (pull_request) Failing after 4m27s
- ruff format and import ordering (main_window, data_collection_settings,
  beam_center_panel, beamline_state_panel)
- rename unused unpacked variable in test_title_label
- replace the mousePressEvent monkeypatch on the beamline state title
  with a proper eventFilter so basedpyright accepts the diff

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-08-06 15:28:14 +02:00
duan_jandClaude Fable 5 87c8b7771e feat: collapsible half-height panel banners with a universal gap
CI / lint (push) Skipped
CI / test (3.11) (push) Skipped
CI / test (3.12) (push) Skipped
CI / test (3.13) (push) Skipped
CI / test-with-beamline-plugins (pxi_bec) (push) Skipped
CI / test-with-beamline-plugins (pxii_bec) (push) Skipped
CI / test-with-beamline-plugins (pxiii_bec) (push) Skipped
CI / test (3.12) (pull_request) Successful in 48s
CI / test-with-beamline-plugins (pxiii_bec) (pull_request) Successful in 52s
CI / lint (pull_request) Failing after 1m47s
CI / test-with-beamline-plugins (pxi_bec) (pull_request) Successful in 2m27s
CI / test (3.13) (pull_request) Successful in 2m56s
CI / test-with-beamline-plugins (pxii_bec) (pull_request) Successful in 3m55s
CI / test-with-coverage (pull_request) Successful in 4m23s
CI / coverage-analysis (pull_request) Successful in 4s
CI / test (3.11) (pull_request) Successful in 7m2s
TitleLabel gains an optional collapsible mode: whole-banner click target,
bare +/- glyph (no pill background), per-title collapsed state persisted
in QSettings, and an expand() helper. Banners are halved to 25px with
plain text + QSS font (H3 margins would clip vertically).

- convert Zoom, Light, Omega, Smargon, Sample camera, Monochromator,
  ABR meas. pos., Beam mark, Beam center, Beam size, Dataset path and
  Loop centering to collapsible banners
- new collapsible Exp. Config. section wrapping the scan tabs
- move Manual sample from a bottom dock into the left column between
  Dataset path and Exp. Config.; Ctrl+M now expands it instead of
  raising the dock
- Beamline state banner restyled to match (25px, plain font, bare
  glyph, whole banner clickable)
- universal 11px banner gap via tighten_column() shared by both panel
  columns and the left column stack; ABR banner spans all grid columns
  and file path / manual sample drop side margins so widths align
- abort button sits under the tabs instead of pinned to the bottom
- unit tests for the collapse behavior

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-08-06 15:13:07 +02:00
perl_d f63107a1e0 style: ruff check --fix --unsafe-fixes 2026-07-31 15:57:17 +02:00
perl_d 7b79dd8ec5 style: remove pointless name-mangled attrs
CI / lint (push) Successful in 30s
CI / test (3.11) (push) Successful in 53s
CI / test (3.13) (push) Successful in 51s
CI / test (3.12) (push) Successful in 56s
the fact that removing them didn't break anything shows that they
were completely unneccessary - there is no inheritance tree
using the same names
2026-07-31 09:45:16 +02:00
perl_d 0451b8cebb style: ruff format 2026-07-27 14:45:12 +02:00
David Perl df3ddc5c84 Live changes from early July, PX-III
Build and Publish / test (pull_request_target) Successful in 2m59s
Build and Publish / build (pull_request_target) Successful in 19s
Build and Publish / Build and Deploy Docs (pull_request_target) Successful in 35s
2026-07-27 10:33:04 +02:00
perl_d 99326614ae style: ruff check fix 2026-07-06 15:39:02 +02:00
perl_d b0863e5ddb style: format with ruff
Build and Publish / test (pull_request) Failing after 1m23s
Build and Publish / build (pull_request) Skipped
Build and Publish / Build and Deploy Docs (pull_request) Skipped
2026-07-06 11:53:49 +02:00
perl_d 13bddd43c7 refactor: use aarecommon and remove common 2026-07-06 11:53:49 +02:00
appleb_mandClaude Opus 4.8 476aa69d70 data collection settings: panel-level Database/User-values toggle
Add DbOverrideLineEdit: a numeric field holding both a database value and
the user's value, driven by a per-tab Database/User-values toggle. The
user's value persists across samples, can be reverted to the database
value, and recovered again - replacing the clunky per-field checkboxes.

Fix the dtz<->resolution coupling so editing one updates the other in both
Database and User modes (previously it broke whenever a value was
overridden). Wire resolution, detector distance, transmission, exposure,
rotation total/image angle and the raster grid element size through the
new widget; other panels are untouched.

Add tests covering persist/revert/recover, the toggle's downstream emit,
the dtz/resolution coupling in both modes, and cross-sample persistence.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-24 15:30:08 +02:00
appleb_m c1edacc9c3 Added style sheet options - protrait style needs to be added to more places. 2026-06-24 15:30:05 +02:00
appleb_m e95eff9751 tests: refactord tests based on changes to auth and sample info
Build and Publish / test (push) Successful in 1m41s
Build and Publish / build (push) Successful in 18s
Build and Publish / Build and Deploy Docs (push) Successful in 40s
2026-06-10 15:19:53 +02:00
appleb_m 076c796b4d tests: updated tests for new authentication protocols and for new sample short info 2026-06-10 14:27:37 +02:00
appleb_m 86ceebb120 tests: fixed errros with DataCollectionParameter assumptions in tests
Build and Publish / test (push) Successful in 1m40s
Build and Publish / build (push) Failing after 17s
Build and Publish / Build and Deploy Docs (push) Skipped
2026-06-09 12:00:15 +02:00
appleb_m 0a47294244 gui_tests: removed irrelevant import/mocking that was causing tests to fail 2026-06-09 11:16:09 +02:00
appleb_m c6ee5560a0 EXCEPTION REFACTOR: Large scale exception refactor mdipoint, to be tested. If broken scale back this commit and fix tests 2026-06-03 15:57:26 +02:00
appleb_m b8e31a749d tests: fixing broken tests after refactor 2026-06-03 15:53:29 +02:00
appleb_m 3654e126e6 tests: more tests 2026-05-22 18:05:46 +02:00
appleb_m 856c2ba34b DAQ/GUI: removed automation workflow manager runner, workflow, models and tidied up GUI/DAQ as it is not in use at the moment. 2026-05-01 16:53:03 +02:00
appleb_m f1b7cf35d9 tests: AutomationProgressPanel test 2026-05-01 16:20:58 +02:00
appleb_m 947e142f6e DAQ/GUI updated: gui session handling in daq and gui so staff can now close erroneous GUIs and see who has the baton. Added tests
Build and Publish / test (push) Successful in 1m26s
Build and Publish / build (push) Successful in 15s
Build and Publish / Build and Deploy Docs (push) Successful in 38s
2026-04-30 14:03:10 +02:00
appleb_m 4eb50b0deb tests: added further unit tests. 2026-04-27 11:57:36 +02:00
appleb_m 7168f5512d tests: added gui tests and furtehr tests in daq and common 2026-04-24 14:52:00 +02:00
appleb_m 8fe5183f8e GUI/DAQ: allowed beamline_state_panel to move to states such as DC and RSE if transitiion is allowed (harder to define) 2026-04-23 17:21:19 +02:00
appleb_m 6e2023cefa tests: added more tests, pytest ini options in pyporject toml 2026-04-22 16:59:30 +02:00
appleb_m 2ccb3aa7ae TESTS: added some simple tests to the GUI 2026-04-22 15:59:55 +02:00