From 9f12167599c90dc9e71ea71d6fb0e03fd10ca7bb Mon Sep 17 00:00:00 2001 From: David Perl Date: Wed, 9 Sep 2026 11:49:34 +0200 Subject: [PATCH] fix: update spreadsheetupdater tests --- tests/unit/daq/test_spreadsheetupdater.py | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/tests/unit/daq/test_spreadsheetupdater.py b/tests/unit/daq/test_spreadsheetupdater.py index 56ce46d9..078d3f36 100644 --- a/tests/unit/daq/test_spreadsheetupdater.py +++ b/tests/unit/daq/test_spreadsheetupdater.py @@ -11,10 +11,7 @@ from aare.daq.spreadsheetupdater import get_ws_headers, on_message, set_spreadsh def mock_config(): with patch("aare.daq.spreadsheetupdater.config") as mock: mock._bl = "X10SA" - mock._client = MagicMock() - # Mocking private attributes access which the code uses - mock._client = mock._client - mock._bl = mock._bl + mock.redis = MagicMock() yield mock @@ -33,8 +30,7 @@ def test_set_spreadsheet_in_redis(mock_config): data = {"test": "data"} with patch("aare.daq.spreadsheetupdater.config") as mock_cfg_internal: mock_client = MagicMock() - mock_cfg_internal._client = mock_client - mock_cfg_internal.client = mock_client + mock_cfg_internal.redis = mock_client set_spreadsheet_in_redis(data) @@ -87,7 +83,7 @@ def test_on_message_success(mock_config): with patch("aare.daq.spreadsheetupdater.PuckWithTellPosition", side_effect=mock_pucks): on_message(None, message) - calls = mock_config._client.set.call_args_list + calls = mock_config.redis.set.call_args_list written_keys = [call.args[0] for call in calls] assert "X10SA:sample_spreadsheet" in written_keys @@ -118,9 +114,9 @@ def test_on_message_empty_ref(mock_config): on_message(None, message) ref_key = "X10SA:reference-tools" - mock_config._client.delete.assert_called_with(ref_key) + mock_config.redis.delete.assert_called_with(ref_key) def test_on_message_invalid_json(mock_config): on_message(None, "invalid json") - mock_config._client.set.assert_not_called() + mock_config.redis.set.assert_not_called()