- fixed some potential bugs introduced when replacing strncpy and

strncat by strlcpy and strlcat
2010-04-14 08:46:17 +00:00
parent 1c558e7f6c
commit 9690db1c3d
10 changed files with 20 additions and 20 deletions
--- a/help.c
+++ b/help.c
@ -43,9 +43,9 @@ static FILE *findHelpFile(char *name)

  pPtr = helpDirs;
  while ((pPtr = stptok(pPtr, dir, 131, PATHSEP)) != NULL) {
-    strcpy(pBueffel, dir);
-    strcat(pBueffel, DIRSEP);
-    strlcat(pBueffel, name, (254 - strlen(pBueffel)));
+    strlcpy(pBueffel, dir, sizeof pBueffel);
+    strlcat(pBueffel, DIRSEP, sizeof pBueffel);
+    strlcat(pBueffel, name, sizeof pBueffel);
    fd = fopen(pBueffel, "r");
    if (fd != NULL) {
      return fd;