- After a bug at TRICS I replaced all occurrences of strcpy, strcat, sprintf
by length limited versions wherever appropriate. SKIPPED: psi/el755driv.c psi/faverage.c psi/frame.c psi/lmd200.c psi/polterwrite.c psi/psi.c psi/sanswave.c psi/sinqhmdriv.c psi/termprot.c
This commit is contained in:
10
telnet.c
10
telnet.c
@ -46,7 +46,7 @@ pTelTask CreateTelnet(SConnection * pCon)
|
||||
pRes->pCon = pCon;
|
||||
pRes->iLogin = 0;
|
||||
pRes->tStart = time(&shit);
|
||||
strcpy(pRes->pLoginWord, pPtr);
|
||||
strncpy(pRes->pLoginWord, pPtr,131);
|
||||
return pRes;
|
||||
}
|
||||
|
||||
@ -164,7 +164,7 @@ int TelnetTaskOld(void *pData)
|
||||
pPasswd = strtok(NULL, " \t\r\n");
|
||||
iRet = IsValidUser(pUser, pPasswd);
|
||||
if (iRet < 0) {
|
||||
sprintf(pBuffer, "SYSTEM ATTACK by %s / %s", pUser, pPasswd);
|
||||
snprintf(pBuffer,sizeof(pBuffer)-1, "SYSTEM ATTACK by %s / %s", pUser, pPasswd);
|
||||
SICSLogWrite(pBuffer, eInternal);
|
||||
SCWrite(self->pCon,
|
||||
"I do not know you, I do not let you in", eError);
|
||||
@ -173,7 +173,7 @@ int TelnetTaskOld(void *pData)
|
||||
return 1;
|
||||
} else {
|
||||
NETInfo(self->pCon->pSock, pHost, 131);
|
||||
sprintf(pBuffer, "Accepted connection on socket %d from %s",
|
||||
snprintf(pBuffer,sizeof(pBuffer)-1, "Accepted connection on socket %d from %s",
|
||||
self->pCon->pSock->sockid, pHost);
|
||||
SICSLogWrite(pBuffer, eInternal);
|
||||
WriteToCommandLog("SYS >", pBuffer);
|
||||
@ -272,7 +272,7 @@ int TelnetTask(void *pData)
|
||||
pPasswd = strtok(NULL, " \t\r\n");
|
||||
iRet = IsValidUser(pUser, pPasswd);
|
||||
if (iRet < 0) {
|
||||
sprintf(pBuffer, "SYSTEM ATTACK by %s / %s", pUser, pPasswd);
|
||||
snprintf(pBuffer,sizeof(pBuffer)-1, "SYSTEM ATTACK by %s / %s", pUser, pPasswd);
|
||||
SICSLogWrite(pBuffer, eInternal);
|
||||
SCWrite(self->pCon,
|
||||
"I do not know you, I do not let you in", eError);
|
||||
@ -280,7 +280,7 @@ int TelnetTask(void *pData)
|
||||
free(pPtr);
|
||||
return 1;
|
||||
} else {
|
||||
sprintf(pBuffer, "Accepted telnet connection on handle %d",
|
||||
snprintf(pBuffer,sizeof(pBuffer)-1, "Accepted telnet connection on handle %d",
|
||||
self->pCon->sockHandle);
|
||||
SICSLogWrite(pBuffer, eInternal);
|
||||
WriteToCommandLog("SYS >", pBuffer);
|
||||
|
Reference in New Issue
Block a user