use Properties from secop.properties for datatypes

this change is triggered by the fact, that assigining a unit
in the config file did no longer work.

this change has several implications:
1) secop.properties must not import secop.datatypes:
   - as ValueType can not be imported, the default behaviour with
     'mandatory' and 'default' arguments was slightly changed
   - instead of checking for DataType when exporting, a try/except
     was used
2) the datatype of datatype properties is sometimes not yet defined.
   a stub is used in this cases instead, which is later replaced by
   the proper datatype. The number of stubs may be reduced, but this
   should be done in a later change, as the diff will be much less
   readable.
3) in config files, datatype properties can be changed like parameter
   properties. HasProperties.setProperties/checkProperties/getProperties
   are overridden for this.

the config editor seems still to work, an issue (probably py3) had
to be fixed there

Change-Id: I1efddf51f2c760510e913dbcaa099e8a89c9cab5
Reviewed-on: https://forge.frm2.tum.de/review/c/sine2020/secop/playground/+/21399
Tested-by: JenkinsCodeReview <bjoern_pedersen@frm2.tum.de>
Reviewed-by: Enrico Faulhaber <enrico.faulhaber@frm2.tum.de>
Reviewed-by: Markus Zolliker <markus.zolliker@psi.ch>

test/test_modules.py

@@ -31,7 +31,6 @@ from secop.modules import Communicator, Drivable, Module
 from secop.params import Command, Override, Parameter
 
 
-
 def test_Communicator():
     logger = type('LoggerStub', (object,), dict(
         debug = lambda self, *a: print(*a),
@@ -54,11 +53,12 @@ def test_Communicator():
     assert event.is_set() # event should be set immediately
 
 def test_ModuleMeta():
+    # pylint: disable=too-many-function-args
     newclass1 = ModuleMeta.__new__(ModuleMeta, 'TestDrivable', (Drivable,), {
         "parameters" : {
             'pollinterval': Override(reorder=True),
             'param1' : Parameter('param1', datatype=BoolType(), default=False),
-            'param2': Parameter('param2', datatype=BoolType(), default=True),
+            'param2': Parameter('param2', datatype=FloatRange(unit='Ohm'), default=True),
             "cmd": Command('stuff', argument=BoolType(), result=BoolType())
         },
         "commands": {
@@ -82,10 +82,12 @@ def test_ModuleMeta():
     sortcheck1 = ['value', 'status', 'target', 'pollinterval',
                  'param1', 'param2', 'cmd', 'a1', 'a2', 'cmd2']
 
+    # pylint: disable=too-many-function-args
     newclass2 = ModuleMeta.__new__(ModuleMeta, 'UpperClass', (newclass1,), {
         "parameters": {
             'cmd2': Override('another stuff'),
-            'a1': Override(datatype=FloatRange(), reorder=True),
+            'value': Override(datatype=FloatRange(unit='deg'), reorder=True),
+            'a1': Override(datatype=FloatRange(unit='$/s'), reorder=True),
             'b2': Parameter('a2', datatype=BoolType(), default=True),
         },
     })
@@ -125,6 +127,25 @@ def test_ModuleMeta():
             # HACK: atm. disabled to fix all other problems first.
             assert check_order + sorted(check_order)
 
+    o1 = newclass1('o1', logger, {'.description':''}, srv)
+    o2 = newclass2('o2', logger, {'.description':''}, srv)
+    assert o2.parameters['a1'].datatype.unit == 'deg/s'
+    o2 = newclass2('o2', logger, {'.description':'', 'value.unit':'mm', 'param2.unit':'mm'}, srv)
+    # check datatype is not shared
+    assert o1.parameters['param2'].datatype.unit == 'Ohm'
+    assert o2.parameters['param2'].datatype.unit == 'mm'
+    # check '$' in unit works properly
+    assert o2.parameters['a1'].datatype.unit == 'mm/s'
+    cfg = newclass2.configurables
+    assert set(cfg.keys()) == {'export', 'group', 'description',
+        'meaning', 'visibility', 'implementation', 'interface_class', 'target', 'stop',
+        'status', 'param1', 'param2', 'cmd', 'a2', 'pollinterval', 'b2', 'cmd2', 'value',
+        'a1'}
+    assert set(cfg['value'].keys()) == {'group', 'export', 'relative_resolution',
+        'visibility', 'unit', 'default', 'optional', 'datatype', 'fmtstr',
+        'absolute_resolution', 'poll', 'max', 'min', 'readonly', 'constant',
+        'description'}
+
     # check on the level of classes
     # this checks newclass1 too, as it is inherited by newclass2
     for baseclass in newclass2.__mro__: