From ee5a945e11617e6db85dc39a5aefda7d46486554 Mon Sep 17 00:00:00 2001 From: Alexander Zaft Date: Thu, 7 Mar 2024 13:02:51 +0100 Subject: [PATCH] core: cover errors in handler setup() Change-Id: I0bb2f07e26717205c013dfedec6e1beca2947d17 Reviewed-on: https://forge.frm2.tum.de/review/c/secop/frappy/+/33239 Tested-by: Jenkins Automated Tests Reviewed-by: Enrico Faulhaber Reviewed-by: Alexander Zaft --- frappy/protocol/interface/handler.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/frappy/protocol/interface/handler.py b/frappy/protocol/interface/handler.py index b890155f..0d6977b1 100644 --- a/frappy/protocol/interface/handler.py +++ b/frappy/protocol/interface/handler.py @@ -61,10 +61,16 @@ class RequestHandler: self.request = request self.client_address = client_address self.server = server + self.log = None - self.setup() try: + self.setup() self.handle() + except Exception: + if self.log: + self.log.error(formatException()) + else: + server.log.error(formatException()) finally: self.finish()